[Bug 74679] New: Pyrit crashes with segmentation fault

[Bug 74679] New: Pyrit crashes with segmentation fault

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1317 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=74679

          Priority: medium
            Bug ID: 74679
          Assignee: dri-devel@lists.freedesktop.org
           Summary: Pyrit crashes with segmentation fault
          Severity: normal
    Classification: Unclassified
                OS: Linux (All)
          Reporter: Nzatkovich@gmail.com
          Hardware: x86-64 (AMD64)
            Status: NEW
           Version: git
         Component: Drivers/Gallium/r600
           Product: Mesa

Created attachment 93617
  --> https://bugs.freedesktop.org/attachment.cgi?id=93617&action=edit
This is the output of "R600_DEBUG=cs pyrit selftest", and the piglt all_cl test
results of both GPUs

OS: Ubuntu 13.10 with Linux kernel 3.13.1
LLVM/Clang: latest git from apt repos, 200925
libclc: git, 20140205
Mesa: git, 201402061930

Graphics card: Radeon R9 270X, aka AMD PITCAIRN

Every time I run a Pyrit selftest, it crashes with a segmentation fault. I have
tried this on my laptop with the same setup as above, except this had a Radeon
HD 6750M (aka AMD TURKS), and it ran fine.

I have attached the output of "R600_DEBUG=cs pyrit selftest".

I have also attached the output of the piglit all_cl tests for both the 6750M
and the R9 270X.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2941 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 74679] Pyrit crashes with segmentation fault

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 328 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=74679

--- Comment #1 from Nick Zatkovich <Nzatkovich@gmail.com> ---
Also, I forgot to mention, I was recompiling pyrit every time I updated any of
those repos, and it was from the pyrit svn on google code.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1080 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 74679] Pyrit crashes with segmentation fault

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 625 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=74679

--- Comment #2 from Tom Stellard <tstellar@gmail.com> ---
It works for me with these two patches:
http://people.freedesktop.org/~tstellar/0001-SelectionDAG-Factor-ISD-MUL-lowering-code-out-of-DAG.patch
http://people.freedesktop.org/~tstellar/0002-SelectionDAG-Use-helper-function-to-improve-legaliza.patch

Can you test these?  I have some other uncommitted patches in my tree, so if it
still doesn't work for you with these patches, I will push the branch I'm using
somewhere so you can test it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1609 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 74679] Pyrit crashes with segmentation fault

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 341 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=74679

--- Comment #3 from Nick Zatkovich <Nzatkovich@gmail.com> ---
Created attachment 93640
  --> https://bugs.freedesktop.org/attachment.cgi?id=93640&action=edit
Piglit tests on the R9 270x before and after the patch

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1292 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 74679] Pyrit crashes with segmentation fault

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 345 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=74679

--- Comment #4 from Nick Zatkovich <Nzatkovich@gmail.com> ---
Yes, it works! Thank you. Lets hope these patches land in upstream soon.

for posterity's sake, I've uploaded the piglit tests before and after the
patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1097 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 74679] Pyrit crashes with segmentation fault

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 510 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=74679

Nick Zatkovich <Nzatkovich@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Nick Zatkovich <Nzatkovich@gmail.com> ---
closing this as resolved.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1941 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 74679] Pyrit crashes with segmentation fault

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 583 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=74679

Tom Stellard <tstellar@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #6 from Tom Stellard <tstellar@gmail.com> ---
(In reply to comment #5)
> closing this as resolved.

Let's leave this open until the patches are committed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2047 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 74679] Pyrit crashes with segmentation fault

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 512 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=74679

Tom Stellard <tstellar@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Tom Stellard <tstellar@gmail.com> ---
I've committed these fixes to LLVM.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1940 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel