[Bug 76761] New: radeon driver breaks suspend to disk and resume from RAM in 3.14

[Bug 76761] New: radeon driver breaks suspend to disk and resume from RAM in 3.14

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=76761

            Bug ID: 76761
           Summary: radeon driver breaks suspend to disk and resume from
                    RAM in 3.14
           Product: Drivers
           Version: 2.5
    Kernel Version: 3.14.4 (debian 3.14.4-1 amd64)
          Hardware: All
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: high
          Priority: P1
         Component: Video(DRI - non Intel)
          Assignee: drivers_video-dri@kernel-bugs.osdl.org
          Reporter: vitalif@yourcmc.ru
        Regression: Yes

Hi!

The suspend/resume has broken again on my laptop with the 3.14 kernel. But it
works without any problem when I boot without radeon module, so I assume it's
the case.

The problem detail is:
- machine suspends to RAM without problem, but does not resume (hangs with
black screen during resume)
- machine does not suspend to disk (just hangs with black screen after
"snapshotting system", magic sysrq doesn't work so I assume that's an "oops"),
neither via s2disk or echo disk > /sys/power/state

Without the radeon module, everything works OK; the card is RV730.

Are there any other details I should provide?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 76761] radeon driver breaks suspend to disk and resume from RAM in 3.14

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=76761

Alex Deucher <alexdeucher@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexdeucher@gmail.com

--- Comment #1 from Alex Deucher <alexdeucher@gmail.com> ---
Can you bisect?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 76761] radeon driver breaks suspend to disk and resume from RAM in 3.14

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=76761

--- Comment #2 from Vitaliy Filippov <vitalif@yourcmc.ru> ---
Yes, I can try to bisect...

Just found Bug 63391 (Radeon RS880 doesn't resume from suspend with radeon dpm
enabled), and also tried to disable DPM - suspend works fine without it.

But DPM is an important feature for me, without it the laptop easily gets VERY
HOT! So I can't just disable DPM as it was done in Bug 63391...

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 76761] radeon DPM breaks suspend to disk and resume from RAM in 3.14

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=76761

Vitaliy Filippov <vitalif@yourcmc.ru> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|radeon driver breaks        |radeon DPM breaks suspend
                   |suspend to disk and resume  |to disk and resume from RAM
                   |from RAM in 3.14            |in 3.14

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 76761] radeon DPM breaks suspend to disk and resume from RAM in 3.14

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=76761

--- Comment #3 from Vitaliy Filippov <vitalif@yourcmc.ru> ---
OK I did bisect.

The result is:

6c7bccea390853bdec5b76fe31fc50f3b36f75d5 is the first bad commit
commit 6c7bccea390853bdec5b76fe31fc50f3b36f75d5
Author: Alex Deucher <alexander.deucher@amd.com>
Date:   Wed Dec 18 14:07:14 2013 -0500

    drm/radeon/pm: move pm handling into the asic specific code

    We need more control over the ordering of dpm init with
    respect to the rest of the asic.  Specifically, the SMC
    has to be initialized before the rlc and cg/pg.  The pm
    code currently initializes late in the driver, but we need
    it to happen much earlier so move pm handling into the asic
    specific callbacks.

    This makes dpm more reliable and makes clockgating work
    properly on CIK parts and should help on SI parts as well.

    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 76761] radeon DPM breaks suspend to disk and resume from RAM in 3.14

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=76761

--- Comment #4 from Vitaliy Filippov <vitalif@yourcmc.ru> ---
Do you need any other details about this bug? :)

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 76761] radeon DPM breaks suspend to disk and resume from RAM in 3.14

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=76761

--- Comment #5 from Vitaliy Filippov <vitalif@yourcmc.ru> ---
Alex, do you have any suggestions?..

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 76761] radeon DPM breaks suspend to disk and resume from RAM in 3.14

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=76761

--- Comment #6 from Alex Deucher <alexdeucher@gmail.com> ---
It was a long weekend in the US.  I haven't had a chance to look into it yet.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 76761] radeon DPM breaks suspend to disk and resume from RAM in 3.14

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=76761

--- Comment #7 from Alex Deucher <alexdeucher@gmail.com> ---
Created attachment 137731
  --> https://bugzilla.kernel.org/attachment.cgi?id=137731&action=edit
possible fix

Does this patch help?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 76761] radeon DPM breaks suspend to disk and resume from RAM in 3.14

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=76761

Alex Deucher <alexdeucher@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137731|0                           |1
        is obsolete|                            |

--- Comment #8 from Alex Deucher <alexdeucher@gmail.com> ---
Created attachment 137741
  --> https://bugzilla.kernel.org/attachment.cgi?id=137741&action=edit
better fix

Please try this patch instead.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 76761] radeon DPM breaks suspend to disk and resume from RAM in 3.14

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=76761

--- Comment #9 from Vitaliy Filippov <vitalif@yourcmc.ru> ---
Yes, everything works with it, thanks!

So, in which kernel version are you planning to include this fix?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 76761] radeon DPM breaks suspend to disk and resume from RAM in 3.14

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=76761

--- Comment #10 from Alex Deucher <alexdeucher@gmail.com> ---
3.15 is we can make it in in time, otherwise 3.16.  I've cc'ed stable so it
will show up in older kernels as well too once it's applied upstream.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 76761] radeon DPM breaks suspend to disk and resume from RAM in 3.14

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=76761

--- Comment #11 from Vitaliy Filippov <vitalif@yourcmc.ru> ---
Thanks, I'll wait for the inclusion :-)

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 76761] radeon DPM breaks suspend to disk and resume from RAM in 3.14

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=76761

swoorupj@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |swoorupj@gmail.com

--- Comment #12 from swoorupj@gmail.com ---
Hi Alex,

I have reported the same issue in bugs.freedesktop. I tried out the 3.15 linux
kernel in archlinux just today. And this issue is still prevalent to me. 

Resuming from suspend still results a blank screen using the radeon module in
the kernel.

dmesg logs: http://ix.io/cSi

I have a AMD A6-4400M APU that integrates  Radeon HD 7520G.

Kind Regards,
Swoorup Joshi

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 76761] radeon DPM breaks suspend to disk and resume from RAM in 3.14

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=76761

--- Comment #13 from Alex Deucher <alexdeucher@gmail.com> ---
(In reply to swoorupj from comment #12)
> Hi Alex,
> 
> I have reported the same issue in bugs.freedesktop. I tried out the 3.15
> linux kernel in archlinux just today. And this issue is still prevalent to
> me. 

Is it the same commit (6c7bccea390853bdec5b76fe31fc50f3b36f75d5) that caused
the regression for you as well?  If not, you are experienceing a different
issue.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 76761] radeon DPM breaks suspend to disk and resume from RAM in 3.14

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=76761

--- Comment #14 from swoorupj@gmail.com ---
(In reply to Alex Deucher from comment #13)
> (In reply to swoorupj from comment #12)
> > Hi Alex,
> > 
> > I have reported the same issue in bugs.freedesktop. I tried out the 3.15
> > linux kernel in archlinux just today. And this issue is still prevalent to
> > me. 
> 
> Is it the same commit (6c7bccea390853bdec5b76fe31fc50f3b36f75d5) that caused
> the regression for you as well?  If not, you are experienceing a different
> issue.

No, this issue has been occurring since kernel 3.8.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 76761] radeon DPM breaks suspend to disk and resume from RAM in 3.14

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=76761

--- Comment #15 from swoorupj@gmail.com ---
Is there a way or patch, I could get all the state of the card and test how
they differ before and after suspending?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 76761] radeon DPM breaks suspend to disk and resume from RAM in 3.14

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=76761

--- Comment #16 from Vitaliy Filippov <vitalif@yourcmc.ru> ---
Since you know everything was ok in 3.8, maybe you'll just also try to bisect?
:)

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 76761] radeon DPM breaks suspend to disk and resume from RAM in 3.14

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=76761

--- Comment #17 from swoorupj@gmail.com ---
Sorry I have mislead you. I meant I started using linux since 3.8. And I have
had this problem since. I don't recall it working with KMS.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 76761] radeon DPM breaks suspend to disk and resume from RAM in 3.14

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=76761

--- Comment #18 from Alex Deucher <alexdeucher@gmail.com> ---
swoorupj you have some other issue then.  It's not related to this bug.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 76761] radeon DPM breaks suspend to disk and resume from RAM in 3.14

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=76761

StephenH <hafflys@earthlink.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hafflys@earthlink.net

--- Comment #19 from StephenH <hafflys@earthlink.net> ---
Fedora kernel 3.15.x versions on an Acer Aspire One netbook with AMD C50
processor and Radeon driver has this problem.
Kernel 3.14.x and earlier kernel versions did not have this problem.

Whatever changed between 3.14.x and 3.15.x has caused this problem. I have a
bug report at https://bugzilla.redhat.com/show_bug.cgi?id=1121838 but I think
the problem will need to be addressed here, upstream from Fedora.

Kernels 3.14 and under = work fine.
Kernels 3.15.x != work

I asked in the buzilla report cited above what changed that could cause this
and how do I fix it? With Fedora working to rebase Fedora 20 to 3.16.x, if the
problem has not been fixed, then there will be problems. This will be even more
so when Fedora 21 is released and Fedora 19 becomes an E.O.L. version. I am
currently running Fedora 20, but I have to use a Fedora 19 kernel
(3.14.17-100.fc19.x86_64) in order to have suspend/resume work properly.

Please don't ask me to bisect unless you give me explicit directions on how to
do so. I have no idea what bisecting does or how to do it. I'm not a developer.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.