[Bug 77305] New: Compile error in pipe-loader files (pipe_r300.c pipe_r600.c pipe_radeonsi.c egl_pipe.c)

[Bug 77305] New: Compile error in pipe-loader files (pipe_r300.c pipe_r600.c pipe_radeonsi.c egl_pipe.c)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 2010 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=77305

          Priority: medium
            Bug ID: 77305
          Assignee: dri-devel@lists.freedesktop.org
           Summary: Compile error in pipe-loader files (pipe_r300.c
                    pipe_r600.c pipe_radeonsi.c egl_pipe.c)
          Severity: normal
    Classification: Unclassified
                OS: Linux (All)
          Reporter: knut.tidemann@gmail.com
          Hardware: x86-64 (AMD64)
            Status: NEW
           Version: git
         Component: Drivers/Gallium/r600
           Product: Mesa

Created attachment 97213
  --> https://bugs.freedesktop.org/attachment.cgi?id=97213&action=edit
patch for build failure

When building the latest mesa code today from git
(227049098b59bca88883a750602fdad41949c996), I was unable to build due to an
error that looks like a missing radeon_winsys.h include after the following
commit: 3b0b44f7def0acb4f7a7aef086c0bece321418a6.

Example of error:
pipe_r300.c: In function 'create_screen':
pipe_r300.c:13:38: error: dereferencing pointer to incomplete type
    return sws ? debug_screen_wrap(sws->screen) : NULL;
                                      ^

I've attached a patch that fixes the build issue for me.

I build mesa with the following options:

  ./autogen.sh --prefix=/usr \
    --sysconfdir=/etc \
    --with-dri-driverdir=/usr/lib/xorg/modules/dri \
    --with-gallium-drivers=r300,r600,radeonsi,nouveau,svga,swrast \
    --with-dri-drivers=i915,i965,r200,radeon,nouveau,swrast \
    --with-egl-platforms=drm,x11,wayland \
    --with-llvm-shared-libs \
    --enable-gallium-egl --enable-shared-glapi \
    --enable-gallium-llvm \
    --enable-glx-tls \
    --enable-gles1 \
    --enable-gles2 \
    --enable-egl \
    --enable-dri \
    --enable-glx \
    --enable-xa \
    --enable-osmesa \
    --enable-gbm \
    --enable-texture-float \
    --enable-vdpau \
    --enable-opencl \
    --enable-opencl-icd

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 77305] Compile error in pipe-loader files (pipe_r300.c pipe_r600.c pipe_radeonsi.c egl_pipe.c)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 548 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=77305

Tom Stellard <tstellar@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Tom Stellard <tstellar@gmail.com> ---
Committed the patch as ac3435a47c616286c5a5ee16148f829493c2127, thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2121 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 77305] Compile error in pipe-loader files (pipe_r300.c pipe_r600.c pipe_radeonsi.c egl_pipe.c)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 935 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=77305

--- Comment #2 from Simone Scanzoni <nonno.cicala@tiscali.it> ---
Created attachment 97248
  --> https://bugs.freedesktop.org/attachment.cgi?id=97248&action=edit
patch for build failure with r600 and radeonsi

The bug isn't fixed upstream for r600 and radeonsi.

The attached patch solves the problem fixing these:

egl_pipe.c: In function 'pipe_r600_create_screen':
egl_pipe.c:153:4: error: implicit declaration of function
'radeon_drm_winsys_create' [-Werror=implicit-function-declaration]
egl_pipe.c:154:36: error: dereferencing pointer to incomplete type

egl_pipe.c: In function 'pipe_radeonsi_create_screen':
egl_pipe.c:168:4: error: implicit declaration of function
'radeon_drm_winsys_create' [-Werror=implicit-function-declaration]
egl_pipe.c:169:36: error: dereferencing pointer to incomplete type

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2102 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 77305] Compile error in pipe-loader files (pipe_r300.c pipe_r600.c pipe_radeonsi.c egl_pipe.c)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 563 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=77305

Laurent carlier <lordheavym@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexandre.f.demers@gmail.co
                   |                            |m

--- Comment #3 from Laurent carlier <lordheavym@gmail.com> ---
*** Bug 77358 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2266 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 77305] Compile error in pipe-loader files (pipe_r300.c pipe_r600.c pipe_radeonsi.c egl_pipe.c)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 420 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=77305

Laurent carlier <lordheavym@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1258 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 77305] Compile error in pipe-loader files (pipe_r300.c pipe_r600.c pipe_radeonsi.c egl_pipe.c)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 405 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=77305

--- Comment #4 from Knut Andre Tidemann <knut.tidemann@gmail.com> ---
I think 9d36a8d4d27230dd91d4c4002a781edeec22d044 broke it again if you do not
build with R300 as well.

It works fine here when I build with R300.

The attached patch fixes the issue when R300 is not built.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1285 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 77305] Compile error in pipe-loader files (pipe_r300.c pipe_r600.c pipe_radeonsi.c egl_pipe.c)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 579 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=77305

--- Comment #5 from Simone Scanzoni <nonno.cicala@tiscali.it> ---
(In reply to comment #4)
> I think 9d36a8d4d27230dd91d4c4002a781edeec22d044 broke it again if you do
> not build with R300 as well.
> 
> It works fine here when I build with R300.
> 
> The attached patch fixes the issue when R300 is not built.

You are probably right.
My wording wasn't exact, the patch I attached fixes the build failure when
building only r600 or radeonsi, or both.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1540 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 77305] Compile error in pipe-loader files (pipe_r300.c pipe_r600.c pipe_radeonsi.c egl_pipe.c)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1091 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=77305

--- Comment #6 from Alexandre Demers <alexandre.f.demers@gmail.com> ---
(In reply to comment #2)
> Created attachment 97248 [details] [review]
> patch for build failure with r600 and radeonsi
> 
> The bug isn't fixed upstream for r600 and radeonsi.
> 
> The attached patch solves the problem fixing these:
> 
> egl_pipe.c: In function 'pipe_r600_create_screen':
> egl_pipe.c:153:4: error: implicit declaration of function
> 'radeon_drm_winsys_create' [-Werror=implicit-function-declaration]
> egl_pipe.c:154:36: error: dereferencing pointer to incomplete type
> 
> egl_pipe.c: In function 'pipe_radeonsi_create_screen':
> egl_pipe.c:168:4: error: implicit declaration of function
> 'radeon_drm_winsys_create' [-Werror=implicit-function-declaration]
> egl_pipe.c:169:36: error: dereferencing pointer to incomplete type


Your patch was applied and tested on 857f3a68ea7370d1db2ef5faca181a36ada7d49d
and I confirm this fixes the build.

Tested-by: Alexandre Demers

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2416 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 77305] Compile error in pipe-loader files (pipe_r300.c pipe_r600.c pipe_radeonsi.c egl_pipe.c)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1284 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=77305

Marek Olšák <maraeo@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Marek Olšák <maraeo@gmail.com> ---
(In reply to comment #2)
> Created attachment 97248 [details] [review]
> patch for build failure with r600 and radeonsi
> 
> The bug isn't fixed upstream for r600 and radeonsi.
> 
> The attached patch solves the problem fixing these:
> 
> egl_pipe.c: In function 'pipe_r600_create_screen':
> egl_pipe.c:153:4: error: implicit declaration of function
> 'radeon_drm_winsys_create' [-Werror=implicit-function-declaration]
> egl_pipe.c:154:36: error: dereferencing pointer to incomplete type
> 
> egl_pipe.c: In function 'pipe_radeonsi_create_screen':
> egl_pipe.c:168:4: error: implicit declaration of function
> 'radeon_drm_winsys_create' [-Werror=implicit-function-declaration]
> egl_pipe.c:169:36: error: dereferencing pointer to incomplete type

I pushed your patch. Closing.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3344 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel