* [Bug 77673] [bisected] moving moire starting with "drm/radeon: improve PLL params if we don't match exactly v2"
2014-04-19 15:38 [Bug 77673] New: [bisected] moving moire starting with "drm/radeon: improve PLL params if we don't match exactly v2" bugzilla-daemon
@ 2014-04-19 15:39 ` bugzilla-daemon
2014-04-19 15:39 ` bugzilla-daemon
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: bugzilla-daemon @ 2014-04-19 15:39 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 316 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=77673
--- Comment #1 from Jaime Velasco Juan <jsagarribay@gmail.com> ---
Created attachment 97607
--> https://bugs.freedesktop.org/attachment.cgi?id=97607&action=edit
dmesg of working version
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1356 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug 77673] [bisected] moving moire starting with "drm/radeon: improve PLL params if we don't match exactly v2"
2014-04-19 15:38 [Bug 77673] New: [bisected] moving moire starting with "drm/radeon: improve PLL params if we don't match exactly v2" bugzilla-daemon
2014-04-19 15:39 ` [Bug 77673] " bugzilla-daemon
@ 2014-04-19 15:39 ` bugzilla-daemon
2014-04-19 15:51 ` bugzilla-daemon
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: bugzilla-daemon @ 2014-04-19 15:39 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 315 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=77673
--- Comment #2 from Jaime Velasco Juan <jsagarribay@gmail.com> ---
Created attachment 97608
--> https://bugs.freedesktop.org/attachment.cgi?id=97608&action=edit
dmesg of broken version
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1353 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug 77673] [bisected] moving moire starting with "drm/radeon: improve PLL params if we don't match exactly v2"
2014-04-19 15:38 [Bug 77673] New: [bisected] moving moire starting with "drm/radeon: improve PLL params if we don't match exactly v2" bugzilla-daemon
2014-04-19 15:39 ` [Bug 77673] " bugzilla-daemon
2014-04-19 15:39 ` bugzilla-daemon
@ 2014-04-19 15:51 ` bugzilla-daemon
2014-04-19 16:00 ` bugzilla-daemon
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: bugzilla-daemon @ 2014-04-19 15:51 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 322 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=77673
--- Comment #3 from Alex Deucher <agd5f@yahoo.com> ---
Looks like the new pll computation is not respecting the
RADEON_PLL_USE_FRAC_FB_DIV flag. Older asics shouldn't use fraction fb
dividers.
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1211 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug 77673] [bisected] moving moire starting with "drm/radeon: improve PLL params if we don't match exactly v2"
2014-04-19 15:38 [Bug 77673] New: [bisected] moving moire starting with "drm/radeon: improve PLL params if we don't match exactly v2" bugzilla-daemon
` (2 preceding siblings ...)
2014-04-19 15:51 ` bugzilla-daemon
@ 2014-04-19 16:00 ` bugzilla-daemon
2014-04-19 16:58 ` bugzilla-daemon
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: bugzilla-daemon @ 2014-04-19 16:00 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 516 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=77673
--- Comment #4 from Alex Deucher <agd5f@yahoo.com> ---
(In reply to comment #3)
> Looks like the new pll computation is not respecting the
> RADEON_PLL_USE_FRAC_FB_DIV flag. Older asics shouldn't use fraction fb
> dividers.
Nevermind, we always set the RADEON_PLL_USE_FRAC_FB_DIV for LVDS if spread
spectrum is enabled. Looks like we aren't respecting RADEON_PLL_USE_REF_DIV
properly.
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1481 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug 77673] [bisected] moving moire starting with "drm/radeon: improve PLL params if we don't match exactly v2"
2014-04-19 15:38 [Bug 77673] New: [bisected] moving moire starting with "drm/radeon: improve PLL params if we don't match exactly v2" bugzilla-daemon
` (3 preceding siblings ...)
2014-04-19 16:00 ` bugzilla-daemon
@ 2014-04-19 16:58 ` bugzilla-daemon
2014-04-19 17:00 ` bugzilla-daemon
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: bugzilla-daemon @ 2014-04-19 16:58 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 315 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=77673
--- Comment #5 from Christian König <deathsimple@vodafone.de> ---
Created attachment 97609
--> https://bugs.freedesktop.org/attachment.cgi?id=97609&action=edit
Possible fix.
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1436 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug 77673] [bisected] moving moire starting with "drm/radeon: improve PLL params if we don't match exactly v2"
2014-04-19 15:38 [Bug 77673] New: [bisected] moving moire starting with "drm/radeon: improve PLL params if we don't match exactly v2" bugzilla-daemon
` (4 preceding siblings ...)
2014-04-19 16:58 ` bugzilla-daemon
@ 2014-04-19 17:00 ` bugzilla-daemon
2014-04-19 17:43 ` bugzilla-daemon
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: bugzilla-daemon @ 2014-04-19 17:00 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 448 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=77673
--- Comment #6 from Christian König <deathsimple@vodafone.de> ---
Please try the attached patch.
We now always use the fixed reference divider if both RADEON_PLL_USE_REF_DIV
and RADEON_PLL_USE_FRAC_FB_DIV are set.
If only RADEON_PLL_USE_REF_DIV is set then we only use the fixed value as
minimum limit.
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1369 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug 77673] [bisected] moving moire starting with "drm/radeon: improve PLL params if we don't match exactly v2"
2014-04-19 15:38 [Bug 77673] New: [bisected] moving moire starting with "drm/radeon: improve PLL params if we don't match exactly v2" bugzilla-daemon
` (5 preceding siblings ...)
2014-04-19 17:00 ` bugzilla-daemon
@ 2014-04-19 17:43 ` bugzilla-daemon
2014-04-20 1:20 ` bugzilla-daemon
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: bugzilla-daemon @ 2014-04-19 17:43 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 508 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=77673
--- Comment #7 from Jaime Velasco Juan <jsagarribay@gmail.com> ---
(In reply to comment #6)
> Please try the attached patch.
>
> We now always use the fixed reference divider if both RADEON_PLL_USE_REF_DIV
> and RADEON_PLL_USE_FRAC_FB_DIV are set.
>
> If only RADEON_PLL_USE_REF_DIV is set then we only use the fixed value as
> minimum limit.
The path fixes the issue. Thanks!
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1497 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug 77673] [bisected] moving moire starting with "drm/radeon: improve PLL params if we don't match exactly v2"
2014-04-19 15:38 [Bug 77673] New: [bisected] moving moire starting with "drm/radeon: improve PLL params if we don't match exactly v2" bugzilla-daemon
` (6 preceding siblings ...)
2014-04-19 17:43 ` bugzilla-daemon
@ 2014-04-20 1:20 ` bugzilla-daemon
2014-04-20 8:09 ` bugzilla-daemon
2014-04-20 10:34 ` bugzilla-daemon
9 siblings, 0 replies; 11+ messages in thread
From: bugzilla-daemon @ 2014-04-20 1:20 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 612 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=77673
--- Comment #8 from Alex Deucher <agd5f@yahoo.com> ---
(In reply to comment #6)
> Please try the attached patch.
>
> We now always use the fixed reference divider if both RADEON_PLL_USE_REF_DIV
> and RADEON_PLL_USE_FRAC_FB_DIV are set.
>
> If only RADEON_PLL_USE_REF_DIV is set then we only use the fixed value as
> minimum limit.
Does that make sense? Wouldn't we want to use use the fixed value if
RADEON_PLL_USE_REF_DIV regardless of whether RADEON_PLL_USE_FRAC_FB_DIV is set?
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1589 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug 77673] [bisected] moving moire starting with "drm/radeon: improve PLL params if we don't match exactly v2"
2014-04-19 15:38 [Bug 77673] New: [bisected] moving moire starting with "drm/radeon: improve PLL params if we don't match exactly v2" bugzilla-daemon
` (7 preceding siblings ...)
2014-04-20 1:20 ` bugzilla-daemon
@ 2014-04-20 8:09 ` bugzilla-daemon
2014-04-20 10:34 ` bugzilla-daemon
9 siblings, 0 replies; 11+ messages in thread
From: bugzilla-daemon @ 2014-04-20 8:09 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 958 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=77673
--- Comment #9 from Christian König <deathsimple@vodafone.de> ---
(In reply to comment #8)
> (In reply to comment #6)
> > Please try the attached patch.
> >
> > We now always use the fixed reference divider if both RADEON_PLL_USE_REF_DIV
> > and RADEON_PLL_USE_FRAC_FB_DIV are set.
> >
> > If only RADEON_PLL_USE_REF_DIV is set then we only use the fixed value as
> > minimum limit.
>
> Does that make sense? Wouldn't we want to use use the fixed value if
> RADEON_PLL_USE_REF_DIV regardless of whether RADEON_PLL_USE_FRAC_FB_DIV is
> set?
I don't really know, it's just the way how the old code handled this.
If RADEON_PLL_USE_REF_DIV was set the RADEON_PLL_USE_FRAC_FB_DIV branch just
used the value as provided, but the none RADEON_PLL_USE_FRAC_FB_DIV branch
still tried to increment the vale.
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 2042 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug 77673] [bisected] moving moire starting with "drm/radeon: improve PLL params if we don't match exactly v2"
2014-04-19 15:38 [Bug 77673] New: [bisected] moving moire starting with "drm/radeon: improve PLL params if we don't match exactly v2" bugzilla-daemon
` (8 preceding siblings ...)
2014-04-20 8:09 ` bugzilla-daemon
@ 2014-04-20 10:34 ` bugzilla-daemon
9 siblings, 0 replies; 11+ messages in thread
From: bugzilla-daemon @ 2014-04-20 10:34 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 528 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=77673
Christian König <deathsimple@vodafone.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #10 from Christian König <deathsimple@vodafone.de> ---
Marking as fixed.
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 2227 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 11+ messages in thread