[Bug 85579] New: [bisected] piglit test crashes in spec/glsl-1.50/execution/geometry/max-input-components

[Bug 85579] New: [bisected] piglit test crashes in spec/glsl-1.50/execution/geometry/max-input-components

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1294 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=85579

            Bug ID: 85579
           Summary: [bisected] piglit test crashes in
                    spec/glsl-1.50/execution/geometry/max-input-components
           Product: Mesa
           Version: git
          Hardware: x86-64 (AMD64)
                OS: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/radeonsi
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: commendsarnex@gmail.com

Created attachment 108602
  --> https://bugs.freedesktop.org/attachment.cgi?id=108602&action=edit
log when the test fails

Hi again guys. I've been getting some very weird piglit crashes, including one
lockup, which I haven't yet been able to bisect.

Anyway, here's one I've been able to bisect.

The test spec/glsl-1.50/execution/geometry/max-input-components fails before
commit 54de7099115502c561f5f51095e08dc0a52c71b7, and always crashes on commits
after.

I have attached the piglit result logs from both versions. I'm not sure if the
LLVM Register Spilling spam is relating to my other problems, or not. 

Let me know if you need any more information.

Thanks,
sarnex

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2681 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 85579] [bisected] piglit test crashes in spec/glsl-1.50/execution/geometry/max-input-components

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 309 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=85579

--- Comment #1 from sarnex <commendsarnex@gmail.com> ---
Created attachment 108603
  --> https://bugs.freedesktop.org/attachment.cgi?id=108603&action=edit
log when the test crashes

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1293 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 85579] [bisected] piglit test crashes in spec/glsl-1.50/execution/geometry/max-input-components

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 404 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=85579

--- Comment #2 from Michel Dänzer <michel@daenzer.net> ---
Created attachment 108612
  --> https://bugs.freedesktop.org/attachment.cgi?id=108612&action=edit
radeonsi: If compiling the vertex or geometry shader fails, skip the draw

Does this patch fix the crash?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1506 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 85579] [bisected] piglit test crashes in spec/glsl-1.50/execution/geometry/max-input-components

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 798 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=85579

--- Comment #3 from sarnex <commendsarnex@gmail.com> ---
Created attachment 108624
  --> https://bugs.freedesktop.org/attachment.cgi?id=108624&action=edit
patch crash

(In reply to Michel Dänzer from comment #2)
> Created attachment 108612 [details]
> radeonsi: If compiling the vertex or geometry shader fails, skip the draw
> 
> Does this patch fix the crash?

Hi Michel,

Unfortunately, it appears the patch has no effect. But, after updating my mesa
to today's version, the test crashes very quickly, when it used to take over 3
minutes to fail or crash. Maybe this is related to the other llvm change?

I attached a log.

Thanks,
sarnex

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2153 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 85579] [bisected] piglit test crashes in spec/glsl-1.50/execution/geometry/max-input-components

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 487 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=85579

--- Comment #4 from Michel Dänzer <michel@daenzer.net> ---
Can you run the test in gdb and attach a backtrace? From the logs you attached,
the command line for running the test on your system is:

/usr/local/lib/piglit/bin/shader_runner
/usr/local/bin/../lib/piglit/tests/spec/glsl-1.50/execution/geometry/max-input-components.shader_test
-auto

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1351 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 85579] [bisected] piglit test crashes in spec/glsl-1.50/execution/geometry/max-input-components

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 808 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=85579

--- Comment #5 from sarnex <commendsarnex@gmail.com> ---
Created attachment 108646
  --> https://bugs.freedesktop.org/attachment.cgi?id=108646&action=edit
backtrace

(In reply to Michel Dänzer from comment #4)
> Can you run the test in gdb and attach a backtrace? From the logs you
> attached, the command line for running the test on your system is:
> 
> /usr/local/lib/piglit/bin/shader_runner
> /usr/local/bin/../lib/piglit/tests/spec/glsl-1.50/execution/geometry/max-
> input-components.shader_test -auto

Hi Michel,

I compiled LLVM3.5 debug and Mesa debug, so hopefully there is enough
information here. The backtrace is attached.

Thanks,
sarnex

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1864 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 85579] [bisected] piglit test crashes in spec/glsl-1.50/execution/geometry/max-input-components

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 510 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=85579

--- Comment #6 from Michel Dänzer <michel@daenzer.net> ---
(In reply to sarnex from comment #5)
> I compiled LLVM3.5 debug and Mesa debug, so hopefully there is enough
> information here. The backtrace is attached.

That's a crash in LLVM. Does that also happen with Mesa commit
54de7099115502c561f5f51095e08dc0a52c71b7? If not, can you test my patch on top
of that?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1447 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 85579] [bisected] piglit test crashes in spec/glsl-1.50/execution/geometry/max-input-components

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 891 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=85579

--- Comment #7 from sarnex <commendsarnex@gmail.com> ---
Created attachment 108669
  --> https://bugs.freedesktop.org/attachment.cgi?id=108669&action=edit
second bt

(In reply to Michel Dänzer from comment #6)
> (In reply to sarnex from comment #5)
> > I compiled LLVM3.5 debug and Mesa debug, so hopefully there is enough
> > information here. The backtrace is attached.
> 
> That's a crash in LLVM. Does that also happen with Mesa commit
> 54de7099115502c561f5f51095e08dc0a52c71b7? If not, can you test my patch on
> top of that?

Nope, it's a different crash. I incorrectly assumed it would be the same crash
since on latest git vs the first commit where it crashes.

Backtrace attached.

Thanks and sorry for the confusion.
Sarnex

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1995 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 85579] [bisected] piglit test crashes in spec/glsl-1.50/execution/geometry/max-input-components

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 811 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=85579

--- Comment #8 from sarnex <commendsarnex@gmail.com> ---
(In reply to Michel Dänzer from comment #6)
> (In reply to sarnex from comment #5)
> > I compiled LLVM3.5 debug and Mesa debug, so hopefully there is enough
> > information here. The backtrace is attached.
> 
> That's a crash in LLVM. Does that also happen with Mesa commit
> 54de7099115502c561f5f51095e08dc0a52c71b7? If not, can you test my patch on
> top of that?

Whoops, I forgot about your patch. It doesn't apply against commit
54de7099115502c561f5f51095e08dc0a52c71b7. If you get a chance could you update
it, because I'd likely break everything trying to manually apply.


Thanks again,
sarnex

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1805 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 85579] [bisected] piglit test crashes in spec/glsl-1.50/execution/geometry/max-input-components

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1225 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=85579

--- Comment #9 from Marek Olšák <maraeo@gmail.com> ---
I think there are 2 ways to fix this and we should do both:

1) Fix VGPR register spilling caused by indirect addressing into lots of
registers. LLVM crashes when it attempts to do that. Those registers are just
copies of shader inputs and outputs.

2)
Step A) Implement indirect addressing for VS outputs before GS and GS inputs.
This means that we cannot store outputs at the end of shaders (using
emit_epilogue), but we must store them when they occur as a destination
register (using emit_store).

(BTW my tessellation branch contains modifications to emit_store that make it
easier to re-implement it for shaders that use store instructions for outputs)

Step B) glsl_to_tgsi and/or some passes of the GLSL compiler may need to be
modified not to move ins/outs into temporaries. I think the only pass that does
that is the varying packing. The pass should be disabled or rewritten, because
its current implementation isn't gonna fly with our hardware and is often the
cause of unnecessary register spilling.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2086 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 85579] [bisected] piglit test crashes in spec/glsl-1.50/execution/geometry/max-input-components

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 643 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=85579

Samuel Pitoiset <samuel.pitoiset@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #10 from Samuel Pitoiset <samuel.pitoiset@gmail.com> ---
Quite old bug. Can no longer be reproduced with mesa-git (51dc5e3df38),
llvm-git (6f7f2057b76) and piglit-git (9cc5b2169). Closing.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2275 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel