[Bug 86043] Optimus issue with libdrm 2.4.58

[Bug 86043] Optimus issue with libdrm 2.4.58

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 950 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=86043

            Bug ID: 86043
           Summary: Optimus issue with libdrm 2.4.58
           Product: DRI
           Version: XOrg git
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: libdrm
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: jljusten@gmail.com

Users with optimus systems are reporting that
many games fail to run in libdrm-intel is upgraded
from 2.4.56 to 2.4.58. (And, downgrading to 2.4.56
fixes the issue.

Steam bug:
https://github.com/ValveSoftware/steam-for-linux/issues/3506

Debian bug:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=768045

I don't have hardware to confirm this issue.

I notice that between 2.4.56 and 2.4.58 libdrm changed
some symbol visibility settings.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2308 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 86043] Optimus issue with libdrm 2.4.58

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 397 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=86043

--- Comment #1 from Tobias Klausmann <tobias.klausmann@mni.thm.de> ---
Works fine on my Optimus machine with libdrm 2.4.58. Dota2 runs fine on both
GPUs!
I am not using bumblebee or primus, so i guess the problem lies there!

Anyway, keeping this bug open for a while.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1140 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 86043] Optimus issue with libdrm 2.4.58

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 501 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=86043

--- Comment #2 from Gavin Graham <me@gavingraham.me> ---
(In reply to Tobias Klausmann from comment #1)
> Works fine on my Optimus machine with libdrm 2.4.58. Dota2 runs fine on both
> GPUs!
> I am not using bumblebee or primus, so i guess the problem lies there!
> 
> Anyway, keeping this bug open for a while.

Out of curiosity, what version nVidia driver are you using?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1312 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 86043] Optimus issue with libdrm 2.4.58

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 416 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=86043

--- Comment #3 from Tobias Klausmann <tobias.klausmann@mni.thm.de> ---
I dont use the NVIDIA blob, but the nouveau driver...anyhow the intel driver is
working on prime (Optimus) systems if it does not get bugged by
bumblebee/primus with libdrm 2.4.58. Go report a bug against these apps.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1159 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 86043] Optimus issue with libdrm 2.4.58

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 846 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=86043

--- Comment #4 from Niek Bergman <niekbergman@gmail.com> ---
Can confirm this issue locally on my current system.

Running Steam through the "primusrun" Bumblebee wrapper to start games on the
nVidia card leads to the following error after starting a game:

malloc: unknown:0: assertion botched
free: called with unallocated block argument
last command: (null)
Aborting...Aborted (core dumped)

I can also confirm that downgrading libdrm-intel1 to 2.4.56 fixes the issue and
allows the game to run on the nVidia card just fine. Furthermore, starting
Steam without "primusrun" (thereby causing the game to start on the Intel card)
also does not cause this issue.

Should any testing be desired, I'd be happy to oblige.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1599 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 86043] Optimus issue with libdrm 2.4.58

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 270 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=86043

--- Comment #5 from Vedran Rodic <vrodic@gmail.com> ---
I confirm this is still present in
2.4.59+git20150225.1f73578d-0ubuntu0ricotz~utopic.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 998 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 86043] Optimus issue with libdrm 2.4.58

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 268 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=86043

--- Comment #6 from Emil Velikov <emil.l.velikov@gmail.com> ---
Guys can you bisect this ? Afaics it will take ~6 steps to track the issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1004 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 86043] Optimus issue with libdrm 2.4.58

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1170 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=86043

--- Comment #7 from Vedran Rodic <vrodic@gmail.com> ---
This is what I came up with when bisecting

ae8edc7544e566084f7b958eb93c9109b471ca30 is the first bad commit
commit ae8edc7544e566084f7b958eb93c9109b471ca30
Author: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Date:   Thu Jun 19 15:52:03 2014 +0100

    intel: Add support for userptr objects

    Allow userptr objects to be created and used via libdrm_intel.

    At the moment tiling and mapping to GTT aperture is not supported
    due hardware limitations across different generations and uncertainty
    about its usefulness.

    v2: Improved error handling in feature detection per review comments.

    v3: Rebase on top of the drm_public addition, minor whitespace addition.

    Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
    Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> (v3)
    Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> (v1,v2)

:040000 040000 5b1f4eecbdd1cf2c57d7da9388384c17e8448bee
b41b6afa071dc408dcaf7a4c6dcfecc2d7413c73 M    intel

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2138 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 86043] Optimus issue with libdrm 2.4.58

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1606 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=86043

Emil Velikov <emil.l.velikov@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tvrtko.ursulin@linux.intel.
                   |                            |com

--- Comment #8 from Emil Velikov <emil.l.velikov@gmail.com> ---
Adding the author to the CC list.

Vedran thanks for bisecting this :-)
I'm not sure how this patch can cause such an issue. Either something funny has
happened during bisect or there is another underlying problem.


Summary of the problem so far:

Optimus system running Intel mesa and the proprietary Nvidia drivers. Running
Steam (games) with either bumblebee, optirun or primusrun seems to cause a
crash.

Steam Log:
Game update: AppID 550 "Left 4 Dead 2", ProcID 9399, IP 0.0.0.0:0
...
malloc: unknown:0: assertion botched
free: called with unallocated block argument
last command: (null)
Aborting...Game removed: AppID 550 "Left 4 Dead 2", ProcID 9399

Bisecting libdrm shows ae8edc7544e as the offending commit.


If an Intel dev has a similar machine they can try to reproduce it locally.
Otherwise a back-trace should help at least a bit.

I while back I was able to use gdb with steam. Not sure if it still works
* Close all steam games and the steam client
* $ export GAME_DEBUGGER=gdb
* $ steam

Note I'm not looking into the issue, just trying to get some information for
the Intel devs.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 86043] Optimus issue with libdrm 2.4.58

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 755 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=86043

--- Comment #9 from Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> ---
Thanks Emil! Unfortunaltey I am not familiar with Optimus nor do I have
appropriate hardware.

Could someone provide a backtrace (with symbols) of the binary which ends up
saying "malloc: unknown:0: assertion botched", etc? Or maybe even Valgrind it?
Although that may be pretty advanced.

I don't think this commit is the actual culprit, but it is possible that the
failing binary uses UserPtr if it detects it, and has a bug in those optional
code paths.

Another interesting test would be to try non-working libdrm on a kernel without
UserPtr support.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1509 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 86043] Optimus issue with libdrm 2.4.58

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 986 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=86043

--- Comment #10 from Vedran Rodic <vrodic@gmail.com> ---
I don't have pre 3.16 kernel easily available. 

export GAME_DEBUGGER=gdb still makes the game crash before it runs it with the
debugger.

I've tried various things to make it work (modifying the game startup shell
script) but without success. 

When I put the older version of libdrm
(86b37c61c78edd1353a3f76f678c39e2ec168771, before Tvrtkos change), gdb runs
normally for the game. So the steam binary actually crashes, not the game
itself. 

It's funny because steam binary is 32bit, Dota 2 binary is 64 bit, and only
changing the 64bit version of libdrm_intel.so affects this bug. 

I've tried debugging steam with export DEBUGGER=gdb, but it seems spawn
multiple threads and I'm not experienced with multithreaded debugging. 

I did manage to run steam with valgrind, I'll add an attachment now.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1715 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 86043] Optimus issue with libdrm 2.4.58

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 400 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=86043

--- Comment #11 from Vedran Rodic <vrodic@gmail.com> ---
Created attachment 113924
  --> https://bugs.freedesktop.org/attachment.cgi?id=113924&action=edit
valgrind steam run, error should near the end of the file

valgrind steam run, error should near the end of the file

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1336 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 86043] Optimus issue with libdrm 2.4.58

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 845 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=86043

--- Comment #12 from Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> ---
I think we'll need to pull in someone from Steam since Valgrind reports some
mismatched frees in vgui2_s.so, steamclient.so and steamui.so. 

There are not debug symbols so impossible to guess what area of the code is
that.

Then this also looks pretty bad:

ERROR: ld.so: object
'/home/vedran/.local/share/Steam/ubuntu12_32/gameoverlayrenderer.so' from
LD_PRELOAD cannot be preloaded (wrong ELF class: ELFCLASS32): ignored.
ERROR: ld.so: object
'/home/vedran/.local/share/Steam/ubuntu12_32/gameoverlayrenderer.so' from
LD_PRELOAD cannot be preloaded (wrong ELF class: ELFCLASS32): ignored

Please if someone knows any Steam devs CC them here?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1590 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 86043] Optimus issue with libdrm 2.4.58

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1666 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=86043

--- Comment #13 from Emil Velikov <emil.l.velikov@gmail.com> ---
(In reply to Tvrtko Ursulin from comment #12)
> I think we'll need to pull in someone from Steam since Valgrind reports some
> mismatched frees in vgui2_s.so, steamclient.so and steamui.so. 
> 
> There are not debug symbols so impossible to guess what area of the code is
> that.
> 
I'm assuming Jordan can coordinate that with Valve. Afaics he is the one
assigned for the issue over at github.

> Then this also looks pretty bad:
> 
> ERROR: ld.so: object
> '/home/vedran/.local/share/Steam/ubuntu12_32/gameoverlayrenderer.so' from
> LD_PRELOAD cannot be preloaded (wrong ELF class: ELFCLASS32): ignored.
> ERROR: ld.so: object
> '/home/vedran/.local/share/Steam/ubuntu12_32/gameoverlayrenderer.so' from
> LD_PRELOAD cannot be preloaded (wrong ELF class: ELFCLASS32): ignored
> 
Those should be harmless, as steam LD_PRELOADs a bunch of libraries. Afaik
steam is 32bit, while Vedran was running a 64bit system - thus the messages. 

There are a couple of other interesting bits in the log:
 - Alarming heap stats (allocated ~770 MiB, in-use at exit ~220MiB)
 - Invalid memory access in various modules - invalid reads in various steam
runtime components, alarming number of invalid writes in i965_dri.so.

The latter one perhaps should be looked into closer ?

> Please if someone knows any Steam devs CC them here?
Afaict unless a person is known* by bugzilla one cannot CC them. For example
one cannot CC your @intel email, so I've opted for the known @linux.intel one.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2583 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 86043] Optimus issue with libdrm 2.4.58

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 612 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=86043

--- Comment #14 from Chris Wilson <chris@chris-wilson.co.uk> ---
(In reply to Emil Velikov from comment #13)
>  - Invalid memory access in various modules - invalid reads in various steam
> runtime components, alarming number of invalid writes in i965_dri.so.
> 
> The latter one perhaps should be looked into closer ?

Probably not, that is just valgrind not understanding GEM and its ioctls. You
need to use a libdrm compiled with --enable-valgrind to suppress the false
positives.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1429 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 86043] Optimus issue with libdrm 2.4.58

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 839 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=86043

GitLab Migration User <gitlab-migration@fdo.invalid> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |MOVED
             Status|NEW                         |RESOLVED

--- Comment #15 from GitLab Migration User <gitlab-migration@fdo.invalid> ---
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been
closed from further activity.

You can subscribe and participate further through the new bug through this link
to our GitLab instance: https://gitlab.freedesktop.org/mesa/drm/issues/14.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2385 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel