* [Bug 86618] New: [NV96] neg modifiers not working in MIN and MAX operations
@ 2014-11-23 11:17 bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ
[not found] ` <bug-86618-8800-V0hAGp6uBxMKqLRl/0Ahz6D7qz1kEfGD2LY78lusg7I@public.gmane.org/>
0 siblings, 1 reply; 4+ messages in thread
From: bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ @ 2014-11-23 11:17 UTC (permalink / raw)
To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
[-- Attachment #1.1: Type: text/plain, Size: 2033 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=86618
Bug ID: 86618
Summary: [NV96] neg modifiers not working in MIN and MAX
operations
Product: Mesa
Version: git
Hardware: Other
OS: All
Status: NEW
Severity: normal
Priority: medium
Component: Drivers/DRI/nouveau
Assignee: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Reporter: gzregozrw-5tc4TXWwyLM@public.gmane.org
Neg modifier for source in MIN and MAX ops is ignored.
Tested on git 89b9ef9.
I tested it only on NV96.
shader with:
float x = -sin(uv.x);
float d = max(0.0, x);
generates:
EMIT: presin f32 $r0 $r0 (8)
EMIT: sin f32 $r0 $r0 (8)
EMIT: mov u32 $r1 0x00000000 (8)
EMIT: max f32 $r2 neg $r0 $r1 (8)
Shader output is identical to version without unary minus.
Only difference is lack of neg modifier.
After disabling modifiers shader works as expected:
--- a/src/gallium/drivers/nouveau/codegen/nv50_ir_target_nv50.cpp
+++ b/src/gallium/drivers/nouveau/codegen/nv50_ir_target_nv50.cpp
@@ -85,8 +85,8 @@ static const struct opProperties _initProps[] =
{ OP_ADD, 0x3, 0x0, 0x0, 0x8, 0x2, 0x1, 0x1, 0x2 },
{ OP_SUB, 0x3, 0x0, 0x0, 0x0, 0x2, 0x1, 0x1, 0x2 },
{ OP_MUL, 0x3, 0x0, 0x0, 0x0, 0x2, 0x1, 0x1, 0x2 },
- { OP_MAX, 0x3, 0x3, 0x0, 0x0, 0x2, 0x1, 0x1, 0x0 },
- { OP_MIN, 0x3, 0x3, 0x0, 0x0, 0x2, 0x1, 0x1, 0x0 },
+ { OP_MAX, 0x0, 0x3, 0x0, 0x0, 0x2, 0x1, 0x1, 0x0 },
+ { OP_MIN, 0x0, 0x3, 0x0, 0x0, 0x2, 0x1, 0x1, 0x0 },
{ OP_MAD, 0x7, 0x0, 0x0, 0x0, 0x6, 0x1, 0x1, 0x0 }, // special
constraint
{ OP_ABS, 0x0, 0x0, 0x0, 0x0, 0x0, 0x1, 0x1, 0x0 },
{ OP_NEG, 0x0, 0x1, 0x0, 0x0, 0x0, 0x1, 0x1, 0x0 },
After this change:
EMIT: presin f32 $r0 $r0 (8)
EMIT: sin f32 $r0 $r0 (8)
EMIT: mov u32 $r1 0x00000000 (8)
EMIT: neg f32 $r0 $r0 (8)
EMIT: max f32 $r2 $r0 $r1 (8)
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 3216 bytes --]
[-- Attachment #2: Type: text/plain, Size: 153 bytes --]
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply [flat|nested] 4+ messages in thread[parent not found: <bug-86618-8800-V0hAGp6uBxMKqLRl/0Ahz6D7qz1kEfGD2LY78lusg7I@public.gmane.org/>]
* [Bug 86618] [NV96] neg modifiers not working in MIN and MAX operations [not found] ` <bug-86618-8800-V0hAGp6uBxMKqLRl/0Ahz6D7qz1kEfGD2LY78lusg7I@public.gmane.org/> @ 2014-11-23 17:20 ` bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ 2014-11-23 18:23 ` bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ 2014-11-23 20:48 ` bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ 2 siblings, 0 replies; 4+ messages in thread From: bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ @ 2014-11-23 17:20 UTC (permalink / raw) To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW [-- Attachment #1.1: Type: text/plain, Size: 430 bytes --] https://bugs.freedesktop.org/show_bug.cgi?id=86618 --- Comment #1 from Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org> --- Great find! However the min/max ops can actually take the neg modifiers (on either arg), but the emit logic didn't have that hooked up somehow. Does http://patchwork.freedesktop.org/patch/37356/ resolve your issue? -- You are receiving this mail because: You are the assignee for the bug. [-- Attachment #1.2: Type: text/html, Size: 1246 bytes --] [-- Attachment #2: Type: text/plain, Size: 153 bytes --] _______________________________________________ Nouveau mailing list Nouveau@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/nouveau ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug 86618] [NV96] neg modifiers not working in MIN and MAX operations [not found] ` <bug-86618-8800-V0hAGp6uBxMKqLRl/0Ahz6D7qz1kEfGD2LY78lusg7I@public.gmane.org/> 2014-11-23 17:20 ` [Bug 86618] " bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ @ 2014-11-23 18:23 ` bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ 2014-11-23 20:48 ` bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ 2 siblings, 0 replies; 4+ messages in thread From: bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ @ 2014-11-23 18:23 UTC (permalink / raw) To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW [-- Attachment #1.1: Type: text/plain, Size: 294 bytes --] https://bugs.freedesktop.org/show_bug.cgi?id=86618 --- Comment #2 from Grzegorz Wójcik <gzregozrw-5tc4TXWwyLM@public.gmane.org> --- (In reply to Ilia Mirkin from comment #1) Yes, this patch solved my issue. -- You are receiving this mail because: You are the assignee for the bug. [-- Attachment #1.2: Type: text/html, Size: 1113 bytes --] [-- Attachment #2: Type: text/plain, Size: 153 bytes --] _______________________________________________ Nouveau mailing list Nouveau@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/nouveau ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug 86618] [NV96] neg modifiers not working in MIN and MAX operations [not found] ` <bug-86618-8800-V0hAGp6uBxMKqLRl/0Ahz6D7qz1kEfGD2LY78lusg7I@public.gmane.org/> 2014-11-23 17:20 ` [Bug 86618] " bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ 2014-11-23 18:23 ` bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ @ 2014-11-23 20:48 ` bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ 2 siblings, 0 replies; 4+ messages in thread From: bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ @ 2014-11-23 20:48 UTC (permalink / raw) To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW [-- Attachment #1.1: Type: text/plain, Size: 609 bytes --] https://bugs.freedesktop.org/show_bug.cgi?id=86618 Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org> --- Pushed as 7d07083c upstream, should be backported to 10.3 and 10.4 releases. -- You are receiving this mail because: You are the assignee for the bug. [-- Attachment #1.2: Type: text/html, Size: 2045 bytes --] [-- Attachment #2: Type: text/plain, Size: 153 bytes --] _______________________________________________ Nouveau mailing list Nouveau@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/nouveau ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-11-23 20:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-23 11:17 [Bug 86618] New: [NV96] neg modifiers not working in MIN and MAX operations bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ
[not found] ` <bug-86618-8800-V0hAGp6uBxMKqLRl/0Ahz6D7qz1kEfGD2LY78lusg7I@public.gmane.org/>
2014-11-23 17:20 ` [Bug 86618] " bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ
2014-11-23 18:23 ` bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ
2014-11-23 20:48 ` bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.