[Bug 86663] [radeonsi] Black squares in Sanctum 2

[Bug 86663] [radeonsi] Black squares in Sanctum 2

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 709 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=86663

            Bug ID: 86663
           Summary: [radeonsi] Black squares in Sanctum 2
           Product: Mesa
           Version: git
          Hardware: x86-64 (AMD64)
                OS: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/radeonsi
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: daniel@constexpr.org

Created attachment 109943
  --> https://bugs.freedesktop.org/attachment.cgi?id=109943&action=edit
Sanctum 2 (map Trainstation) with highest texture quality setting

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2149 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 86663] [radeonsi] Black squares in Sanctum 2

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1508 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=86663

--- Comment #1 from Daniel Scharrer <daniel@constexpr.org> ---
(I fail at bugzilla today :/)

On some maps in Sanctum 2 I'm getting black squares in some spots.

The squares always seem to be the same screen-space size (120×120 pixels, some
are wider/taller but that could just be overlapping squares), but are centered
around fixed positions in the game world and not aligned to a screen-space
grid.

Moving the camera or character can cause some of them to disappear/reappear.

The squares don't just cover the world geometry, but also the user interface
including the hud and menu, and even loading screens.

This happens with and without R600_DEBUG=nohyperz. It does not happen with
fglrx 14.9.

It doesn't happen on all maps, but for those affected (e.g. Trainstation) it is
100% reproducible.

Lowering texture quality in the game's options reduces the number of black
squares. For the screenshots I had all other settings at their lowest value
(except bloom turned on as that is required for the game to render correctly,
even on other drivers).

I have tried to create an apitrace showing the problem but glretrace crashes
inside glDrawRangeElements() shortly before getting to the buggy part when
replaying with either radeonsi or fglrx. I can still provide it if anyone is
interested, but it's probably not appropriate to link here.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2273 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 86663] [radeonsi] Black squares in Sanctum 2

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 410 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=86663

Daniel Scharrer <daniel@constexpr.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #109943|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1066 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 86663] [radeonsi] Black squares in Sanctum 2

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 355 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=86663

--- Comment #2 from Daniel Scharrer <daniel@constexpr.org> ---
Created attachment 109944
  --> https://bugs.freedesktop.org/attachment.cgi?id=109944&action=edit
Sanctum 2 (map Trainstation) with highest texture quality setting

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1323 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 86663] [radeonsi] Black squares in Sanctum 2

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 354 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=86663

--- Comment #3 from Daniel Scharrer <daniel@constexpr.org> ---
Created attachment 109945
  --> https://bugs.freedesktop.org/attachment.cgi?id=109945&action=edit
Sanctum 2 (map Trainstation) with lowest texture quality setting

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1320 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 86663] [radeonsi] Black squares in Sanctum 2

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 996 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=86663

--- Comment #4 from Daniel Scharrer <daniel@constexpr.org> ---
Created attachment 109946
  --> https://bugs.freedesktop.org/attachment.cgi?id=109946&action=edit
Deadfall Adventures menu screen

I have also noticed similar black squares in the menu screen of Deadfall
Adventures. In that case, changing the texture quality to the lowest setting
gets rid of them. Changing all other video settings from highest to lowest
reduces the size of the squares from ~104² pixels to 50² pixels.

I guess the root cause might just be single NaN/negative fragments that then
get propagated by a subsequent screen-space filter into a whole square?

Neither game has any VGPR register spilling warnings in their console output so
it's not that.

Oh, and this is all with Mesa 10.5.0-devel (git-fecae46), but I remember also
seeing this with older versions.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1915 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 86663] [radeonsi] Black squares in Sanctum 2

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 215 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=86663

--- Comment #5 from Daniel Scharrer <daniel@constexpr.org> ---
GPU is a Radeon HD 7950

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 960 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 86663] [radeonsi] Black squares in Sanctum 2

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 485 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=86663

--- Comment #6 from Marek Olšák <maraeo@gmail.com> ---
(In reply to Daniel Scharrer from comment #4)
> I guess the root cause might just be single NaN/negative fragments that then
> get propagated by a subsequent screen-space filter into a whole square?

I think you nailed it. Yes, NaNs must be causing this. The question is how they
occur.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1317 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 86663] [radeonsi] Black squares in Sanctum 2

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 220 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=86663

--- Comment #7 from Christoph Haag <haagch@frickel.club> ---
Is bug 83510 the same problem?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1103 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 86663] [radeonsi] Black squares in Sanctum 2

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 580 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=86663

--- Comment #8 from Daniel Scharrer <daniel@constexpr.org> ---
(In reply to Marek Olšák from comment #6)
> The question is how they occur.

Right, any idea how to track that down? I'll try to figure out why glretrace
crashes.

(In reply to Christoph Haag from comment #7)
> Is bug 83510 the same problem?

Looks different enough to me. For example in your videos on that bug the HUD is
alpha-blended just fine over the black spots.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1628 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 86663] [radeonsi] Black squares in Sanctum 2

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 474 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=86663

--- Comment #9 from Daniel Scharrer <daniel@constexpr.org> ---
FYI, the black squares in Sanctum 2 are also fixed by the legacy RCP workaround
[1], so this may be the same root cause as in bug 83510 after all.

No change in the Deadfall Adventures menu screen though.

[1] http://lists.freedesktop.org/archives/mesa-dev/2014-December/071973.html

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1446 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 86663] [radeonsi] Black squares in Sanctum 2

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 614 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=86663

--- Comment #10 from Daniel Scharrer <daniel@constexpr.org> ---
Created attachment 110770
  --> https://bugs.freedesktop.org/attachment.cgi?id=110770&action=edit
Deadfall Adventures menu screen with DX10_CLAMP patch

Setting the DX10_CLAMP bit [1] also fixes the black squares in Sanctum 2. In
Deadfall Adventures however there are still much smaller black squares as can
be seen in the attached screenshot.

[1] http://lists.freedesktop.org/archives/mesa-dev/2014-December/072402.html

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1646 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 86663] [radeonsi] Black squares in Sanctum 2

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 622 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=86663

Daniel Scharrer <daniel@constexpr.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #11 from Daniel Scharrer <daniel@constexpr.org> ---
The Sanctum issue has been fixed with commit
http://cgit.freedesktop.org/mesa/mesa/commit/?id=2150db4d5daad3781876254d2b440367afd756cd

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2162 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel