[Bug 90266] Unigine Heaven 4.0 logging vm faults since radeon/llvm: Run LLVM's instruction combining pass

[Bug 90266] Unigine Heaven 4.0 logging vm faults since radeon/llvm: Run LLVM's instruction combining pass

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 2005 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=90266

            Bug ID: 90266
           Summary: Unigine Heaven 4.0 logging vm faults since
                    radeon/llvm: Run LLVM's instruction combining pass
           Product: Mesa
           Version: git
          Hardware: x86-64 (AMD64)
                OS: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/radeonsi
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: adf.lists@gmail.com
        QA Contact: dri-devel@lists.freedesktop.org

Related to 

https://bugs.freedesktop.org/show_bug.cgi?id=90056

Unlike valley I thought heaven 4.0 wasn't affected by above as it runs and
looks OK.

There is however an issue, again "fixed" by reverting mesa commit 

commit c6d79ed289a75f13c65f011be870f7e43a0fedc7
Author: Tom Stellard <thomas.stellard@amd.com>
Date:   Fri Apr 10 17:07:16 2015 +0000

    radeon/llvm: Run LLVM's instruction combining pass


This issue is thousands of lines of logging like below.

This happens with or without the llvm fix in the valley bug.

Will attach R600_DEBUG=ps,vs,gs with and without above mesa commit reverted.
The debug logs were done with todays llvm,mesa so the valley fix in in llvm.

The errors -

[ 7288.184664] VM fault (0x01, vmid 14) at page 185032279, read from TC (4)
[ 7288.184667] radeon 0000:01:00.0: GPU fault detected: 147 0x0afc0401
[ 7288.184668] radeon 0000:01:00.0:   VM_CONTEXT1_PROTECTION_FAULT_ADDR  
0x0B075E57
[ 7288.184670] radeon 0000:01:00.0:   VM_CONTEXT1_PROTECTION_FAULT_STATUS
0x1C004001
[ 7288.184671] VM fault (0x01, vmid 14) at page 185032279, read from TC (4)
[ 7288.184695] radeon 0000:01:00.0: GPU fault detected: 147 0x0afc0401
[ 7288.184696] radeon 0000:01:00.0:   VM_CONTEXT1_PROTECTION_FAULT_ADDR  
0x0B075E57
[ 7288.184698] radeon 0000:01:00.0:   VM_CONTEXT1_PROTECTION_FAULT_STATUS
0x1C004001

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3610 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 90266] Unigine Heaven 4.0 logging vm faults since radeon/llvm: Run LLVM's instruction combining pass

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 320 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=90266

--- Comment #1 from Andy Furniss <adf.lists@gmail.com> ---
Created attachment 115494
  --> https://bugs.freedesktop.org/attachment.cgi?id=115494&action=edit
Heaven 4.0 R600_DEBUG=ps,vs,gs Bad

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1334 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 90266] Unigine Heaven 4.0 logging vm faults since radeon/llvm: Run LLVM's instruction combining pass

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 338 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=90266

--- Comment #2 from Andy Furniss <adf.lists@gmail.com> ---
Created attachment 115495
  --> https://bugs.freedesktop.org/attachment.cgi?id=115495&action=edit
Heaven 4.0 R600_DEBUG=ps,vs,gs Good with mesa revert

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1388 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 90266] Unigine Heaven 4.0 logging vm faults since radeon/llvm: Run LLVM's instruction combining pass

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 884 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=90266

--- Comment #3 from Arek Ruśniak <arek.rusi@gmail.com> ---
i can confirm this on cape verde:

dmesg:
[  956.234491] VM fault (0x01, vmid 4) at page 185033268, read from TC (4)
[  956.234500] radeon 0000:01:00.0: GPU fault detected: 147 0x06880401
[  956.234500] radeon 0000:01:00.0:   VM_CONTEXT1_PROTECTION_FAULT_ADDR  
0x0B076234
[  956.234501] radeon 0000:01:00.0:   VM_CONTEXT1_PROTECTION_FAULT_STATUS
0x08004001
[  956.234502] VM fault (0x01, vmid 4) at page 185033268, read from TC (4)
[  956.234519] radeon 0000:01:00.0: GPU fault detected: 147 0x06880401
[  956.234519] radeon 0000:01:00.0:   VM_CONTEXT1_PROTECTION_FAULT_ADDR  
0x0B076234
[  956.234520] radeon 0000:01:00.0:   VM_CONTEXT1_PROTECTION_FAULT_STATUS
0x08004001

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1758 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 90266] Unigine Heaven 4.0 logging vm faults since radeon/llvm: Run LLVM's instruction combining pass

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 736 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=90266

--- Comment #4 from Tom Stellard <tstellar@gmail.com> ---
(In reply to Andy Furniss from comment #0)
> Related to 
> 
> https://bugs.freedesktop.org/show_bug.cgi?id=90056
> 
> Unlike valley I thought heaven 4.0 wasn't affected by above as it runs and
> looks OK.
> 
> There is however an issue, again "fixed" by reverting mesa commit 
> 

Thanks for the report, I just have a few qustions:

Are there any problems with Valley after the fix for Bug 90056 was committed?

Does the problem reported in this bug for Heaven still happen if you keep the
InsCombine pass enabled, but revert the fix from Bug 90056?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2325 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 90266] Unigine Heaven 4.0 logging vm faults since radeon/llvm: Run LLVM's instruction combining pass

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1126 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=90266

--- Comment #5 from Andy Furniss <adf.lists@gmail.com> ---
(In reply to Tom Stellard from comment #4)
> (In reply to Andy Furniss from comment #0)
> > Related to 
> > 
> > https://bugs.freedesktop.org/show_bug.cgi?id=90056
> > 
> > Unlike valley I thought heaven 4.0 wasn't affected by above as it runs and
> > looks OK.
> > 
> > There is however an issue, again "fixed" by reverting mesa commit 
> > 
> 
> Thanks for the report, I just have a few qustions:
> 
> Are there any problems with Valley after the fix for Bug 90056 was committed?

No, Valley is OK

> Does the problem reported in this bug for Heaven still happen if you keep
> the InsCombine pass enabled, but revert the fix from Bug 90056?

Yes with or without the fix Heaven logs the errors.

Initially tested on an older llvm with and without the patch from -

https://bugs.freedesktop.org/show_bug.cgi?id=90056#c14

and again just now by reverting "R600/SI: Fix verifier errors from the
SIAnnotateControlFlow" on a more recent llvm.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3056 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 90266] Unigine Heaven 4.0 logging vm faults since radeon/llvm: Run LLVM's instruction combining pass

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 345 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=90266

--- Comment #6 from Tom Stellard <tstellar@gmail.com> ---
Created attachment 115625
  --> https://bugs.freedesktop.org/attachment.cgi?id=115625&action=edit
Possible Fix

This patch should fix the issue, can you test?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1399 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 90266] Unigine Heaven 4.0 logging vm faults since radeon/llvm: Run LLVM's instruction combining pass

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 365 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=90266

--- Comment #7 from Andy Furniss <adf.lists@gmail.com> ---
(In reply to Tom Stellard from comment #6)
> Created attachment 115625 [details] [review]
> Possible Fix
> 
> This patch should fix the issue, can you test?

Yes, this fixes it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1561 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 90266] Unigine Heaven 4.0 logging vm faults since radeon/llvm: Run LLVM's instruction combining pass

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 228 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=90266

--- Comment #8 from Arek Ruśniak <arek.rusi@gmail.com> ---
thx Tom, heaven works as before

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1102 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 90266] Unigine Heaven 4.0 logging vm faults since radeon/llvm: Run LLVM's instruction combining pass

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 217 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=90266

--- Comment #9 from Tom Stellard <tstellar@gmail.com> ---
Fix committed to LLVM: r237164

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1069 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 90266] Unigine Heaven 4.0 logging vm faults since radeon/llvm: Run LLVM's instruction combining pass

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 417 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=90266

Tom Stellard <tstellar@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1263 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel