[Bug 90350] New: [G96] Portal's portal are incorrectly rendered

[Bug 90350] New: [G96] Portal's portal are incorrectly rendered

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 818 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=90350

            Bug ID: 90350
           Summary: [G96] Portal's portal are incorrectly rendered
           Product: Mesa
           Version: git
          Hardware: x86-64 (AMD64)
                OS: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/DRI/nouveau
          Assignee: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
          Reporter: pierre.morrow-GANU6spQydw@public.gmane.org
        QA Contact: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org

Portal's portals are filled with some matter when running the game on my G96.
Running on my MCP79 is fine.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2058 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 90350] [G96] Portal's portal are incorrectly rendered

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 543 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=90350

--- Comment #1 from Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org> ---
Trace available at:

http://people.freedesktop.org/~imirkin/traces/portal_bug_portalrendering_G96.trace.xz

Verified to render correctly on i965 haswell. Would be nice if someone else
with a G96 or older card can verify it also renders wrong. Otherwise it's an
issue on the macbook gpu setup.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1394 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 90350] [G96] Portal's portal are incorrectly rendered

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 614 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=90350

--- Comment #2 from Pierre Moreau <pierre.morrow-GANU6spQydw@public.gmane.org> ---
Bisected to

commit 44673512a84c0897c8eddabf4a56e79b7d5b3395
Author: Roy Spliet <rspliet-pPYjZ15w/Xhulxpn9UvDqw@public.gmane.org>
Date:   Mon Jan 5 00:22:17 2015 +0100

    nv50/ir: Add sat modifier for mul

    Signed-off-by: Roy Spliet <rspliet-pPYjZ15w/Xhulxpn9UvDqw@public.gmane.org>
    Reviewed-by: Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1453 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 90350] [G96] Portal's portal are incorrectly rendered

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 644 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=90350

--- Comment #3 from Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org> ---
Created attachment 115652
  --> https://bugs.freedesktop.org/attachment.cgi?id=115652&action=edit
saturate shader test

On each of your NV96 and NVAC, please run the attached test through
shader_runner. Also remove the "+ arg2" from the result computation and run it
again. I suspect that only NV96 + arg2 removed will fail.

[The results that *actually* test clamping are 16, 20, 28, and 36.]

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1538 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 90350] [G96] Portal's portal are incorrectly rendered

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 1579 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=90350

Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org> ---
Looks like I was right in my guess. Since NVAC tends to have the same things as
NVA0, I'm assuming that FMUL.SAT becomes a thing on G200+. Fix pushed:

commit da136dc07ddb6147d181c96f475b94f6281efd73
Author: Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org>
Date:   Sat May 9 03:26:07 2015 -0400

    nv50/ir: only enable mul saturate on G200+

    Commit 44673512a84 enabled support for saturating fmul. However
    experimentally this does not seem to work on the older chips. Restrict
    the feature to G200 (NVA0) and later.

    Reported-by: Pierre Moreau <pierre.morrow-GANU6spQydw@public.gmane.org>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90350
    Signed-off-by: Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org>
    Tested-by: Pierre Moreau <pierre.morrow-GANU6spQydw@public.gmane.org>
    Reviewed-by: Tobias Klausmann <tobias.johannes.klausmann-AqjdNwhu20eELgA04lAiVw@public.gmane.org>
    Cc: mesa-stable-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3381 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau