[Bug 91193] [290x] Dota2 reborn ingame rendering breaks with git-af4b9c7

[Bug 91193] [290x] Dota2 reborn ingame rendering breaks with git-af4b9c7

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1326 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=91193

            Bug ID: 91193
           Summary: [290x] Dota2 reborn ingame rendering breaks with
                    git-af4b9c7
           Product: Mesa
           Version: git
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/radeonsi
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: darkdefende@gmail.com
        QA Contact: dri-devel@lists.freedesktop.org

I've had some problems with Dota2 ingame rendering for a while now. The icons
on the minimap flickers and some parts of the ground too. The ground only
flickers if normal maps are turned on.

I have uploaded two videos on github to demonstrate the issue:
https://github.com/DarkDefender/dota2_reborn_issue

Here is the issue on the Dota2 reborn bugtracker:
https://github.com/ValveSoftware/Dota-2-Reborn/issues/150

It seems like this commit broke the ingame rendering:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=af4b9c7c2e119d373f9684119b833a8b62cbb756

With the previous commit:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=e4339bc9886a26d75b924ad045c3ddd003f802c3
it seems to render fine.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2963 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 91193] [290x] Dota2 reborn ingame rendering breaks with git-af4b9c7

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 260 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=91193

--- Comment #1 from Sylvain BERTRAND <sylvain.bertrand@gmail.com> ---
Reverting those commits fixed the flickering on my tahiti xt.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1058 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 91193] [290x] Dota2 reborn ingame rendering breaks with git-af4b9c7

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 401 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=91193

--- Comment #2 from Michel Dänzer <michel@daenzer.net> ---
Created attachment 116901
  --> https://bugs.freedesktop.org/attachment.cgi?id=116901&action=edit
radeonsi: Count TGSI_SEMANTIC_CLIPDIST again for the VS export count

Does this patch fix the problem?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1522 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 91193] [290x] Dota2 reborn ingame rendering breaks with git-af4b9c7

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 546 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=91193

--- Comment #3 from Christoph Haag <haagch@frickel.club> ---
(In reply to Michel Dänzer from comment #2)
> Created attachment 116901 [details] [review]
> radeonsi: Count TGSI_SEMANTIC_CLIPDIST again for the VS export count
> 
> Does this patch fix the problem?

As far as I can see, yes, removing only the TGSI_SEMANTIC_CLIPDIST case makes
the corrupted texture flicker and the shadow flicker go away.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1810 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 91193] [290x] Dota2 reborn ingame rendering breaks with git-af4b9c7

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 280 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=91193

--- Comment #4 from Sebastian Parborg <darkdefende@gmail.com> ---
Seems to solve it for me also.
I'm guessing that this is just a temporary workaround?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1074 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 91193] [290x] Dota2 reborn ingame rendering breaks with git-af4b9c7

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 518 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=91193

--- Comment #5 from Michel Dänzer <michel@daenzer.net> ---
(In reply to Sebastian Parborg from comment #4)
> I'm guessing that this is just a temporary workaround?

No, I think it's the proper fix. TGSI_SEMANTIC_CLIPDIST values are also passed
to the pixel shader as a varying, so they need to be counted here.

I'll submit the patch to the mesa-dev mailing list for review.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1396 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 91193] [290x] Dota2 reborn ingame rendering breaks with git-af4b9c7

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 810 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=91193

Michel Dänzer <michel@daenzer.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Michel Dänzer <michel@daenzer.net> ---
Commit: 248b26429f52d0f19949a083aa3e0aeebcbe2138
URL:   
http://cgit.freedesktop.org/mesa/mesa/commit/?id=248b26429f52d0f19949a083aa3e0aeebcbe2138

Author: Michel Dänzer <michel.daenzer@amd.com>
Date:   Mon Jul  6 17:23:07 2015 +0900

radeonsi: Use param export count from si_llvm_export_vs in si_shader_vs

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2511 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel