[Bug 93454] New: Can't build with LLVM/clang 3.7.0

[Bug 93454] New: Can't build with LLVM/clang 3.7.0

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 1388 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93454

            Bug ID: 93454
           Summary: Can't build with LLVM/clang 3.7.0
           Product: Mesa
           Version: 11.0
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/DRI/nouveau
          Assignee: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
          Reporter: tpgxyz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
        QA Contact: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org

System is OpenMandriva Cooker running LLVM/clang 3.7.0 as default compiler.

When i build mesa i got this error:

Makefile:1205: recipe for target 'nv50/nv84_video_vp.lo' failed
make[3]: Leaving directory
'/builddir/build/BUILD/mesa-11.0.7/src/gallium/drivers/nouveau'
In file included from nv50/nv84_video_vp.c:25:
In file included from ../../../../src/gallium/auxiliary/util/u_sse.h:140:
/usr/bin/../lib64/clang/3.7.0/include/tmmintrin.h:28:2: error: "SSSE3
instruction set not enabled"
#error "SSSE3 instruction set not enabled"
 ^
1 error generated.
make[3]: *** [nv50/nv84_video_vp.lo] Error 1
make[3]: *** Waiting for unfinished jobs....

Adding -mssse3 to CFLAGS will not work for all hardware.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2626 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 93454] Can't build with LLVM/clang 3.7.0 - SSSE3 instruction set not enabled

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 605 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93454

Tomasz Paweł Gajc <tpgxyz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Can't build with LLVM/clang |Can't build with LLVM/clang
                   |3.7.0                       |3.7.0 - SSSE3 instruction
                   |                            |set not enabled

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1243 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 93454] Can't build with LLVM/clang 3.7.0 - SSSE3 instruction set not enabled

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 568 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93454

Tomasz Paweł Gajc <tpgxyz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Hardware|Other                       |x86-64 (AMD64)
                 OS|All                         |Linux (All)
           Severity|normal                      |major

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1498 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 93454] Can't build with LLVM/clang 3.7.0 - SSSE3 instruction set not enabled

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 700 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93454

--- Comment #1 from Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org> ---
Hmmm... this comes from

#if defined(PIPE_ARCH_SSSE3)

#include <tmmintrin.h>

Which in turn comes from, hilariously,

#if defined(PIPE_CC_GCC) && (__GNUC__ * 100 + __GNUC_MINOR__) < 409 &&
!defined(__SSSE3__)
/* #warning SSE3 support requires -msse3 compiler options before GCC 4.9 */
#else
#define PIPE_ARCH_SSSE3
#endif

I'm guessing that was meant to be

#if defined(PIPE_CC_GCC) && (__GNUC__ * 100 + __GNUC_MINOR__) < 409 ||
!defined(__SSSE3__)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1533 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 93454] Can't build with LLVM/clang 3.7.0 - SSSE3 instruction set not enabled

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 700 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93454

--- Comment #2 from Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org> ---
Hmmm... this comes from

#if defined(PIPE_ARCH_SSSE3)

#include <tmmintrin.h>

Which in turn comes from, hilariously,

#if defined(PIPE_CC_GCC) && (__GNUC__ * 100 + __GNUC_MINOR__) < 409 &&
!defined(__SSSE3__)
/* #warning SSE3 support requires -msse3 compiler options before GCC 4.9 */
#else
#define PIPE_ARCH_SSSE3
#endif

I'm guessing that was meant to be

#if defined(PIPE_CC_GCC) && (__GNUC__ * 100 + __GNUC_MINOR__) < 409 ||
!defined(__SSSE3__)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1533 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 93454] Can't build with LLVM/clang 3.7.0 - SSSE3 instruction set not enabled

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 320 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93454

--- Comment #3 from Tomasz Paweł Gajc <tpgxyz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> ---
Let me try that in src/gallium/include/pipe/p_config.h

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1137 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 93454] Can't build with LLVM/clang 3.7.0 - SSSE3 instruction set not enabled

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 1097 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93454

Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jfonseca-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org

--- Comment #4 from Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org> ---
This logic was last altered in the change below... My copy of clang 3.5
purports to be gcc 4.2.1. What does clang 3.7 report?

clang -E -dM - < /dev/null | grep GNUC

commit eb643db30e1bdf5171d0a012674016c317925b6e
Author: Jose Fonseca <jfonseca-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
Date:   Sun Aug 9 11:21:03 2015 +0100

    gallium: GCC 4.9 allows to include tmmintrin.h without -msse3.

    Fixes build with MinGW x86_64 build with GCC 4.9, due to conflicting
    definition _mm_shuffle_epi8 of u_sse.h and system headers.

    Trivial.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2420 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 93454] Can't build with LLVM/clang 3.7.0 - SSSE3 instruction set not enabled

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 461 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93454

--- Comment #5 from Tomasz Paweł Gajc <tpgxyz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> ---
(In reply to Ilia Mirkin from comment #4)

> clang -E -dM - < /dev/null | grep GNUC

#define __GNUC_MINOR__ 9
#define __GNUC_PATCHLEVEL__ 1
#define __GNUC_STDC_INLINE__ 1
#define __GNUC__4

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1351 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 93454] Can't build with LLVM/clang 3.7.0 - SSSE3 instruction set not enabled

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 1317 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93454

--- Comment #6 from Jose Fonseca <jfonseca-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org> ---
The issue is simple:

- GCC used to require -msse3 in order to include tmmintrin.h 
- MSVC/ICC does not
- GCC 4.9 finally eliminated that awkward requirement -- it's now possible to
use SSE3 instrinsics without giving GCC carte blanch to emit SSSE3 whenever it
wants

- it appears Clang claims to be GCC 4.9 but does not in fact support this.


We can workaround by adding   

diff --git a/src/gallium/include/pipe/p_config.h
b/src/gallium/include/pipe/p_config.h
index 0b570c7..7d5d7d4 100644
--- a/src/gallium/include/pipe/p_config.h
+++ b/src/gallium/include/pipe/p_config.h
@@ -96,7 +96,7 @@
 #else
 #define PIPE_ARCH_SSE
 #endif
-#if defined(PIPE_CC_GCC) && (__GNUC__ * 100 + __GNUC_MINOR__) < 409 &&
!defined(__SSSE3__)
+#if defined(PIPE_CC_GCC) && ((__GNUC__ * 100 + __GNUC_MINOR__) < 409 ||
defined(__clang__)) && !defined(__SSSE3__)
 /* #warning SSE3 support requires -msse3 compiler options before GCC 4.9 */
 #else
 #define PIPE_ARCH_SSSE3


But this is above all a bug in Clang 3.7.  If that strive/claim to be GCC 4.9
then they should handle this too.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2166 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 93454] Can't build with LLVM/clang 3.7.0 - SSSE3 instruction set not enabled

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 837 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93454

Tomasz Paweł Gajc <tpgxyz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://llvm.org/bugs/show_
                   |                            |bug.cgi?id=24990

--- Comment #7 from Tomasz Paweł Gajc <tpgxyz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> ---
Hi, thanks for the workaround
I found this bug report https://llvm.org/bugs/show_bug.cgi?id=24990 and i was
paring commits for llvm and clang and i did not found anything that would
corresponds to above bug.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2199 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 93454] Can't build with LLVM/clang 3.7.0 - SSSE3 instruction set not enabled

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 1442 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93454

Jose Fonseca <jfonseca-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |NOTOURBUG

--- Comment #8 from Jose Fonseca <jfonseca-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org> ---
(In reply to Tomasz Paweł Gajc from comment #7)
> Hi, thanks for the workaround
> I found this bug report https://llvm.org/bugs/show_bug.cgi?id=24990 and i
> was paring commits for llvm and clang and i did not found anything that
> would corresponds to above bug.

It looks like they had fixed this already before the bug report.

From the git history, the fix is 

 
https://github.com/llvm-mirror/clang/commit/41885d36e85ead75a1d18ef7d2f43663f90ed67e

Not sure what clang version got it in the end.

But given this has already been fixed in Clang, I think we shouldn't fix it in
Mesa, otherwise we'll need complex logic to detect exactly which clang versions
support or not this.

OpenMandriva Cooker made the decision to use LLVM/clang 3.7.0 as default
compiler, so they should crossport any fixes necessary to keep light on.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3215 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau