[Bug 93460] [amdgpu] Ooops during shutdown - amdgpu_vm_grab_id

[Bug 93460] [amdgpu] Ooops during shutdown - amdgpu_vm_grab_id

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 786 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93460

            Bug ID: 93460
           Summary: [amdgpu] Ooops during shutdown - amdgpu_vm_grab_id
           Product: DRI
           Version: DRI git
          Hardware: x86-64 (AMD64)
                OS: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: DRM/AMDgpu
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: mike@fireburn.co.uk

This doesn't happen on the powerplay branch but it does happen on Linus's tree
4.4-rc5

As this appears related to the scheduler I can go back to kernel 4.3 and test
that and if it doesn't happen try and bisect if you think it's worthwhile

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2016 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 93460] [amdgpu] Ooops during shutdown - amdgpu_vm_grab_id

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 551 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93460

Mike Lothian <mike@fireburn.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mike@fireburn.co.uk

--- Comment #1 from Mike Lothian <mike@fireburn.co.uk> ---
Created attachment 120605
  --> https://bugs.freedesktop.org/attachment.cgi?id=120605&action=edit
Screenshot of oops

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1981 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 93460] [amdgpu] Ooops during shutdown - amdgpu_vm_grab_id

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 373 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93460

--- Comment #2 from Mike Lothian <mike@fireburn.co.uk> ---
I tried to bisect between v4.3 and HEAD but there were too many other issues
getting in the way - i915, ath10k - making remoting in too difficult when the
screen wasn't showing anything

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1140 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 93460] [amdgpu] Ooops during shutdown - amdgpu_vm_grab_id

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 639 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93460

--- Comment #3 from david1.zhou@amd.com <david1.zhou@amd.com> ---
0x24e7e is in amdgpu_vm_grab_id (include/linux/fence.h:292).
287     * Returns true if f1 is chronologically later than f2. Both fences must
be
288     * from the same context, since a seqno is not re-used across contexts.
289     */
290    static inline bool fence_is_later(struct fence *f1, struct fence *f2)
291    {
292        if (WARN_ON(f1->context != f2->context))
293            return false;

This should be normal warnings, isn't bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1427 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 93460] [amdgpu] Ooops during shutdown - amdgpu_vm_grab_id

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 336 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93460

--- Comment #4 from Mike Lothian <mike@fireburn.co.uk> ---
When this happens my machine just freezes, the only way to continue is to press
and hold the power button but that doesn't cleanly unmount the disks

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1103 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 93460] [amdgpu] Ooops during shutdown - amdgpu_vm_grab_id

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 593 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93460

--- Comment #5 from Christian König <deathsimple@vodafone.de> ---
(In reply to Mike Lothian from comment #4)
> When this happens my machine just freezes, the only way to continue is to
> press and hold the power button but that doesn't cleanly unmount the disks

Yeah, that is clearly a bug when the driver unloads.

Probably rather hard to reproduce, we should add a test case which loads and
unloads the driver multiple times while there is load.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1461 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 93460] [amdgpu] Ooops during shutdown - amdgpu_vm_grab_id

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 727 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93460

--- Comment #6 from david1.zhou@amd.com <david1.zhou@amd.com> ---
(In reply to Christian König from comment #5)
> (In reply to Mike Lothian from comment #4)
> > When this happens my machine just freezes, the only way to continue is to
> > press and hold the power button but that doesn't cleanly unmount the disks
> 
> Yeah, that is clearly a bug when the driver unloads.
> 
> Probably rather hard to reproduce, we should add a test case which loads and
> unloads the driver multiple times while there is load.

Maybe we shall avoid to use fence for vmid, instead using LRU list.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1665 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 93460] [amdgpu] Ooops during shutdown - amdgpu_vm_grab_id

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 631 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93460

--- Comment #7 from Christian König <deathsimple@vodafone.de> ---
(In reply to david1.zhou@amd.com from comment #6)
> Maybe we shall avoid to use fence for vmid, instead using LRU list.

Yeah, thought about that as well. The problem is that we used to have an LRU
list and I switched to fences because they had less overhead.

We still need to keep the fences around for synchronization, so I'm not sure if
that would really help.

The real price question is what is going wrong here?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1545 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 93460] [amdgpu] Ooops during shutdown - amdgpu_vm_grab_id

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 865 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93460

--- Comment #8 from david1.zhou@amd.com <david1.zhou@amd.com> ---
(In reply to Christian König from comment #7)
> (In reply to david1.zhou@amd.com from comment #6)
> > Maybe we shall avoid to use fence for vmid, instead using LRU list.
> 
> Yeah, thought about that as well. The problem is that we used to have an LRU
> list and I switched to fences because they had less overhead.
> 
> We still need to keep the fences around for synchronization, so I'm not sure
> if that would really help.
> 
> The real price question is what is going wrong here?

yes, we need to identify why the contexts of two fences are different, where
two fences come from, what the kind of two fences are, which ring two fences
belong.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1855 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 93460] [amdgpu] Ooops during shutdown - amdgpu_vm_grab_id

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 506 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93460

Mike Lothian <mike@fireburn.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #9 from Mike Lothian <mike@fireburn.co.uk> ---
Not seen this in a while now

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1972 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel