[Bug 94459] FLT_TO_INT rounding issues on pre R800 cards

[Bug 94459] FLT_TO_INT rounding issues on pre R800 cards

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1216 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=94459

            Bug ID: 94459
           Summary: FLT_TO_INT rounding issues on pre R800 cards
           Product: Mesa
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: medium
         Component: Drivers/Gallium/r600
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: siro@das-labor.org
        QA Contact: dri-devel@lists.freedesktop.org

Running WINE tests with Gallium Nine enabled I found the following test to fail
on pre R800 cards.
The failing test is from wine d3d9/tests/visual.c test_mova().
It can be found here: https://source.winehq.org/ident?_i=test_mova&_remember=1

To issue doesn't exists on radeonsi, softpipe and R800+.

The problem seems to be TGSI_OPCODE_ARR that should round on FLT_TO_INT, but
pre R800 cards truncate instead.
This might result in wrong addressing, as TGSI_OPCODE_ARR is expected to round.
If the card doesn't support rounding on FLT_TO_INT, r600 driver should insert a
rounding instruction.

Tested with latest mesa git on RV770.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2591 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 94459] FLT_TO_INT rounding issues on pre R800 cards

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 382 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=94459

--- Comment #1 from Patrick Rudolph <siro@das-labor.org> ---
Created attachment 122172
  --> https://bugs.freedesktop.org/attachment.cgi?id=122172&action=edit
patch r600_shader.c to insert a ALU_OP1_RNDNE instruction on pre r8xx cards for
TGSI_OPCODE_ARR

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1507 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 94459] FLT_TO_INT rounding issues on pre R800 cards

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 406 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=94459

--- Comment #2 from Roland Scheidegger <sroland@vmware.com> ---
The code in question isn't used by anything non-r600/r700, thus a switch isn't
warranted.
(I think it would look nicer if the arl/arr cases were merged and use a
conditional to select the rounding instruction too.)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1166 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 94459] FLT_TO_INT rounding issues on pre R800 cards

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 840 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=94459

GitLab Migration User <gitlab-migration@fdo.invalid> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |MOVED

--- Comment #3 from GitLab Migration User <gitlab-migration@fdo.invalid> ---
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been
closed from further activity.

You can subscribe and participate further through the new bug through this link
to our GitLab instance: https://gitlab.freedesktop.org/mesa/mesa/issues/579.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2423 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel