[Bug 95085] Invalid sampling of second texture in fragment shader that have two samplers with different parameters.

[Bug 95085] Invalid sampling of second texture in fragment shader that have two samplers with different parameters.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 557 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=95085

Marek Olšák <maraeo@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|idr@freedesktop.org         |dri-devel@lists.freedesktop
                   |                            |.org
          Component|glsl-compiler               |Drivers/Gallium/radeonsi
                 CC|maraeo@gmail.com            |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1508 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 95085] Invalid sampling of second texture in fragment shader that have two samplers with different parameters.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 858 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=95085

Nicolai Hähnle <nhaehnle@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |NOTOURBUG
             Status|NEW                         |RESOLVED

--- Comment #12 from Nicolai Hähnle <nhaehnle@gmail.com> ---
Frankly, I don't see how your sample is supposed to render text. The fragment
shader only accesses the font texture when nModeOut != 0u, and the value is
just passed through from the vertex buffer. According to qapitrace, nModeIn is
equal to 0 for all vertices in the final glDrawArrays call... at least based on
the apitrace, I'm pretty sure that this is not a driver bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2498 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 95085] Invalid sampling of second texture in fragment shader that have two samplers with different parameters.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 623 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=95085

Nicolai Hähnle <nhaehnle@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|NOTOURBUG                   |---
             Status|RESOLVED                    |REOPENED

--- Comment #13 from Nicolai Hähnle <nhaehnle@gmail.com> ---
I spoke too soon. There seem to be several bugs here (one pointed out by Bas
Nieuwenhuizen), I'm going to investigate this again in more detail.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2214 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 95085] Invalid sampling of second texture in fragment shader that have two samplers with different parameters.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 808 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=95085

--- Comment #14 from Nicolai Hähnle <nhaehnle@gmail.com> ---
I think I understand now where the bug is coming from, and I'm not sure if it's
a driver or an application bug :)

The trace uses glVertexAttribPointer instead of glVertexAttribIPointer to set
up a vertex element that will consumed by an uint GLSL variable. I kind of
suspect that that should be undefined behaviour, but I haven't found a
corresponding spec reference.

In any case, it looks like this causes different parts of the driver and the
various auxiliary tools to disagree about whether the element should be treated
as an int or as a float, and some conversion happens somewhere that makes it
all go wrong...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1703 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 95085] Invalid sampling of second texture in fragment shader that have two samplers with different parameters.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1395 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=95085

--- Comment #15 from Roland Scheidegger <sroland@vmware.com> ---
(In reply to Nicolai Hähnle from comment #14)

> The trace uses glVertexAttribPointer instead of glVertexAttribIPointer to
> set up a vertex element that will consumed by an uint GLSL variable. I kind
> of suspect that that should be undefined behaviour, but I haven't found a
> corresponding spec reference.

I can't see how that could work (I don't understand how that could work with
some drivers even). glVertexAttribPointer() means the data is really floats -
if you'd use a non-float type to specify it, it will implicitly get converted
to floats. So ok you could cheat there which would leave the data untouched (I
haven't looked at the trace), and rely on the uint input to just read that data
as-is maybe. Not sure if that could work even if you could trick the
implementation to do this - integers as floats have some bad habits, namely all
your negative numbers tend to change their value (as they are NaNs), and your
positive numbers may have some attraction to zero (as they are denorms...).
In any case, just don't do this - these different attrib pointers exist for a
reason. Also see
http://stackoverflow.com/questions/28014864/why-different-variations-of-glvertexattribpointer-do-exist

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2491 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 95085] Invalid sampling of second texture in fragment shader that have two samplers with different parameters.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 768 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=95085

Nicolai Hähnle <nhaehnle@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |NOTOURBUG

--- Comment #16 from Nicolai Hähnle <nhaehnle@gmail.com> ---
The shader only tests for non-zeroness, so it's possible that the difference
between radeonsi and the other drivers is that a denorm flush happens somewhere
with radeonsi and not the other drivers.

Anyway, I'm feeling lucky and closing this as NOTOURBUG for the second time
today :)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2413 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 95085] Invalid sampling of second texture in fragment shader that have two samplers with different parameters.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 419 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=95085

--- Comment #17 from Marek Olšák <maraeo@gmail.com> ---
FYI, the DX10_CLAMP shader bit flushes NaNs to 0. All other floating-point
shader opcodes flush denorms to 0. 32-bit denorms can be enabled with a
significant performance cost by setting conf->float_mode (see how it's done for
FP64).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1354 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 95085] Invalid sampling of second texture in fragment shader that have two samplers with different parameters.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 336 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=95085

--- Comment #18 from Leonid Maksymchuk <leonmaxx@gmail.com> ---
Sorry for bothering You with our bugs.
Next time I'll review the code more precisely, before reporting anything.

Thanks everyone for your help.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1274 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel