[Bug 97065] New: memory leak under Xwayland with old sdl1 applications

[Bug 97065] New: memory leak under Xwayland with old sdl1 applications

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 1150 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97065

            Bug ID: 97065
           Summary: memory leak under Xwayland with old sdl1 applications
           Product: xorg
           Version: unspecified
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Driver/nouveau
          Assignee: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
          Reporter: me-rYJ0iO+mrgIiq3RsQ1AnAw@public.gmane.org
        QA Contact: xorg-team-go0+a7rfsptAfugRpC6u6w@public.gmane.org

Created attachment 125286
  --> https://bugs.freedesktop.org/attachment.cgi?id=125286&action=edit
first memory map.

When running old applications under wayland/nouveau, there is a memory leak in
Xwayland.
Gtk2 applications show but this it is minimal. memory is not freed when the
application exits.
Using sdl1 applications makes the leaks very high, around 300 to 400Kbytes per
minute.
I asked on #wayland on freenode and it was suggested I post memory maps.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2572 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 97065] memory leak under Xwayland with old sdl1 applications

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 359 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97065

--- Comment #1 from Hussam Al-Tayeb <me-rYJ0iO+mrgIiq3RsQ1AnAw@public.gmane.org> ---
Created attachment 125287
  --> https://bugs.freedesktop.org/attachment.cgi?id=125287&action=edit
second memory map after memory increase

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1292 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 97065] memory leak under Xwayland with old sdl1 applications

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 336 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97065

--- Comment #2 from Hussam Al-Tayeb <me-rYJ0iO+mrgIiq3RsQ1AnAw@public.gmane.org> ---
Created attachment 125288
  --> https://bugs.freedesktop.org/attachment.cgi?id=125288&action=edit
third memory map

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1223 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 97065] memory leak under Xwayland with old sdl1 applications

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 419 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97065

--- Comment #3 from Hussam Al-Tayeb <me-rYJ0iO+mrgIiq3RsQ1AnAw@public.gmane.org> ---
Created attachment 125289
  --> https://bugs.freedesktop.org/attachment.cgi?id=125289&action=edit
forth memory map of xwayland process

Note that after exiting eveything, memory is not recovered.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1346 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 97065] memory leak under Xwayland with old sdl1 applications

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 342 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97065

--- Comment #4 from Hussam Al-Tayeb <me-rYJ0iO+mrgIiq3RsQ1AnAw@public.gmane.org> ---
Firefox nightly 50a1 also causes this but only around 200Kbytes per minute.
Still memory is not freed on closing firefox.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1105 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 97065] memory leak under Xwayland with old sdl1 applications

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 313 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97065

--- Comment #5 from Link Mauve <bugs-xNsE4SeuFpL985uAA1p3mw@public.gmane.org> ---
Hi again Hussam, please also run xrestop and report whether something actually
increases there.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1071 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 97065] memory leak under Xwayland with old sdl1 applications

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 1008 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97065

--- Comment #6 from Hussam Al-Tayeb <me-rYJ0iO+mrgIiq3RsQ1AnAw@public.gmane.org> ---
(In reply to Link Mauve from comment #5)
> Hi again Hussam, please also run xrestop and report whether something
> actually increases there.

I tried that. Xwayland's memory usage increases without an increase in pixmaps
memory count according to xrestop.
Simply using a sdl1, or gtk2 application or firefox slowly makes Xwayland
memory usage increase.

When I close firefox, the total pixmap memory usage according to xrestop
decreases but xwayland never frees memory. It seems to just use more as I use
my computer.
Switching windows sometimes causes an increase. It even suddenly used 200k more
while I switched between gnome-terminal and firefox.

In either case, the reading according to xrestop seems to be stable. No
increases there unless I open more applications.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1844 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 97065] memory leak under Xwayland with old sdl1 applications

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 314 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97065

--- Comment #7 from Michel Dänzer <michel-otUistvHUpPR7s880joybQ@public.gmane.org> ---
The most helpful information would be from running Xwayland in valgrind
--leak-check=full.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1076 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 97065] memory leak under Xwayland with old sdl1 applications

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 414 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97065

--- Comment #8 from Hussam Al-Tayeb <me-rYJ0iO+mrgIiq3RsQ1AnAw@public.gmane.org> ---
(In reply to Michel Dänzer from comment #7)
> The most helpful information would be from running Xwayland in valgrind
> --leak-check=full.

How? if I kill the current Xwayland, gnome exits.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1250 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 97065] memory leak under Xwayland with old sdl1 applications

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 574 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97065

--- Comment #9 from Michel Dänzer <michel-otUistvHUpPR7s880joybQ@public.gmane.org> ---
There are a few possibilities:

* You can start a second Xwayland instance, e.g. something like

   valgrind --leak-check=full Xwayland :99 -noreset

  and then make clients connect to it by setting the environment variable
  DISPLAY=:99

* Find out how to make gnome-shell launch Xwayland in valgrind

* Do it in weston instead of in GNOME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1336 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 97065] memory leak under Xwayland with old sdl1 applications

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 813 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97065

--- Comment #10 from Hussam Al-Tayeb <me-rYJ0iO+mrgIiq3RsQ1AnAw@public.gmane.org> ---
(In reply to Michel Dänzer from comment #9)
> There are a few possibilities:
> 
> * You can start a second Xwayland instance, e.g. something like
> 
>    valgrind --leak-check=full Xwayland :99 -noreset
> 
>   and then make clients connect to it by setting the environment variable
>   DISPLAY=:99
> 
> * Find out how to make gnome-shell launch Xwayland in valgrind
> 
> * Do it in weston instead of in GNOME

I asked on irc yesterday if it is possible to start a second Xwayland instance
and I was told no.
Now I am glad it is possible to do so.
Thank you. I will try that.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1680 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 97065] memory leak under Xwayland with old sdl1 applications

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 453 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97065

--- Comment #11 from Hussam Al-Tayeb <me-rYJ0iO+mrgIiq3RsQ1AnAw@public.gmane.org> ---
Created attachment 125446
  --> https://bugs.freedesktop.org/attachment.cgi?id=125446&action=edit
valgrind log

Not very useful as I still need to recompile arch linux's packages with debug
symbols but this is the valgrind log.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1333 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 97065] memory leak under Xwayland with old sdl1 applications

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 460 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97065

Michel Dänzer <michel-otUistvHUpPR7s880joybQ@public.gmane.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125446|application/octet-stream    |application/gzip
          mime type|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1116 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 97065] memory leak under Xwayland with old sdl1 applications

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 1633 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97065

Michel Dänzer <michel-otUistvHUpPR7s880joybQ@public.gmane.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Driver/nouveau              |XWayland
            Product|xorg                        |Wayland
           Assignee|nouveau-PD4FTy7X32lNgt0PjOBp93rCq3LdnpKM@public.gmane.org |wayland-bugs-PD4FTy7X32lzq7FAFJ/aeQ@public.gmane.org
                   |rg                          |top.org

--- Comment #12 from Michel Dänzer <michel-otUistvHUpPR7s880joybQ@public.gmane.org> ---
Looks like there's a leak between Xwayland and libwayland-client:

==6371== 803,664 bytes in 11,162 blocks are definitely lost in loss record
3,443 of 3,443
==6371==    at 0x4C2CA4A: calloc (in
/usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==6371==    by 0x5568B72: ??? (in /usr/lib/libwayland-client.so.0.3.0)
==6371==    by 0x5569094: wl_proxy_marshal_array_constructor_versioned (in
/usr/lib/libwayland-client.so.0.3.0)
==6371==    by 0x55693B9: wl_proxy_marshal_constructor (in
/usr/lib/libwayland-client.so.0.3.0)
==6371==    by 0x423BDC: ??? (in /usr/bin/Xwayland)
==6371==    by 0x5576A0: BlockHandler (in /usr/bin/Xwayland)
==6371==    by 0x586DBA: WaitForSomething (in /usr/bin/Xwayland)
==6371==    by 0x552A3D: ??? (in /usr/bin/Xwayland)
==6371==    by 0x556C62: ??? (in /usr/bin/Xwayland)
==6371==    by 0x6F0C740: (below main) (in /usr/lib/libc-2.23.so)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3061 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau