[Bug 99158] vdpau segfaults and gpu locks with kodi on R9285

[Bug 99158] vdpau segfaults and gpu locks with kodi on R9285

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1891 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=99158

            Bug ID: 99158
           Summary: vdpau segfaults and gpu locks with kodi on R9285
           Product: Mesa
           Version: git
          Hardware: x86-64 (AMD64)
                OS: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/radeonsi
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: adf.lists@gmail.com
        QA Contact: dri-devel@lists.freedesktop.org

Created attachment 128583
  --> https://bugs.freedesktop.org/attachment.cgi?id=128583&action=edit
some segfaults

This is an initial report no bisects as I have no clue when it started yet.

It seems there is an unlucky timing situation with kodi that may segfault
radeonsi or lock gpu playing videos with vdpau h/w decode + temporal vdpau
deint which is default kodi settings.

I can't reproduce with mplayer or mpv.

It seems to need HD interlaced + deint, but that may be just because it changes
timing.

Running with VDPAU_TRACE=1 so far avoids the crash/lock, as does setting cpus
to perf.

Running kodi git, but it's reproducable with 11 month old git as well.

It's easiest to provoke starting kodi with a file on command line, but is
possible starting from running kodi menu - possible improved chance of
crash/lock by moving mouse after clicking file to make overlay instantly render
over video.

Attaching some segfaults and locks.

I am running git mesa/llvm/kernel and the crash is rare enough that I may have
missed it for ages given the amount I test kodi. Additionally the best way to
provoke = repeated command line start, only started being possible again
ecently due to a kodi bug.

The segfaults are a bit random.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3384 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 99158] vdpau segfaults and gpu locks with kodi on R9285

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 308 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=99158

--- Comment #1 from Andy Furniss <adf.lists@gmail.com> ---
Created attachment 128584
  --> https://bugs.freedesktop.org/attachment.cgi?id=128584&action=edit
some gpu locks

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1207 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 99158] vdpau segfaults and gpu locks with kodi on R9285

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 282 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=99158

--- Comment #2 from Michel Dänzer <michel@daenzer.net> ---
Can you try reproducing it in valgrind and see if that raises some interesting
errors?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1062 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 99158] vdpau segfaults and gpu locks with kodi on R9285

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 568 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=99158

--- Comment #3 from Andy Furniss <adf.lists@gmail.com> ---
Couldn't get it to crash with valgrind.

Bisect not 100% sure as it seemed to get harder to provoke going back in time,
but it does seem to need temporal deint and I got -

first bad commit: [d0d5f7600c2e8ab8d0c153787185f7a534753edd]
Revert "st/vdpau: use linear layout for output surfaces

The revert reverts from current head, so I will test for a while like that.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1352 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 99158] vdpau segfaults and gpu locks with kodi on R9285

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 842 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=99158

--- Comment #4 from Andy Furniss <adf.lists@gmail.com> ---
(In reply to Andy Furniss from comment #3)
> Couldn't get it to crash with valgrind.
> 
> Bisect not 100% sure as it seemed to get harder to provoke going back in
> time, but it does seem to need temporal deint and I got -
> 
> first bad commit: [d0d5f7600c2e8ab8d0c153787185f7a534753edd]
> Revert "st/vdpau: use linear layout for output surfaces
> 
> The revert reverts from current head, so I will test for a while like that.

I've been running OK with the revert reverted for some time now, testing with a
script that repeatedly starts kodi, so it does seem to be this commit that
causes some timing issue with vdpau temporal deint.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1720 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 99158] vdpau segfaults and gpu locks with kodi on R9285

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 561 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=99158

--- Comment #5 from Christian König <deathsimple@vodafone.de> ---
Yeah and that actually makes sense, by using linear layout you also disable
DCC.

Does using R600_DEBUG=nodcc help as well?

Marek please take a look at the backtraces in the first post. It sounds like
one thread is getting the handle of a texture which results in a DCC
decompress.

Could it be that we have a race with that?

Regards,
Christian.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1348 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 99158] vdpau segfaults and gpu locks with kodi on R9285

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1095 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=99158

--- Comment #6 from Marek Olšák <maraeo@gmail.com> ---
We could get a race if vlVdpOutputSurfaceDMABuf is called from a different
thread than the context is normally used with. Can that happen?

You can try to test this:

diff --git a/src/gallium/state_trackers/vdpau/output.c
b/src/gallium/state_trackers/vdpau/output.c
index 64574b2..96474fb 100644
--- a/src/gallium/state_trackers/vdpau/output.c
+++ b/src/gallium/state_trackers/vdpau/output.c
@@ -804,7 +804,7 @@ VdpStatus vlVdpOutputSurfaceDMABuf(VdpOutputSurface
surface,
    whandle.type = DRM_API_HANDLE_TYPE_FD;

    pscreen = vlsurface->surface->texture->screen;
-   if (!pscreen->resource_get_handle(pscreen, vlsurface->device->context,
+   if (!pscreen->resource_get_handle(pscreen, NULL,
                                      vlsurface->surface->texture, &whandle,
                                     PIPE_HANDLE_USAGE_READ_WRITE))
       return VDP_STATUS_NO_IMPLEMENTATION;

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1919 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 99158] vdpau segfaults and gpu locks with kodi on R9285

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 300 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=99158

--- Comment #7 from Marek Olšák <maraeo@gmail.com> ---
Nevermind. This series should fix it for VDPAU and VAAPI:

https://patchwork.freedesktop.org/series/17480/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1139 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 99158] vdpau segfaults and gpu locks with kodi on R9285

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 389 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=99158

--- Comment #8 from Andy Furniss <adf.lists@gmail.com> ---
(In reply to Marek Olšák from comment #7)
> Nevermind. This series should fix it for VDPAU and VAAPI:
> 
> https://patchwork.freedesktop.org/series/17480/

Yea, it's OK with these, thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1306 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 99158] vdpau segfaults and gpu locks with kodi on R9285

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 436 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=99158

Christian König <deathsimple@vodafone.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1269 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel