[Bug 99637] VLC video has corrupted colors when using VDPAU output on Radeon SI

[Bug 99637] VLC video has corrupted colors when using VDPAU output on Radeon SI

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1218 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=99637

            Bug ID: 99637
           Summary: VLC video has corrupted colors when using VDPAU output
                    on Radeon SI
           Product: Mesa
           Version: 17.0
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/radeonsi
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: freedesktop@mattwhitlock.name
        QA Contact: dri-devel@lists.freedesktop.org

Two reports of this so far on Gentoo when using Mesa 17.0.0 RC2.

See a screenshot here:
https://bugs.gentoo.org/attachment.cgi?id=461558

I am reporting this bug upstream (i.e., here) at the request of Gentoo dev Matt
Turner.

Here is the Gentoo bug report:
https://bugs.gentoo.org/show_bug.cgi?id=607368

The problem disappears upon downgrading to Mesa 13.0.3.

Mateusz Lenik, the reporter of the bug on Gentoo's tracker, is using a Polaris
10 card, and I am using a Tobago (Bonaire Pro) card. We are both using the
"radeonsi" VDPAU driver.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2723 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 99637] VLC video has corrupted colors when using VDPAU output on Radeon SI

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 451 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=99637

Matt Whitlock <freedesktop@mattwhitlock.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Hardware|Other                       |x86-64 (AMD64)
                 OS|All                         |Linux (All)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1276 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 99637] VLC video has corrupted colors when using VDPAU output on Radeon SI

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1046 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=99637

--- Comment #1 from Nayan Deshmukh <nayan26deshmukh@gmail.com> ---
The problem is already fixed in the master branch. This patch fixes the issue.

Commit: 31908d6a4a3309f4cd4b953d6eecdf41595b1299

   st/vdpau: only send buffers with B8G8R8A8 format to X
   PresentPixmap only works if the pixmap depth matches with the
   window depth, otherwise it returns a BadMatch protocol error.
   Even if the depths match, the result won't look correctly
   if the VDPAU RGB component order doesn't match the X11 one so
   we only allow the X11 format.
   For other buffers we copy them to a buffer which is send to X.

   v2: only send buffers with format VDP_RGBA_FORMAT_B8G8R8A8
   v3: reword commit message
   v4: add comment explaining the code

   Signed-off-by: Nayan Deshmukh <nayan26deshmukh@gmail.com>
   Reviewed-by: Christian König <christian.koenig@amd.com>

Can you test with this patch?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1992 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 99637] VLC video has corrupted colors when using VDPAU output on Radeon SI

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 655 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=99637

Matt Whitlock <freedesktop@mattwhitlock.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Matt Whitlock <freedesktop@mattwhitlock.name> ---
(In reply to Nayan Deshmukh from comment #1)
> Can you test with this patch?

Applying the patch to 17.0.0 RC2 solves the problem. Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2297 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 99637] VLC video has corrupted colors when using VDPAU output on Radeon SI

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 562 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=99637

Michel Dänzer <michel@daenzer.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
             Status|RESOLVED                    |REOPENED

--- Comment #3 from Michel Dänzer <michel@daenzer.net> ---
This report should remain open until the fix lands on the 17.0 branch.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2073 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 99637] VLC video has corrupted colors when using VDPAU output on Radeon SI

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 370 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=99637

--- Comment #4 from Nayan Deshmukh <nayan26deshmukh@gmail.com> ---
(In reply to Michel Dänzer from comment #3)
> This report should remain open until the fix lands on the 17.0 branch.

I will nominate the patch for the 17.0 branch.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1285 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 99637] VLC video has corrupted colors when using VDPAU output on Radeon SI

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 543 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=99637

Nayan Deshmukh <nayan26deshmukh@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Nayan Deshmukh <nayan26deshmukh@gmail.com> ---
The patch has landed on 17.0.0-rc3.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2114 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel