All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Andrew Jones <drjones@redhat.com>
Cc: pbonzini@redhat.com, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org
Subject: Re: [PATCH 2/2] KVM: arm64: selftests: get-reg-list: actually enable pmu regs in pmu sublist
Date: Wed, 14 Jul 2021 11:53:41 +0100	[thread overview]
Message-ID: <c06f2f53614fa7f98e33a43d117a267a@kernel.org> (raw)
In-Reply-To: <20210713203742.29680-3-drjones@redhat.com>

On 2021-07-13 21:37, Andrew Jones wrote:
> We reworked get-reg-list to make it easier to enable optional register
> sublists by parametrizing their vcpu feature flags as well as making
> other generalizations. That was all to make sure we enable the PMU
> registers when we want to test them. Somehow we forgot to actually
> include the PMU feature flag in the PMU sublist description though!
> Do that now.

Ah! :D

> 
> Fixes: 313673bad871 ("KVM: arm64: selftests: get-reg-list: Split base
> and pmu registers")
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
>  tools/testing/selftests/kvm/aarch64/get-reg-list.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/kvm/aarch64/get-reg-list.c
> b/tools/testing/selftests/kvm/aarch64/get-reg-list.c
> index a16c8f05366c..cc898181faab 100644
> --- a/tools/testing/selftests/kvm/aarch64/get-reg-list.c
> +++ b/tools/testing/selftests/kvm/aarch64/get-reg-list.c
> @@ -1019,7 +1019,8 @@ static __u64 sve_rejects_set[] = {
>  #define VREGS_SUBLIST \
>  	{ "vregs", .regs = vregs, .regs_n = ARRAY_SIZE(vregs), }
>  #define PMU_SUBLIST \
> -	{ "pmu", .regs = pmu_regs, .regs_n = ARRAY_SIZE(pmu_regs), }
> +	{ "pmu", .capability = KVM_CAP_ARM_PMU_V3, .feature = 
> KVM_ARM_VCPU_PMU_V3, \
> +	  .regs = pmu_regs, .regs_n = ARRAY_SIZE(pmu_regs), }
>  #define SVE_SUBLIST \
>  	{ "sve", .capability = KVM_CAP_ARM_SVE, .feature = KVM_ARM_VCPU_SVE,
> .finalize = true, \
>  	  .regs = sve_regs, .regs_n = ARRAY_SIZE(sve_regs), \

Good timing, I'm queuing fixes. I'll pick those in a moment.

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Andrew Jones <drjones@redhat.com>
Cc: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, pbonzini@redhat.com
Subject: Re: [PATCH 2/2] KVM: arm64: selftests: get-reg-list: actually enable pmu regs in pmu sublist
Date: Wed, 14 Jul 2021 11:53:41 +0100	[thread overview]
Message-ID: <c06f2f53614fa7f98e33a43d117a267a@kernel.org> (raw)
In-Reply-To: <20210713203742.29680-3-drjones@redhat.com>

On 2021-07-13 21:37, Andrew Jones wrote:
> We reworked get-reg-list to make it easier to enable optional register
> sublists by parametrizing their vcpu feature flags as well as making
> other generalizations. That was all to make sure we enable the PMU
> registers when we want to test them. Somehow we forgot to actually
> include the PMU feature flag in the PMU sublist description though!
> Do that now.

Ah! :D

> 
> Fixes: 313673bad871 ("KVM: arm64: selftests: get-reg-list: Split base
> and pmu registers")
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
>  tools/testing/selftests/kvm/aarch64/get-reg-list.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/kvm/aarch64/get-reg-list.c
> b/tools/testing/selftests/kvm/aarch64/get-reg-list.c
> index a16c8f05366c..cc898181faab 100644
> --- a/tools/testing/selftests/kvm/aarch64/get-reg-list.c
> +++ b/tools/testing/selftests/kvm/aarch64/get-reg-list.c
> @@ -1019,7 +1019,8 @@ static __u64 sve_rejects_set[] = {
>  #define VREGS_SUBLIST \
>  	{ "vregs", .regs = vregs, .regs_n = ARRAY_SIZE(vregs), }
>  #define PMU_SUBLIST \
> -	{ "pmu", .regs = pmu_regs, .regs_n = ARRAY_SIZE(pmu_regs), }
> +	{ "pmu", .capability = KVM_CAP_ARM_PMU_V3, .feature = 
> KVM_ARM_VCPU_PMU_V3, \
> +	  .regs = pmu_regs, .regs_n = ARRAY_SIZE(pmu_regs), }
>  #define SVE_SUBLIST \
>  	{ "sve", .capability = KVM_CAP_ARM_SVE, .feature = KVM_ARM_VCPU_SVE,
> .finalize = true, \
>  	  .regs = sve_regs, .regs_n = ARRAY_SIZE(sve_regs), \

Good timing, I'm queuing fixes. I'll pick those in a moment.

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...

  reply	other threads:[~2021-07-14 10:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-13 20:37 [PATCH 0/2] KVM: selftests: a couple fixes Andrew Jones
2021-07-13 20:37 ` Andrew Jones
2021-07-13 20:37 ` [PATCH 1/2] KVM: selftests: change pthread_yield to sched_yield Andrew Jones
2021-07-13 20:37   ` Andrew Jones
2021-07-13 20:37 ` [PATCH 2/2] KVM: arm64: selftests: get-reg-list: actually enable pmu regs in pmu sublist Andrew Jones
2021-07-13 20:37   ` Andrew Jones
2021-07-14 10:53   ` Marc Zyngier [this message]
2021-07-14 10:53     ` Marc Zyngier
2021-07-14 10:56 ` [PATCH 0/2] KVM: selftests: a couple fixes Marc Zyngier
2021-07-14 10:56   ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c06f2f53614fa7f98e33a43d117a267a@kernel.org \
    --to=maz@kernel.org \
    --cc=drjones@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.