* [PATCH] accel/ivpu: Fix wrong register read in LNL failure diagnostics
@ 2026-07-10 10:13 Karol Wachowski
2026-07-13 7:18 ` Andrzej Kacprowski
0 siblings, 1 reply; 3+ messages in thread
From: Karol Wachowski @ 2026-07-10 10:13 UTC (permalink / raw)
To: dri-devel
Cc: oded.gabbay, jeff.hugo, lizhi.hou, andrzej.kacprowski,
dawid.osuchowski, Karol Wachowski
diagnose_failure_lnl() read VPU_HW_BTRS_MTL_INTERRUPT_STAT instead of
VPU_HW_BTRS_LNL_INTERRUPT_STAT, which on LNL and newer parts is a
different register with a different bit layout, so failure diagnostics
decoded the wrong register and reported a bogus error cause.
Read the LNL interrupt status register instead.
Fixes: 8a27ad81f7d3 ("accel/ivpu: Split IP and buttress code")
Signed-off-by: Karol Wachowski <karol.wachowski@linux.intel.com>
---
drivers/accel/ivpu/ivpu_hw_btrs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/accel/ivpu/ivpu_hw_btrs.c b/drivers/accel/ivpu/ivpu_hw_btrs.c
index dac935164e11..a17c829adb89 100644
--- a/drivers/accel/ivpu/ivpu_hw_btrs.c
+++ b/drivers/accel/ivpu/ivpu_hw_btrs.c
@@ -927,7 +927,7 @@ static void diagnose_failure_mtl(struct ivpu_device *vdev)
static void diagnose_failure_lnl(struct ivpu_device *vdev)
{
- u32 reg = REGB_RD32(VPU_HW_BTRS_MTL_INTERRUPT_STAT) & BTRS_LNL_IRQ_MASK;
+ u32 reg = REGB_RD32(VPU_HW_BTRS_LNL_INTERRUPT_STAT) & BTRS_LNL_IRQ_MASK;
if (REG_TEST_FLD(VPU_HW_BTRS_LNL_INTERRUPT_STAT, ATS_ERR, reg)) {
ivpu_err(vdev, "ATS_ERR_LOG1 0x%08x ATS_ERR_LOG2 0x%08x\n",
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] accel/ivpu: Fix wrong register read in LNL failure diagnostics
2026-07-10 10:13 [PATCH] accel/ivpu: Fix wrong register read in LNL failure diagnostics Karol Wachowski
@ 2026-07-13 7:18 ` Andrzej Kacprowski
2026-07-13 8:32 ` Wachowski, Karol
0 siblings, 1 reply; 3+ messages in thread
From: Andrzej Kacprowski @ 2026-07-13 7:18 UTC (permalink / raw)
To: Karol Wachowski, dri-devel
On 10-Jul-26 12:13 PM, Karol Wachowski wrote:
> diagnose_failure_lnl() read VPU_HW_BTRS_MTL_INTERRUPT_STAT instead of
> VPU_HW_BTRS_LNL_INTERRUPT_STAT, which on LNL and newer parts is a
> different register with a different bit layout, so failure diagnostics
> decoded the wrong register and reported a bogus error cause.
> Read the LNL interrupt status register instead.
>
> Fixes: 8a27ad81f7d3 ("accel/ivpu: Split IP and buttress code")
> Signed-off-by: Karol Wachowski <karol.wachowski@linux.intel.com>
> ---
> drivers/accel/ivpu/ivpu_hw_btrs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/accel/ivpu/ivpu_hw_btrs.c b/drivers/accel/ivpu/ivpu_hw_btrs.c
> index dac935164e11..a17c829adb89 100644
> --- a/drivers/accel/ivpu/ivpu_hw_btrs.c
> +++ b/drivers/accel/ivpu/ivpu_hw_btrs.c
> @@ -927,7 +927,7 @@ static void diagnose_failure_mtl(struct ivpu_device *vdev)
>
> static void diagnose_failure_lnl(struct ivpu_device *vdev)
> {
> - u32 reg = REGB_RD32(VPU_HW_BTRS_MTL_INTERRUPT_STAT) & BTRS_LNL_IRQ_MASK;
> + u32 reg = REGB_RD32(VPU_HW_BTRS_LNL_INTERRUPT_STAT) & BTRS_LNL_IRQ_MASK;
>
> if (REG_TEST_FLD(VPU_HW_BTRS_LNL_INTERRUPT_STAT, ATS_ERR, reg)) {
> ivpu_err(vdev, "ATS_ERR_LOG1 0x%08x ATS_ERR_LOG2 0x%08x\n",
Reviewed-by: Andrzej Kacprowski <andrzej.kacprowski@linux.intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] accel/ivpu: Fix wrong register read in LNL failure diagnostics
2026-07-13 7:18 ` Andrzej Kacprowski
@ 2026-07-13 8:32 ` Wachowski, Karol
0 siblings, 0 replies; 3+ messages in thread
From: Wachowski, Karol @ 2026-07-13 8:32 UTC (permalink / raw)
To: Andrzej Kacprowski, dri-devel
On 13-Jul-26 9:18, Andrzej Kacprowski wrote:
> On 10-Jul-26 12:13 PM, Karol Wachowski wrote:
>> diagnose_failure_lnl() read VPU_HW_BTRS_MTL_INTERRUPT_STAT instead of
>> VPU_HW_BTRS_LNL_INTERRUPT_STAT, which on LNL and newer parts is a
>> different register with a different bit layout, so failure diagnostics
>> decoded the wrong register and reported a bogus error cause.
>> Read the LNL interrupt status register instead.
>>
>> Fixes: 8a27ad81f7d3 ("accel/ivpu: Split IP and buttress code")
>> Signed-off-by: Karol Wachowski <karol.wachowski@linux.intel.com>
>> ---
>> drivers/accel/ivpu/ivpu_hw_btrs.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/accel/ivpu/ivpu_hw_btrs.c b/drivers/accel/ivpu/
>> ivpu_hw_btrs.c
>> index dac935164e11..a17c829adb89 100644
>> --- a/drivers/accel/ivpu/ivpu_hw_btrs.c
>> +++ b/drivers/accel/ivpu/ivpu_hw_btrs.c
>> @@ -927,7 +927,7 @@ static void diagnose_failure_mtl(struct
>> ivpu_device *vdev)
>> static void diagnose_failure_lnl(struct ivpu_device *vdev)
>> {
>> - u32 reg = REGB_RD32(VPU_HW_BTRS_MTL_INTERRUPT_STAT) &
>> BTRS_LNL_IRQ_MASK;
>> + u32 reg = REGB_RD32(VPU_HW_BTRS_LNL_INTERRUPT_STAT) &
>> BTRS_LNL_IRQ_MASK;
>> if (REG_TEST_FLD(VPU_HW_BTRS_LNL_INTERRUPT_STAT, ATS_ERR, reg)) {
>> ivpu_err(vdev, "ATS_ERR_LOG1 0x%08x ATS_ERR_LOG2 0x%08x\n",
>
> Reviewed-by: Andrzej Kacprowski <andrzej.kacprowski@linux.intel.com>
Thanks!
Applied to drm-misc-fixes.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-07-13 8:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-10 10:13 [PATCH] accel/ivpu: Fix wrong register read in LNL failure diagnostics Karol Wachowski
2026-07-13 7:18 ` Andrzej Kacprowski
2026-07-13 8:32 ` Wachowski, Karol
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.