All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nikhil Gautam <nikhilgtr@gmail.com>
To: Joshua Crofts <joshua.crofts1@gmail.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
	andy@kernel.org
Subject: Re: [PATCH] iio: ccs811: Deassert WAKE GPIO on error paths
Date: Thu, 15 Oct 2026 17:36:31 +0530	[thread overview]
Message-ID: <c0a5726c-2a35-4e2f-afc4-8cef65877e8b@gmail.com> (raw)
In-Reply-To: <20261015111145.000065b3@gmail.com>


Hi Joshua,

Thanks for the review.

> Please add a Fixes tag.
>
> ...
Sure, will add Fixes tag in next version
>>   	ret = i2c_smbus_read_i2c_block_data(data->client,
>>   					    CCS811_ALG_RESULT_DATA, 8,
>>   					    (char *)&data->buffer);
>> +out:
>>   	ccs811_set_wakeup(data, false);
>> -
> Keep the blank line.
Noted.
> Otherwise,
>
> Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>
Regards,
Nikhil

      reply	other threads:[~2026-10-15 12:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-14 15:22 [PATCH] iio: ccs811: Deassert WAKE GPIO on error paths Nikhil Gautam
2026-10-15  9:11 ` Joshua Crofts
2026-10-15 12:06   ` Nikhil Gautam [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0a5726c-2a35-4e2f-afc4-8cef65877e8b@gmail.com \
    --to=nikhilgtr@gmail.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=joshua.crofts1@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.