From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Bjorn Helgaas <helgaas@kernel.org>,
Jaehoon Chung <jh80.chung@samsung.com>,
Jingoo Han <jingoohan1@gmail.com>
Cc: "Krzysztof Wilczyński" <kw@linux.com>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: pci-exynos.c phy_init() usage
Date: Fri, 24 Jun 2022 20:07:56 +0200 [thread overview]
Message-ID: <c0c802c0-82e1-e7bb-48be-974ac23b5a15@linaro.org> (raw)
In-Reply-To: <20220624173541.GA1543581@bhelgaas>
On 24/06/2022 19:35, Bjorn Helgaas wrote:
> In exynos_pcie_host_init() [1], we call:
>
> phy_reset(ep->phy);
> phy_power_on(ep->phy);
> phy_init(ep->phy);
>
> The phy_init() function comment [2] says it must be called before
> phy_power_on(). Is exynos doing this backwards?
Looks like. I don't have Exynos hardware with a PCI, so cannot
test/fix/verify.
Luckily for Exynos ;-) it's not alone in this pattern:
drivers/net/ethernet/marvell/sky2.c
drivers/usb/dwc2/platform.c
>
> Bjorn
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/pci/controller/dwc/pci-exynos.c?id=v5.19-rc1#n252
> [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/phy/phy-core.c?id=v5.19-rc1#n233
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Bjorn Helgaas <helgaas@kernel.org>,
Jaehoon Chung <jh80.chung@samsung.com>,
Jingoo Han <jingoohan1@gmail.com>
Cc: "Krzysztof Wilczyński" <kw@linux.com>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: pci-exynos.c phy_init() usage
Date: Fri, 24 Jun 2022 20:07:56 +0200 [thread overview]
Message-ID: <c0c802c0-82e1-e7bb-48be-974ac23b5a15@linaro.org> (raw)
In-Reply-To: <20220624173541.GA1543581@bhelgaas>
On 24/06/2022 19:35, Bjorn Helgaas wrote:
> In exynos_pcie_host_init() [1], we call:
>
> phy_reset(ep->phy);
> phy_power_on(ep->phy);
> phy_init(ep->phy);
>
> The phy_init() function comment [2] says it must be called before
> phy_power_on(). Is exynos doing this backwards?
Looks like. I don't have Exynos hardware with a PCI, so cannot
test/fix/verify.
Luckily for Exynos ;-) it's not alone in this pattern:
drivers/net/ethernet/marvell/sky2.c
drivers/usb/dwc2/platform.c
>
> Bjorn
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/pci/controller/dwc/pci-exynos.c?id=v5.19-rc1#n252
> [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/phy/phy-core.c?id=v5.19-rc1#n233
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-24 18:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 17:35 pci-exynos.c phy_init() usage Bjorn Helgaas
2022-06-24 17:35 ` Bjorn Helgaas
2022-06-24 18:07 ` Krzysztof Kozlowski [this message]
2022-06-24 18:07 ` Krzysztof Kozlowski
2022-06-27 10:30 ` Marek Szyprowski
2022-06-27 10:30 ` Marek Szyprowski
2022-06-27 10:47 ` Krzysztof Kozlowski
2022-06-27 10:47 ` Krzysztof Kozlowski
2022-06-28 8:13 ` Marek Szyprowski
2022-06-28 8:13 ` Marek Szyprowski
2022-06-28 8:27 ` Krzysztof Kozlowski
2022-06-28 8:27 ` Krzysztof Kozlowski
2022-06-28 10:59 ` Bjorn Helgaas
2022-06-28 10:59 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0c802c0-82e1-e7bb-48be-974ac23b5a15@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=helgaas@kernel.org \
--cc=jh80.chung@samsung.com \
--cc=jingoohan1@gmail.com \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.