Re: [PATCH i-g-t] lib/igt_kmod: Stop unloading drm

[Peter Senna Tschudin <peter.senna@linux.intel.com>]

Hi Lucas,

My nits are not blockers to your patch being merged.

On 05.02.2025 04:07, Lucas De Marchi wrote:
> When testing i915, if there's another driver present, unloading i915 may
> cause the other driver to unload and let developers chasing ghosts when
> they think it was caused by i915.
> 
> Hopefully fix the ATSM testing where AST driver is also bound to a
> a device.

Maybe a sentence about intel-gtt?

> 
> Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13292
Reviewed-by: Peter Senna Tschudin <peter.senna@linux.intel.com>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
> 
> After this change, running i915_module_load@reload doesn't cause ast to
> be unloaded, but I couldn't check it really fixes the issue since I
> couldn't reproduce it.
> 
>  lib/igt_kmod.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
> index d154701c6..524c1a632 100644
> --- a/lib/igt_kmod.c
> +++ b/lib/igt_kmod.c
> @@ -690,7 +690,6 @@ int igt_kmod_unbind(const char *mod_name)
>   * igt_intel_driver_unload:
>   *
>   * Unloads an Intel driver and its dependencies.
Maybe change this to reflect what it is doing as the dependencies
bit may no longer apply.

> - *
>   */
>  int
>  igt_intel_driver_unload(const char *driver)
> @@ -709,12 +708,6 @@ igt_intel_driver_unload(const char *driver)
>  	}
>  	free(who);
>  
> -	if (igt_kmod_is_loaded("intel-gtt"))
> -		igt_kmod_unload("intel-gtt");
> -
> -	igt_kmod_unload("drm_kms_helper");
> -	igt_kmod_unload("drm");
> -
>  	if (igt_kmod_is_loaded(driver)) {
>  		igt_warn("%s.ko still loaded!\n", driver);
>  		return -EBUSY;