All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t] lib/igt_kmod: Stop unloading drm
@ 2025-02-05  3:07 Lucas De Marchi
  2025-02-05  4:10 ` ✗ Xe.CI.BAT: failure for " Patchwork
                   ` (13 more replies)
  0 siblings, 14 replies; 18+ messages in thread
From: Lucas De Marchi @ 2025-02-05  3:07 UTC (permalink / raw)
  To: igt-dev; +Cc: Lucas De Marchi

When testing i915, if there's another driver present, unloading i915 may
cause the other driver to unload and let developers chasing ghosts when
they think it was caused by i915.

Hopefully fix the ATSM testing where AST driver is also bound to a
a device.

Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13292
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---

After this change, running i915_module_load@reload doesn't cause ast to
be unloaded, but I couldn't check it really fixes the issue since I
couldn't reproduce it.

 lib/igt_kmod.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
index d154701c6..524c1a632 100644
--- a/lib/igt_kmod.c
+++ b/lib/igt_kmod.c
@@ -690,7 +690,6 @@ int igt_kmod_unbind(const char *mod_name)
  * igt_intel_driver_unload:
  *
  * Unloads an Intel driver and its dependencies.
- *
  */
 int
 igt_intel_driver_unload(const char *driver)
@@ -709,12 +708,6 @@ igt_intel_driver_unload(const char *driver)
 	}
 	free(who);
 
-	if (igt_kmod_is_loaded("intel-gtt"))
-		igt_kmod_unload("intel-gtt");
-
-	igt_kmod_unload("drm_kms_helper");
-	igt_kmod_unload("drm");
-
 	if (igt_kmod_is_loaded(driver)) {
 		igt_warn("%s.ko still loaded!\n", driver);
 		return -EBUSY;
-- 
2.48.1


^ permalink raw reply related	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2025-02-12 14:13 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-05  3:07 [PATCH i-g-t] lib/igt_kmod: Stop unloading drm Lucas De Marchi
2025-02-05  4:10 ` ✗ Xe.CI.BAT: failure for " Patchwork
2025-02-05  4:28 ` ✗ i915.CI.BAT: " Patchwork
2025-02-05 14:32   ` Lucas De Marchi
2025-02-05 10:25 ` ✗ Xe.CI.Full: " Patchwork
2025-02-06 14:50 ` [PATCH i-g-t] " Lucas De Marchi
2025-02-06 15:04 ` Peter Senna Tschudin
2025-02-06 15:21   ` Lucas De Marchi
2025-02-06 19:29 ` ✓ Xe.CI.BAT: success for lib/igt_kmod: Stop unloading drm (rev2) Patchwork
2025-02-06 22:37 ` ✗ Xe.CI.Full: failure " Patchwork
2025-02-07 11:31 ` ✓ Xe.CI.BAT: success " Patchwork
2025-02-07 14:02 ` ✗ Xe.CI.Full: failure " Patchwork
2025-02-10 20:50 ` ✗ GitLab.Pipeline: warning for lib/igt_kmod: Stop unloading drm (rev3) Patchwork
2025-02-10 23:07 ` ✗ i915.CI.BAT: failure " Patchwork
2025-02-10 23:08 ` ✓ Xe.CI.BAT: success " Patchwork
2025-02-11  9:21 ` ✗ Xe.CI.Full: failure " Patchwork
2025-02-12 13:41 ` ✗ i915.CI.Full: " Patchwork
2025-02-12 14:13   ` Lucas De Marchi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.