From: Florian Fainelli <florian.fainelli@broadcom.com>
To: "Álvaro Fernández Rojas" <noltari@gmail.com>,
dregan@broadcom.com, "Miquel Raynal" <miquel.raynal@bootlin.com>,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
"MTD Maling List" <linux-mtd@lists.infradead.org>,
"Rafał Miłecki" <rafal@milecki.pl>,
"Brian Norris" <computersforpeace@gmail.com>,
dan.beygelman@broadcom.com,
"William Zhang" <william.zhang@broadcom.com>,
frieder.schrempf@kontron.de,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Vignesh R" <vigneshr@ti.com>,
"Richard Weinberger" <richard@nod.at>,
bbrezillon@kernel.org, "Kamal Dasu" <kdasu.kdev@gmail.com>,
"liao jaime" <jaimeliao.tw@gmail.com>,
kilobyte@angband.pl, "Jonas Gorski" <jonas.gorski@gmail.com>,
dgcbueu <dgcbueu@gmail.com>
Subject: Re: mtd: rawnand: brcmnand: exec_op patch broke < v5.0 controllers
Date: Mon, 12 May 2025 16:38:10 +0200 [thread overview]
Message-ID: <c19fcd0b-2004-4c99-8733-937fcfa0769a@broadcom.com> (raw)
In-Reply-To: <CAKR-sGezB_SEb7UfPV6o6T2yibkAzNSqK9Hry1kNM46BMsH2_g@mail.gmail.com>
On 5/11/2025 11:42 AM, Álvaro Fernández Rojas wrote:
> Hi David,
>
> I've just realized that your exec_op implementation patch broke
> support of v2.1, v2.2 and v4.0 controllers.
> https://github.com/torvalds/linux/commit/3c8260ce76634291aed877032a41e373884d69e4
> https://patchwork.ozlabs.org/project/linux-mtd/patch/20231125012438.15191-4-dregan@broadcom.com/
> I know it's an old patch from 6.8 but I just discovered this while
> trying to add 6.12 support for bmips on OpenWrt (from 6.6):
> https://github.com/openwrt/openwrt/pull/18746
>
> The issue is that low level ops always return 0 on v4.0 controllers
> and v2.1/v2.2 controllers don't even have the low level registers
> defined:
> https://github.com/torvalds/linux/blob/3ce9925823c7d6bb0e6eb951bf2db0e9e182582d/drivers/mtd/nand/raw/brcmnand/brcmnand.c#L357
> https://github.com/torvalds/linux/blob/3ce9925823c7d6bb0e6eb951bf2db0e9e182582d/drivers/mtd/nand/raw/brcmnand/brcmnand.c#L371
>
> I guess that restoring the legacy functions isn't going to happen, but
> is it possible to restore < v5.0 compatibility on the new exec_op
> implementation?
Unfortunately, I don't think we have any other choice unless we want to
have a functional NAND driver for these older chips. Would you be
willing to do that? Thanks
--
Florian
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <florian.fainelli@broadcom.com>
To: "Álvaro Fernández Rojas" <noltari@gmail.com>,
dregan@broadcom.com, "Miquel Raynal" <miquel.raynal@bootlin.com>,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
"MTD Maling List" <linux-mtd@lists.infradead.org>,
"Rafał Miłecki" <rafal@milecki.pl>,
"Brian Norris" <computersforpeace@gmail.com>,
dan.beygelman@broadcom.com,
"William Zhang" <william.zhang@broadcom.com>,
frieder.schrempf@kontron.de,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Vignesh R" <vigneshr@ti.com>,
"Richard Weinberger" <richard@nod.at>,
bbrezillon@kernel.org, "Kamal Dasu" <kdasu.kdev@gmail.com>,
"liao jaime" <jaimeliao.tw@gmail.com>,
kilobyte@angband.pl, "Jonas Gorski" <jonas.gorski@gmail.com>,
dgcbueu <dgcbueu@gmail.com>
Subject: Re: mtd: rawnand: brcmnand: exec_op patch broke < v5.0 controllers
Date: Mon, 12 May 2025 16:38:10 +0200 [thread overview]
Message-ID: <c19fcd0b-2004-4c99-8733-937fcfa0769a@broadcom.com> (raw)
In-Reply-To: <CAKR-sGezB_SEb7UfPV6o6T2yibkAzNSqK9Hry1kNM46BMsH2_g@mail.gmail.com>
On 5/11/2025 11:42 AM, Álvaro Fernández Rojas wrote:
> Hi David,
>
> I've just realized that your exec_op implementation patch broke
> support of v2.1, v2.2 and v4.0 controllers.
> https://github.com/torvalds/linux/commit/3c8260ce76634291aed877032a41e373884d69e4
> https://patchwork.ozlabs.org/project/linux-mtd/patch/20231125012438.15191-4-dregan@broadcom.com/
> I know it's an old patch from 6.8 but I just discovered this while
> trying to add 6.12 support for bmips on OpenWrt (from 6.6):
> https://github.com/openwrt/openwrt/pull/18746
>
> The issue is that low level ops always return 0 on v4.0 controllers
> and v2.1/v2.2 controllers don't even have the low level registers
> defined:
> https://github.com/torvalds/linux/blob/3ce9925823c7d6bb0e6eb951bf2db0e9e182582d/drivers/mtd/nand/raw/brcmnand/brcmnand.c#L357
> https://github.com/torvalds/linux/blob/3ce9925823c7d6bb0e6eb951bf2db0e9e182582d/drivers/mtd/nand/raw/brcmnand/brcmnand.c#L371
>
> I guess that restoring the legacy functions isn't going to happen, but
> is it possible to restore < v5.0 compatibility on the new exec_op
> implementation?
Unfortunately, I don't think we have any other choice unless we want to
have a functional NAND driver for these older chips. Would you be
willing to do that? Thanks
--
Florian
next prev parent reply other threads:[~2025-05-12 15:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-11 9:42 mtd: rawnand: brcmnand: exec_op patch broke < v5.0 controllers Álvaro Fernández Rojas
2025-05-11 9:42 ` Álvaro Fernández Rojas
2025-05-12 14:38 ` Florian Fainelli [this message]
2025-05-12 14:38 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c19fcd0b-2004-4c99-8733-937fcfa0769a@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=bbrezillon@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=computersforpeace@gmail.com \
--cc=dan.beygelman@broadcom.com \
--cc=dgcbueu@gmail.com \
--cc=dregan@broadcom.com \
--cc=frieder.schrempf@kontron.de \
--cc=jaimeliao.tw@gmail.com \
--cc=jonas.gorski@gmail.com \
--cc=kdasu.kdev@gmail.com \
--cc=kilobyte@angband.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=noltari@gmail.com \
--cc=rafal@milecki.pl \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
--cc=william.zhang@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.