All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: dan.carpenter@oracle.com, robh@kernel.org, will@kernel.org,
	 kbuild@lists.01.org, lkp@intel.com, kbuild-all@lists.01.org,
	 linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,  bauerman@linux.ibm.com,
	qiuguorui1@huawei.com
Subject: Re: [PATCH] arm64: kexec: Fix missing error code 'ret' warning in load_other_segments()
Date: Thu, 09 Dec 2021 08:32:59 -0800	[thread overview]
Message-ID: <c287f9be2a6e28da0f1342991afa94ffbcb190c4.camel@linux.microsoft.com> (raw)
In-Reply-To: <YbHHhRnpR/EtSV3f@arm.com>

Hi Catalin,

On Thu, 2021-12-09 at 09:08 +0000, Catalin Marinas wrote:
> On Wed, Dec 08, 2021 at 04:45:22PM -0800, Lakshmi Ramasubramanian
> wrote:
> > 
> > Set return code to -ENOMEM if of_kexec_alloc_and_setup_fdt()
> > returns
> > NULL dtb.
> > 
> > 
> > @@ -149,6 +149,7 @@ int load_other_segments(struct kimage *image,
> >  					   initrd_len, cmdline, 0);
> >  	if (!dtb) {
> >  		pr_err("Preparing for new dtb failed\n");
> > +		ret = -ENOMEM;
> >  		goto out_err;
> >  	}
> 
> Above the 'if' block we have:
> 
> 	dtb = of_kexec_alloc_and_setup_fdt(image, initrd_load_addr,
> 					   initrd_len, cmdline, 0);
> 
> Looking at this function, it has several ways to fail, not just on
> allocation. However, we assume above that it's always -ENOMEM. We
> could
> do like powerpc and use -EINVAL as more likely than allocation
> failure
> or change of_kexec_alloc_and_setup_fdt() to return ERR_PTR() and we
> use
> that. The latter would be my preferred option, though it probably
> doesn't matter much. The second best would be -EINVAL.

I'll change the error code to -EINVAL and post an updated patch.

thanks,
 -lakshmi



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] arm64: kexec: Fix missing error code 'ret' warning in load_other_segments()
Date: Thu, 09 Dec 2021 08:32:59 -0800	[thread overview]
Message-ID: <c287f9be2a6e28da0f1342991afa94ffbcb190c4.camel@linux.microsoft.com> (raw)
In-Reply-To: <YbHHhRnpR/EtSV3f@arm.com>

[-- Attachment #1: Type: text/plain, Size: 1165 bytes --]

Hi Catalin,

On Thu, 2021-12-09 at 09:08 +0000, Catalin Marinas wrote:
> On Wed, Dec 08, 2021 at 04:45:22PM -0800, Lakshmi Ramasubramanian
> wrote:
> > 
> > Set return code to -ENOMEM if of_kexec_alloc_and_setup_fdt()
> > returns
> > NULL dtb.
> > 
> > 
> > @@ -149,6 +149,7 @@ int load_other_segments(struct kimage *image,
> >  					   initrd_len, cmdline, 0);
> >  	if (!dtb) {
> >  		pr_err("Preparing for new dtb failed\n");
> > +		ret = -ENOMEM;
> >  		goto out_err;
> >  	}
> 
> Above the 'if' block we have:
> 
> 	dtb = of_kexec_alloc_and_setup_fdt(image, initrd_load_addr,
> 					   initrd_len, cmdline, 0);
> 
> Looking at this function, it has several ways to fail, not just on
> allocation. However, we assume above that it's always -ENOMEM. We
> could
> do like powerpc and use -EINVAL as more likely than allocation
> failure
> or change of_kexec_alloc_and_setup_fdt() to return ERR_PTR() and we
> use
> that. The latter would be my preferred option, though it probably
> doesn't matter much. The second best would be -EINVAL.

I'll change the error code to -EINVAL and post an updated patch.

thanks,
 -lakshmi


WARNING: multiple messages have this Message-ID (diff)
From: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: dan.carpenter@oracle.com, robh@kernel.org, will@kernel.org,
	kbuild@lists.01.org, lkp@intel.com, kbuild-all@lists.01.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, bauerman@linux.ibm.com,
	qiuguorui1@huawei.com
Subject: Re: [PATCH] arm64: kexec: Fix missing error code 'ret' warning in load_other_segments()
Date: Thu, 09 Dec 2021 08:32:59 -0800	[thread overview]
Message-ID: <c287f9be2a6e28da0f1342991afa94ffbcb190c4.camel@linux.microsoft.com> (raw)
In-Reply-To: <YbHHhRnpR/EtSV3f@arm.com>

Hi Catalin,

On Thu, 2021-12-09 at 09:08 +0000, Catalin Marinas wrote:
> On Wed, Dec 08, 2021 at 04:45:22PM -0800, Lakshmi Ramasubramanian
> wrote:
> > 
> > Set return code to -ENOMEM if of_kexec_alloc_and_setup_fdt()
> > returns
> > NULL dtb.
> > 
> > 
> > @@ -149,6 +149,7 @@ int load_other_segments(struct kimage *image,
> >  					   initrd_len, cmdline, 0);
> >  	if (!dtb) {
> >  		pr_err("Preparing for new dtb failed\n");
> > +		ret = -ENOMEM;
> >  		goto out_err;
> >  	}
> 
> Above the 'if' block we have:
> 
> 	dtb = of_kexec_alloc_and_setup_fdt(image, initrd_load_addr,
> 					   initrd_len, cmdline, 0);
> 
> Looking at this function, it has several ways to fail, not just on
> allocation. However, we assume above that it's always -ENOMEM. We
> could
> do like powerpc and use -EINVAL as more likely than allocation
> failure
> or change of_kexec_alloc_and_setup_fdt() to return ERR_PTR() and we
> use
> that. The latter would be my preferred option, though it probably
> doesn't matter much. The second best would be -EINVAL.

I'll change the error code to -EINVAL and post an updated patch.

thanks,
 -lakshmi



  reply	other threads:[~2021-12-09 16:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-09  0:45 [PATCH] arm64: kexec: Fix missing error code 'ret' warning in load_other_segments() Lakshmi Ramasubramanian
2021-12-09  0:45 ` Lakshmi Ramasubramanian
2021-12-09  0:45 ` Lakshmi Ramasubramanian
2021-12-09  9:08 ` Catalin Marinas
2021-12-09  9:08   ` Catalin Marinas
2021-12-09  9:08   ` Catalin Marinas
2021-12-09 16:32   ` Lakshmi Ramasubramanian [this message]
2021-12-09 16:32     ` Lakshmi Ramasubramanian
2021-12-09 16:32     ` Lakshmi Ramasubramanian
  -- strict thread matches above, loose matches on Subject: below --
2021-12-10  1:01 Lakshmi Ramasubramanian
2021-12-10  1:01 ` Lakshmi Ramasubramanian
2021-12-10  1:01 ` Lakshmi Ramasubramanian
2021-12-13 16:42 ` Will Deacon
2021-12-13 16:42   ` Will Deacon
2021-12-13 16:42   ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c287f9be2a6e28da0f1342991afa94ffbcb190c4.camel@linux.microsoft.com \
    --to=nramas@linux.microsoft.com \
    --cc=bauerman@linux.ibm.com \
    --cc=catalin.marinas@arm.com \
    --cc=dan.carpenter@oracle.com \
    --cc=kbuild-all@lists.01.org \
    --cc=kbuild@lists.01.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=qiuguorui1@huawei.com \
    --cc=robh@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.