From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-cris-kernel@axis.com,
Alexander Sverdlin <alexander.sverdlin@gmail.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Gregory Clement <gregory.clement@free-electrons.com>,
Jesper Nilsson <jesper.nilsson@axis.com>,
Krzysztof Halasa <khalasa@piap.pl>,
Mikael Starvik <starvik@axis.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Shawn Guo <shawnguo@kernel.org>, Tony Lindgren <tony@atomide.com>,
Vladimir Zapolskiy <vz@mleia.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 2/5] cris: nand: Improve a size determination in crisv32_nand_flash_probe()
Date: Wed, 04 Oct 2017 18:46:15 +0000 [thread overview]
Message-ID: <c2a6e5a5-0120-d16f-d809-8d5a67fba413@users.sourceforge.net> (raw)
In-Reply-To: <cd84411c-d202-70d6-dec2-c02bedaf3594@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 4 Oct 2017 18:00:33 +0200
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
arch/cris/arch-v32/drivers/mach-a3/nandflash.c | 2 +-
arch/cris/arch-v32/drivers/mach-fs/nandflash.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/cris/arch-v32/drivers/mach-a3/nandflash.c b/arch/cris/arch-v32/drivers/mach-a3/nandflash.c
index 259aa1f46fbe..3b5be9b984b4 100644
--- a/arch/cris/arch-v32/drivers/mach-a3/nandflash.c
+++ b/arch/cris/arch-v32/drivers/mach-a3/nandflash.c
@@ -134,7 +134,7 @@ struct mtd_info *__init crisv32_nand_flash_probe(void)
REG_WR(pio, regi_pio, rw_oe, oe);
/* Allocate memory for MTD device structure and private data */
- wrapper = kzalloc(sizeof(struct mtd_info_wrapper), GFP_KERNEL);
+ wrapper = kzalloc(sizeof(*wrapper), GFP_KERNEL);
if (!wrapper) {
err = -ENOMEM;
return NULL;
diff --git a/arch/cris/arch-v32/drivers/mach-fs/nandflash.c b/arch/cris/arch-v32/drivers/mach-fs/nandflash.c
index 1baf16ee74e8..5dfd72a89b8a 100644
--- a/arch/cris/arch-v32/drivers/mach-fs/nandflash.c
+++ b/arch/cris/arch-v32/drivers/mach-fs/nandflash.c
@@ -109,7 +109,7 @@ struct mtd_info *__init crisv32_nand_flash_probe(void)
int err = 0;
/* Allocate memory for MTD device structure and private data */
- wrapper = kzalloc(sizeof(struct mtd_info_wrapper), GFP_KERNEL);
+ wrapper = kzalloc(sizeof(*wrapper), GFP_KERNEL);
if (!wrapper) {
err = -ENOMEM;
return NULL;
--
2.14.2
WARNING: multiple messages have this Message-ID (diff)
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-cris-kernel@axis.com,
Alexander Sverdlin <alexander.sverdlin@gmail.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Gregory Clement <gregory.clement@free-electrons.com>,
Jesper Nilsson <jesper.nilsson@axis.com>,
Krzysztof Halasa <khalasa@piap.pl>,
Mikael Starvik <starvik@axis.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Shawn Guo <shawnguo@kernel.org>, Tony Lindgren <tony@atomide.com>,
Vladimir Zapolskiy <vz@mleia.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 2/5] cris: nand: Improve a size determination in crisv32_nand_flash_probe()
Date: Wed, 4 Oct 2017 20:46:15 +0200 [thread overview]
Message-ID: <c2a6e5a5-0120-d16f-d809-8d5a67fba413@users.sourceforge.net> (raw)
In-Reply-To: <cd84411c-d202-70d6-dec2-c02bedaf3594@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 4 Oct 2017 18:00:33 +0200
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
arch/cris/arch-v32/drivers/mach-a3/nandflash.c | 2 +-
arch/cris/arch-v32/drivers/mach-fs/nandflash.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/cris/arch-v32/drivers/mach-a3/nandflash.c b/arch/cris/arch-v32/drivers/mach-a3/nandflash.c
index 259aa1f46fbe..3b5be9b984b4 100644
--- a/arch/cris/arch-v32/drivers/mach-a3/nandflash.c
+++ b/arch/cris/arch-v32/drivers/mach-a3/nandflash.c
@@ -134,7 +134,7 @@ struct mtd_info *__init crisv32_nand_flash_probe(void)
REG_WR(pio, regi_pio, rw_oe, oe);
/* Allocate memory for MTD device structure and private data */
- wrapper = kzalloc(sizeof(struct mtd_info_wrapper), GFP_KERNEL);
+ wrapper = kzalloc(sizeof(*wrapper), GFP_KERNEL);
if (!wrapper) {
err = -ENOMEM;
return NULL;
diff --git a/arch/cris/arch-v32/drivers/mach-fs/nandflash.c b/arch/cris/arch-v32/drivers/mach-fs/nandflash.c
index 1baf16ee74e8..5dfd72a89b8a 100644
--- a/arch/cris/arch-v32/drivers/mach-fs/nandflash.c
+++ b/arch/cris/arch-v32/drivers/mach-fs/nandflash.c
@@ -109,7 +109,7 @@ struct mtd_info *__init crisv32_nand_flash_probe(void)
int err = 0;
/* Allocate memory for MTD device structure and private data */
- wrapper = kzalloc(sizeof(struct mtd_info_wrapper), GFP_KERNEL);
+ wrapper = kzalloc(sizeof(*wrapper), GFP_KERNEL);
if (!wrapper) {
err = -ENOMEM;
return NULL;
--
2.14.2
next prev parent reply other threads:[~2017-10-04 18:46 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 18:43 [PATCH 0/5] CRIS v32: Adjustments for crisv32_nand_flash_probe() SF Markus Elfring
2017-10-04 18:43 ` SF Markus Elfring
2017-10-04 18:45 ` [PATCH 1/5] cris: nand: Delete an error message for a failed memory allocation in crisv32_nand_flash SF Markus Elfring
2017-10-04 18:45 ` [PATCH 1/5] cris: nand: Delete an error message for a failed memory allocation in crisv32_nand_flash_probe() SF Markus Elfring
2017-10-04 19:44 ` [PATCH 1/5] cris: nand: Delete an error message for a failed memory allocation in crisv32_nand_f Alexander Sverdlin
2017-10-04 19:44 ` [PATCH 1/5] cris: nand: Delete an error message for a failed memory allocation in crisv32_nand_flash_probe() Alexander Sverdlin
2017-10-04 19:55 ` SF Markus Elfring
2017-10-04 19:55 ` SF Markus Elfring
2017-10-04 20:12 ` [PATCH 1/5] cris: nand: Delete an error message for a failed memory allocation in crisv32_nand_f Julia Lawall
2017-10-04 20:12 ` [PATCH 1/5] cris: nand: Delete an error message for a failed memory allocation in crisv32_nand_flash_probe() Julia Lawall
2017-10-04 20:16 ` [PATCH 1/5] cris: nand: Delete an error message for a failed memory allocation in crisv32_nand_f Alexander Sverdlin
2017-10-04 20:16 ` [PATCH 1/5] cris: nand: Delete an error message for a failed memory allocation in crisv32_nand_flash_probe() Alexander Sverdlin
2017-10-04 18:46 ` SF Markus Elfring [this message]
2017-10-04 18:46 ` [PATCH 2/5] cris: nand: Improve a size determination " SF Markus Elfring
2017-10-04 18:47 ` [PATCH 3/5] cris: nand: Delete a jump target " SF Markus Elfring
2017-10-04 18:47 ` SF Markus Elfring
2017-10-04 18:48 ` [PATCH 4/5] cris: nand: Delete an unnecessary local variable " SF Markus Elfring
2017-10-04 18:48 ` SF Markus Elfring
2017-10-04 20:17 ` Alexander Sverdlin
2017-10-04 20:17 ` Alexander Sverdlin
2017-10-04 18:50 ` [PATCH 5/5] cris: nand: Split a condition check " SF Markus Elfring
2017-10-04 18:50 ` SF Markus Elfring
2017-10-04 20:26 ` Alexander Sverdlin
2017-10-05 15:31 ` [PATCH 0/5] CRIS v32: Adjustments for crisv32_nand_flash_probe() Gregory CLEMENT
2017-10-05 15:31 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2a6e5a5-0120-d16f-d809-8d5a67fba413@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=alexander.sverdlin@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=gregory.clement@free-electrons.com \
--cc=jesper.nilsson@axis.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=khalasa@piap.pl \
--cc=linux-cris-kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=shawnguo@kernel.org \
--cc=starvik@axis.com \
--cc=tony@atomide.com \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.