All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Chunhai Guo <guochunhai@vivo.com>, xiang@kernel.org, chao@kernel.org
Cc: huyue2@coolpad.com, linux-erofs@lists.ozlabs.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] erofs: avoid unnecessary loops in z_erofs_pcluster_readmore() when read page beyond EOF
Date: Mon, 10 Jul 2023 18:41:17 +0800	[thread overview]
Message-ID: <c3b60fb9-8a63-b1f6-059e-aeeabf6ba913@linux.alibaba.com> (raw)
In-Reply-To: <20230710042531.28761-1-guochunhai@vivo.com>



On 2023/7/10 12:25, Chunhai Guo wrote:
> z_erofs_pcluster_readmore() may take a long time to loop when the page
> offset is large enough, which is unnecessary should be prevented.
> For example, when the following case is encountered, it will loop 4691368
> times, taking about 27 seconds.
>      - offset = 19217289215
>      - inode_size = 1442672
> 
> Signed-off-by: Chunhai Guo <guochunhai@vivo.com>

I will update the subject manually to:
"erofs: avoid useless loops in z_erofs_pcluster_readmore() when reading beyond EOF"

to avoid overly long subject as well...

Thanks,
Gao Xiang

WARNING: multiple messages have this Message-ID (diff)
From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Chunhai Guo <guochunhai@vivo.com>, xiang@kernel.org, chao@kernel.org
Cc: huyue2@coolpad.com, jefflexu@linux.alibaba.com,
	linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] erofs: avoid unnecessary loops in z_erofs_pcluster_readmore() when read page beyond EOF
Date: Mon, 10 Jul 2023 18:41:17 +0800	[thread overview]
Message-ID: <c3b60fb9-8a63-b1f6-059e-aeeabf6ba913@linux.alibaba.com> (raw)
In-Reply-To: <20230710042531.28761-1-guochunhai@vivo.com>



On 2023/7/10 12:25, Chunhai Guo wrote:
> z_erofs_pcluster_readmore() may take a long time to loop when the page
> offset is large enough, which is unnecessary should be prevented.
> For example, when the following case is encountered, it will loop 4691368
> times, taking about 27 seconds.
>      - offset = 19217289215
>      - inode_size = 1442672
> 
> Signed-off-by: Chunhai Guo <guochunhai@vivo.com>

I will update the subject manually to:
"erofs: avoid useless loops in z_erofs_pcluster_readmore() when reading beyond EOF"

to avoid overly long subject as well...

Thanks,
Gao Xiang

  parent reply	other threads:[~2023-07-10 10:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-10  4:25 [PATCH] erofs: avoid unnecessary loops in z_erofs_pcluster_readmore() when read page beyond EOF Chunhai Guo
2023-07-10  4:25 ` Chunhai Guo
2023-07-10  4:40 ` Gao Xiang
2023-07-10  4:40   ` Gao Xiang
2023-07-10  7:48 ` Yue Hu
2023-07-10  7:48   ` Yue Hu
2023-07-10 10:41 ` Gao Xiang [this message]
2023-07-10 10:41   ` Gao Xiang
2023-07-11 13:56 ` Chao Yu
2023-07-11 13:56   ` Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c3b60fb9-8a63-b1f6-059e-aeeabf6ba913@linux.alibaba.com \
    --to=hsiangkao@linux.alibaba.com \
    --cc=chao@kernel.org \
    --cc=guochunhai@vivo.com \
    --cc=huyue2@coolpad.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xiang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.