From: Timur Tabi <timur@codeaurora.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
thierry.reding@gmail.com, Stephen Boyd <sboyd@codeaurora.org>,
david.brown@linaro.org, andy.gross@linaro.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Varadarajan Narayanan <varada@codeaurora.org>,
Archit Taneja <architt@codeaurora.org>
Subject: Re: [PATCH 4/4] [v4] pinctrl: qcom: qdf2xxx: add support for new ACPI HID QCOM8002
Date: Wed, 13 Dec 2017 09:18:49 -0600 [thread overview]
Message-ID: <c41db747-757a-131f-14b6-e181403db007@codeaurora.org> (raw)
In-Reply-To: <9c28bebb-5f57-83e8-9885-5262bbdc1b94@codeaurora.org>
On 12/13/2017 08:46 AM, Timur Tabi wrote:
>
>> Please, read my comment again. The key part of the phrase:
>> "Use members of struct device_driver"
>>
>> So, do not move the IDs. There are examples in the kernel how to access
>> it.
>
> Sorry, I don't understand what you're talking about. I don't see how I
> can call
>
> const struct acpi_device_id *id =
> acpi_match_device(qdf2xxx_acpi_ids, &pdev->dev);
>
> without having qdf2xxx_acpi_ids already defined previously. And without
> the 'id', I can't figure out whether I've probed via QCOM8001 or QCOM8002.
I think I found it. Are you talking about doing this instead:
id = acpi_match_device(pdev->dev.driver->acpi_match_table, &pdev->dev);
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
WARNING: multiple messages have this Message-ID (diff)
From: timur@codeaurora.org (Timur Tabi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] [v4] pinctrl: qcom: qdf2xxx: add support for new ACPI HID QCOM8002
Date: Wed, 13 Dec 2017 09:18:49 -0600 [thread overview]
Message-ID: <c41db747-757a-131f-14b6-e181403db007@codeaurora.org> (raw)
In-Reply-To: <9c28bebb-5f57-83e8-9885-5262bbdc1b94@codeaurora.org>
On 12/13/2017 08:46 AM, Timur Tabi wrote:
>
>> Please, read my comment again. The key part of the phrase:
>> "Use members of struct device_driver"
>>
>> So, do not move the IDs. There are examples in the kernel how to access
>> it.
>
> Sorry, I don't understand what you're talking about.? I don't see how I
> can call
>
> ????const struct acpi_device_id *id =
> ??????? acpi_match_device(qdf2xxx_acpi_ids, &pdev->dev);
>
> without having qdf2xxx_acpi_ids already defined previously.? And without
> the 'id', I can't figure out whether I've probed via QCOM8001 or QCOM8002.
I think I found it. Are you talking about doing this instead:
id = acpi_match_device(pdev->dev.driver->acpi_match_table, &pdev->dev);
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2017-12-13 15:18 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 23:28 [PATCH 0/4] [v8] pinctrl: qcom: add support for sparse GPIOs Timur Tabi
2017-12-01 23:28 ` Timur Tabi
2017-12-01 23:28 ` [PATCH 1/4] [v2] Revert "gpio: set up initial state from .get_direction()" Timur Tabi
2017-12-01 23:28 ` Timur Tabi
2017-12-01 23:28 ` [PATCH 2/4] [v2] gpiolib: add bitmask for valid GPIO lines Timur Tabi
2017-12-01 23:28 ` Timur Tabi
2017-12-12 9:58 ` Andy Shevchenko
2017-12-12 9:58 ` Andy Shevchenko
2017-12-12 20:16 ` Timur Tabi
2017-12-12 20:16 ` Timur Tabi
2017-12-01 23:28 ` [PATCH 3/4] [v7] pinctrl: qcom: disable GPIO groups with no pins Timur Tabi
2017-12-01 23:28 ` Timur Tabi
2017-12-01 23:28 ` [PATCH 4/4] [v4] pinctrl: qcom: qdf2xxx: add support for new ACPI HID QCOM8002 Timur Tabi
2017-12-01 23:28 ` Timur Tabi
2017-12-12 10:05 ` Andy Shevchenko
2017-12-12 10:05 ` Andy Shevchenko
2017-12-12 20:17 ` Timur Tabi
2017-12-12 20:17 ` Timur Tabi
2017-12-13 14:32 ` Andy Shevchenko
2017-12-13 14:32 ` Andy Shevchenko
2017-12-13 14:46 ` Timur Tabi
2017-12-13 14:46 ` Timur Tabi
2017-12-13 15:18 ` Timur Tabi [this message]
2017-12-13 15:18 ` Timur Tabi
2017-12-13 15:40 ` Andy Shevchenko
2017-12-13 15:40 ` Andy Shevchenko
[not found] ` <1512170904-4749-5-git-send-email-timur-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-12-12 10:42 ` Linus Walleij
2017-12-12 10:42 ` Linus Walleij
2017-12-12 11:07 ` Andy Shevchenko
2017-12-12 11:07 ` Andy Shevchenko
2017-12-12 20:27 ` Timur Tabi
2017-12-12 20:27 ` Timur Tabi
2017-12-13 14:36 ` Andy Shevchenko
2017-12-13 14:36 ` Andy Shevchenko
2017-12-13 14:47 ` Timur Tabi
2017-12-13 14:47 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c41db747-757a-131f-14b6-e181403db007@codeaurora.org \
--to=timur@codeaurora.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.gross@linaro.org \
--cc=architt@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=sboyd@codeaurora.org \
--cc=thierry.reding@gmail.com \
--cc=varada@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.