From: Jason Wang <jasowang@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Alexey Kardashevskiy <aik@ozlabs.ru>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH qemu v2] tap: Allow specifying a bridge
Date: Thu, 22 Sep 2016 15:05:17 +0800 [thread overview]
Message-ID: <c4a4cd5c-231b-4b05-c2a3-9e268dd01368@redhat.com> (raw)
In-Reply-To: <81194f18-3bc8-a134-5b32-84690f2d9863@redhat.com>
On 2016年09月19日 19:59, Paolo Bonzini wrote:
>
> On 19/09/2016 02:33, Alexey Kardashevskiy wrote:
>> On 15/09/16 07:04, Paolo Bonzini wrote:
>>>
>>> On 13/09/2016 09:11, Alexey Kardashevskiy wrote:
>>>> The tap backend is already using qemu-bridge-helper to attach tap
>>>> interface to a bridge but (unlike the bridge backend) it always uses
>>>> the default bridge name - br0.
>>>>
>>>> This adds a "br" property support to the tap backend.
>>>>
>>>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>>> Stupid question ahead: how does -netdev bridge compare to -netdev tap
>>> after this patch? Is there a case left where you must use -netdev bridge?
>>>
>>> Or can we make -netdev bridge a synonym for "-netdev
>>> tap,helper=/default/path/to/helper"?
>> I looked through history but I could not understand why "bridge" was
>> introduced in the first place as even there (a7c36ee4920ea) is an example of
>>
>> -netdev tap,helper="/usr/local/libexec/qemu-bridge-helper --br=qemubr0",id=hn0
>>
>> so it was assumed even then that people might want tap on a specific bridge.
>>
>> So my stupid question is - what do I have to do to get this accepted
>> (besides a note that it is 2.8+) or it is not interesting to anyone? :)
> I think the patch is even more interesting because it lets us simplify
> the code for -netdev bridge.
>
> Paolo
>
According to http://wiki.qemu.org/Features-Done/HelperNetworking. Looks
like this allows creating a third party backend without modifying qemu.
And the bridge helper is an example for this.
prev parent reply other threads:[~2016-09-22 7:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 7:11 [Qemu-devel] [PATCH qemu v2] tap: Allow specifying a bridge Alexey Kardashevskiy
2016-09-13 14:49 ` Eric Blake
2016-09-13 15:39 ` Greg Kurz
2016-09-14 4:23 ` Alexey Kardashevskiy
2016-09-14 13:54 ` Eric Blake
2016-09-14 14:17 ` Greg Kurz
2016-09-14 15:12 ` Eric Blake
2016-09-22 7:03 ` Jason Wang
2016-09-14 21:04 ` Paolo Bonzini
2016-09-19 0:33 ` Alexey Kardashevskiy
2016-09-19 11:59 ` Paolo Bonzini
2016-09-22 7:05 ` Jason Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4a4cd5c-231b-4b05-c2a3-9e268dd01368@redhat.com \
--to=jasowang@redhat.com \
--cc=aik@ozlabs.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.