Re: [Qemu-devel] [PATCH qemu v2] tap: Allow specifying a bridge

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 997 bytes --]

On 09/14/2016 09:17 AM, Greg Kurz wrote:
> On Tue, 13 Sep 2016 17:11:54 +1000
> Alexey Kardashevskiy <aik@ozlabs.ru> wrote:
> 
>> The tap backend is already using qemu-bridge-helper to attach tap
>> interface to a bridge but (unlike the bridge backend) it always uses
>> the default bridge name - br0.
>>
>> This adds a "br" property support to the tap backend.
>>
>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>> --
> 
> Cool ! This allows to easily attach to virbr0 :)
> 
> Now that a consensus seems to have been reached for @br:

Yes, but there was still my other comment that:


>> +++ b/qapi-schema.json
>> @@ -2575,6 +2575,8 @@
>>  #
>>  # @downscript: #optional script to shut down the interface
>>  #
>> +# @br: #optional bridge name

this is missing a '(since 2.8)' designator.  Perhaps the maintainer can
supply it without needing a v3.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]