From: Andrew Lunn <andrew@lunn.ch>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [net-next,v2] net: ethernet: rtsn: Add support for Renesas Ethernet-TSN
Date: Wed, 8 May 2024 19:36:17 +0200 [thread overview]
Message-ID: <c4c84b76-ac3b-4f5f-ae4e-4712dede8dc2@lunn.ch> (raw)
In-Reply-To: <CAMuHMdWQNQWtofKqAcdWurk5eV+gKaG3b-pWNd+Fjpg89BLkWA@mail.gmail.com>
> While explicit clock management works, please use pm_runtime_*()
> instead, as the device is part of a Clock Domain. Also, the TSN
> block may be reused on a different SoC, where it is part of a real
> power domain, and manual clock management won't be sufficient.
Please document this in the commit message. It was not obvious to me
at least that pm_runtime without callbacks can effect clocks.
Andrew
prev parent reply other threads:[~2024-05-08 17:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 20:18 [net-next,v2] net: ethernet: rtsn: Add support for Renesas Ethernet-TSN Niklas Söderlund
2024-05-07 20:57 ` Andrew Lunn
2024-05-07 21:50 ` Niklas Söderlund
2024-05-08 0:35 ` Andrew Lunn
2024-05-08 11:07 ` Niklas Söderlund
2024-05-08 0:52 ` Andrew Lunn
2024-05-08 11:03 ` Niklas Söderlund
2024-05-08 0:55 ` Andrew Lunn
2024-05-08 10:58 ` Niklas Söderlund
2024-05-08 12:33 ` Andrew Lunn
2024-05-08 12:55 ` Niklas Söderlund
2024-05-08 14:00 ` Andrew Lunn
2024-05-08 15:10 ` Niklas Söderlund
2024-05-08 15:29 ` Geert Uytterhoeven
2024-05-08 17:36 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4c84b76-ac3b-4f5f-ae4e-4712dede8dc2@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geert@linux-m68k.org \
--cc=kuba@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=pabeni@redhat.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.