All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Colp <Patrick.Colp@citrix.com>
To: xen-devel@lists.xensource.com
Subject: [PATCH] Fix get_page_from_l1e and cleanup_page_cacheattr to use PGC_cacheattr_mask
Date: Fri, 15 May 2009 10:01:04 +0100	[thread overview]
Message-ID: <c5098f5c5caf4174bd2e.1242378064@waitaha> (raw)

# HG changeset patch
# User Patrick Colp <Patrick.Colp@citrix.com>
# Date 1242295647 -3600
# Node ID c5098f5c5caf4174bd2e46d49d7b65109203f7c5
# Parent  2522cc95efd2f3fadf7342d18fe86e8f37f89c2a
Fix get_page_from_l1e and cleanup_page_cacheattr to use PGC_cacheattr_mask.

Signed-off-by: Patrick Colp <Patrick.Colp@citrix.com>

diff -r 2522cc95efd2 -r c5098f5c5caf xen/arch/x86/mm.c
--- a/xen/arch/x86/mm.c	Mon May 11 13:52:04 2009 +0100
+++ b/xen/arch/x86/mm.c	Thu May 14 11:07:27 2009 +0100
@@ -766,7 +766,7 @@
         goto could_not_pin;
 
     if ( pte_flags_to_cacheattr(l1f) !=
-         ((page->count_info >> PGC_cacheattr_base) & 7) )
+         ((page->count_info & PGC_cacheattr_mask) >> PGC_cacheattr_base) )
     {
         unsigned long x, nx, y = page->count_info;
         unsigned long cacheattr = pte_flags_to_cacheattr(l1f);
@@ -782,7 +782,7 @@
             return 0;
         }
 
-        while ( ((y >> PGC_cacheattr_base) & 7) != cacheattr )
+        while ( ((y & PGC_cacheattr_mask) >> PGC_cacheattr_base) != cacheattr )
         {
             x  = y;
             nx = (x & ~PGC_cacheattr_mask) | (cacheattr << PGC_cacheattr_base);
@@ -2389,7 +2389,8 @@
 
 void cleanup_page_cacheattr(struct page_info *page)
 {
-    uint32_t cacheattr = (page->count_info >> PGC_cacheattr_base) & 7;
+    uint32_t cacheattr =
+        (page->count_info & PGC_cacheattr_mask) >> PGC_cacheattr_base;
 
     if ( likely(cacheattr == 0) )
         return;

             reply	other threads:[~2009-05-15  9:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-15  9:01 Patrick Colp [this message]
2009-05-15  9:31 ` [PATCH] Fix get_page_from_l1e andcleanup_page_cacheattr to use PGC_cacheattr_mask Jan Beulich
2009-05-15  9:40   ` Keir Fraser
2009-05-15  9:40     ` Patrick Colp
2009-05-15  9:54     ` [PATCH] Fix get_page_from_l1eandcleanup_page_cacheattr " Jan Beulich
2009-05-15  9:56       ` Patrick Colp
  -- strict thread matches above, loose matches on Subject: below --
2009-05-15  8:37 [PATCH] Fix get_page_from_l1e and cleanup_page_cacheattr " Patrick Colp
2009-05-15  8:09 Patrick Colp
2009-05-14 10:12 Patrick Colp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c5098f5c5caf4174bd2e.1242378064@waitaha \
    --to=patrick.colp@citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.