From: Patrick Colp <Patrick.Colp@citrix.com>
To: Jan Beulich <JBeulich@novell.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Keir Fraser <Keir.Fraser@eu.citrix.com>
Subject: Re: [PATCH] Fix get_page_from_l1eandcleanup_page_cacheattr to use PGC_cacheattr_mask
Date: Fri, 15 May 2009 10:56:34 +0100 [thread overview]
Message-ID: <4A0D3C52.4090700@citrix.com> (raw)
In-Reply-To: <4A0D57F50200007800001153@vpn.id2.novell.com>
Jan Beulich wrote:
>>>> Keir Fraser <keir.fraser@eu.citrix.com> 15.05.09 11:40 >>>
>> On 15/05/2009 10:31, "Jan Beulich" <JBeulich@novell.com> wrote:
>>
>>>>>> Patrick Colp <Patrick.Colp@citrix.com> 15.05.09 11:01 >>>
>>>> # HG changeset patch
>>>> # User Patrick Colp <Patrick.Colp@citrix.com>
>>>> # Date 1242295647 -3600
>>>> # Node ID c5098f5c5caf4174bd2e46d49d7b65109203f7c5
>>>> # Parent 2522cc95efd2f3fadf7342d18fe86e8f37f89c2a
>>>> Fix get_page_from_l1e and cleanup_page_cacheattr to use PGC_cacheattr_mask.
>>> Could you indicate what it is that you fix here?
>> I assume it's just getting rid of the open-coded 7.
>
> So would I have thought by looking at the patch, but the word 'fix' in the subject
> made me thing there was something more subtle that I didn't spot...
>
> Jan
Nah, just a poor word choice. "Changed" would probably have been better.
Patrick
prev parent reply other threads:[~2009-05-15 9:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-15 9:01 [PATCH] Fix get_page_from_l1e and cleanup_page_cacheattr to use PGC_cacheattr_mask Patrick Colp
2009-05-15 9:31 ` [PATCH] Fix get_page_from_l1e andcleanup_page_cacheattr " Jan Beulich
2009-05-15 9:40 ` Keir Fraser
2009-05-15 9:40 ` Patrick Colp
2009-05-15 9:54 ` [PATCH] Fix get_page_from_l1eandcleanup_page_cacheattr " Jan Beulich
2009-05-15 9:56 ` Patrick Colp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A0D3C52.4090700@citrix.com \
--to=patrick.colp@citrix.com \
--cc=JBeulich@novell.com \
--cc=Keir.Fraser@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.