From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Daniel Vetter <daniel.vetter@ffwll.ch>,
stable@kernel.org
Subject: Re: [PATCH 2/2] drm/i915: properly clflush pwrites to phys objects
Date: Tue, 29 Nov 2011 15:35:54 +0000 [thread overview]
Message-ID: <c55c5d$185nps@AZSMGA002.ch.intel.com> (raw)
In-Reply-To: <1322579369-26954-2-git-send-email-daniel.vetter@ffwll.ch>
On Tue, 29 Nov 2011 16:09:29 +0100, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Usually results in (rare) cursor corruptions on platforms
> requiring physically addressed cursors.
So the phys cursor pages are set to WC upon creation, are we just
missing the mb()? Or more likely the CPUs don't have PAT and we are
being lazy in not detecting the error.
Anyway as this is reported to fix the issue on 8xx at least, overkill
is fine. :)
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
WARNING: multiple messages have this Message-ID (diff)
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Daniel Vetter <daniel.vetter@ffwll.ch>,
stable@kernel.org
Subject: Re: [PATCH 2/2] drm/i915: properly clflush pwrites to phys objects
Date: Tue, 29 Nov 2011 15:35:54 +0000 [thread overview]
Message-ID: <c55c5d$185nps@AZSMGA002.ch.intel.com> (raw)
In-Reply-To: <1322579369-26954-2-git-send-email-daniel.vetter@ffwll.ch>
On Tue, 29 Nov 2011 16:09:29 +0100, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Usually results in (rare) cursor corruptions on platforms
> requiring physically addressed cursors.
So the phys cursor pages are set to WC upon creation, are we just
missing the mb()? Or more likely the CPUs don't have PAT and we are
being lazy in not detecting the error.
Anyway as this is reported to fix the issue on 8xx at least, overkill
is fine. :)
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-11-29 15:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 15:09 [PATCH 1/2] drm: add helper to clflush a virtual address range Daniel Vetter
2011-11-29 15:09 ` Daniel Vetter
2011-11-29 15:09 ` [PATCH 2/2] drm/i915: properly clflush pwrites to phys objects Daniel Vetter
2011-11-29 15:35 ` Chris Wilson [this message]
2011-11-29 15:35 ` Chris Wilson
2011-11-29 16:16 ` Daniel Vetter
2011-11-29 17:22 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='c55c5d$185nps@AZSMGA002.ch.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.