Re: [PATCH 2/2] drm/i915: don't always force the panel's fixed_mode

[Chris Wilson <chris@chris-wilson.co.uk>]

On Wed, 8 Feb 2012 23:53:10 +0100, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Fri, Feb 03, 2012 at 05:48:21PM -0200, Paulo Zanoni wrote:
> > From: Paulo Zanoni <paulo.r.zanoni@intel.com>
> > 
> > My laptop has two 1440x900 modes: one is the fixed_mode and the other
> > has different timings. If I use xrandr to switch from the fixed mode to
> > the "other" 1440x900 mode, xrandr will tell me the change was
> > successful, but nothing was actually done: I'm still using the
> > fixed_mode. This patch allows us to use other modes if hdisplay and
> > vdisplay are the same.
> > 
> > Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> 
> Hm, I've thought we should only use this to dynamically switch between a
> mode with high refresh rate and one with a low one.

I hesitated for the same reason. Except that by filtering out all modes
except for the one true mode, we prevent the user from being able to
make a choice. They'll invariably make the wrong choice and file a bug,
but nevertheless... ;-)

I also don't think this is the way we want to approach this. The overrides
required for fake LVDS headers would seem to be a superset of this
functionality.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre