Re: [PATCH v2 3/4] dt-bindings: PCI: Add UltraRISC DP1000 PCIe controller

From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jia Wang <wangjia@ultrarisc.com>
Cc: "Paul Walmsley" <pjw@kernel.org>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Alexandre Ghiti" <alex@ghiti.fr>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Jingoo Han" <jingoohan1@gmail.com>,
	"Xincheng Zhang" <zhangxincheng@ultrarisc.com>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-pci@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 3/4] dt-bindings: PCI: Add UltraRISC DP1000 PCIe controller
Date: Wed, 8 Apr 2026 08:49:06 +0200	[thread overview]
Message-ID: <c60a712e-ecf3-4926-9947-0e593cdb921d@kernel.org> (raw)
In-Reply-To: <177563059910.3194559.10112671473525736823.b4-reply@b4>

On 08/04/2026 08:43, Jia Wang wrote:
> On 2026-04-08 08:28 +0200, Krzysztof Kozlowski wrote:
>> On 08/04/2026 05:34, Jia Wang wrote:
>>>>> +  max-link-speed:
>>>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>>>> +    const: 4
>>>>
>>>> If const then deducible from the compatible. Drop the property.
>>>>
>>>
>>> Will replace `const: 4` with `maximum: 4` in v3.
>>
>> Why? Wasn't maximum link speed fixed to 4?
>>
> 
> Just to make sure I fully understand: since the maximum link speed is a
> fixed hardware property and is implied by the compatible, we should drop
> the `max-link-speed` property from the binding.
> 
> In that case, should I set `pci->max_link_speed = 4` in the driver during
> probe? I want to make sure this is the correct way to handle it.
>  

Yes

Best regards,
Krzysztof