From: Jens Axboe <axboe@kernel.dk>
To: Sagi Grimberg <sagi@grimberg.me>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 04/16] blk-mq: pass in request/bio flags to queue mapping
Date: Wed, 31 Oct 2018 08:18:18 -0600 [thread overview]
Message-ID: <c688cb45-eb14-c857-e90a-da6fd93f81b7@kernel.dk> (raw)
In-Reply-To: <50a9c2d1-abc5-b04f-1f95-878f216a47b1@grimberg.me>
On 10/30/18 6:37 PM, Sagi Grimberg wrote:
>
>> static inline struct blk_mq_hw_ctx *blk_mq_map_queue(struct request_queue *q,
>> + unsigned int flags,
>> unsigned int cpu)
>> {
>> struct blk_mq_tag_set *set = q->tag_set;
>> @@ -84,7 +85,7 @@ static inline struct blk_mq_hw_ctx *blk_mq_map_queue_type(struct request_queue *
>> unsigned int hctx_type,
>> unsigned int cpu)
>> {
>> - return blk_mq_map_queue(q, cpu);
>> + return blk_mq_map_queue(q, hctx_type, cpu);
>> }
>
> Haven't read through the rest of the patch set, but it looks a bit
> strange that a type enumeration is being passed on as flags field.
It's impossible to get it 100% right at this point, which is why
it looks a bit odd. If you read on, it'll make sense.
--
Jens Axboe
WARNING: multiple messages have this Message-ID (diff)
From: axboe@kernel.dk (Jens Axboe)
Subject: [PATCH 04/16] blk-mq: pass in request/bio flags to queue mapping
Date: Wed, 31 Oct 2018 08:18:18 -0600 [thread overview]
Message-ID: <c688cb45-eb14-c857-e90a-da6fd93f81b7@kernel.dk> (raw)
In-Reply-To: <50a9c2d1-abc5-b04f-1f95-878f216a47b1@grimberg.me>
On 10/30/18 6:37 PM, Sagi Grimberg wrote:
>
>> static inline struct blk_mq_hw_ctx *blk_mq_map_queue(struct request_queue *q,
>> + unsigned int flags,
>> unsigned int cpu)
>> {
>> struct blk_mq_tag_set *set = q->tag_set;
>> @@ -84,7 +85,7 @@ static inline struct blk_mq_hw_ctx *blk_mq_map_queue_type(struct request_queue *
>> unsigned int hctx_type,
>> unsigned int cpu)
>> {
>> - return blk_mq_map_queue(q, cpu);
>> + return blk_mq_map_queue(q, hctx_type, cpu);
>> }
>
> Haven't read through the rest of the patch set, but it looks a bit
> strange that a type enumeration is being passed on as flags field.
It's impossible to get it 100% right at this point, which is why
it looks a bit odd. If you read on, it'll make sense.
--
Jens Axboe
next prev parent reply other threads:[~2018-10-31 14:18 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 18:32 [PATCHSET v3 0/16] blk-mq: Add support for multiple queue maps Jens Axboe
2018-10-30 18:32 ` Jens Axboe
2018-10-30 18:32 ` [PATCH 01/16] blk-mq: kill q->mq_map Jens Axboe
2018-10-30 18:32 ` Jens Axboe
2018-10-31 0:28 ` Sagi Grimberg
2018-10-31 0:28 ` Sagi Grimberg
2018-10-30 18:32 ` [PATCH 02/16] blk-mq: abstract out queue map Jens Axboe
2018-10-30 18:32 ` Jens Axboe
2018-10-31 0:31 ` Sagi Grimberg
2018-10-31 0:31 ` Sagi Grimberg
2018-10-31 14:17 ` Jens Axboe
2018-10-31 14:17 ` Jens Axboe
2018-10-30 18:32 ` [PATCH 03/16] blk-mq: provide dummy blk_mq_map_queue_type() helper Jens Axboe
2018-10-30 18:32 ` Jens Axboe
2018-10-31 0:32 ` Sagi Grimberg
2018-10-31 0:32 ` Sagi Grimberg
2018-10-30 18:32 ` [PATCH 04/16] blk-mq: pass in request/bio flags to queue mapping Jens Axboe
2018-10-30 18:32 ` Jens Axboe
2018-10-31 0:37 ` Sagi Grimberg
2018-10-31 0:37 ` Sagi Grimberg
2018-10-31 14:18 ` Jens Axboe [this message]
2018-10-31 14:18 ` Jens Axboe
2018-10-30 18:32 ` [PATCH 05/16] blk-mq: allow software queue to map to multiple hardware queues Jens Axboe
2018-10-30 18:32 ` Jens Axboe
2018-10-31 0:49 ` Sagi Grimberg
2018-10-31 0:49 ` Sagi Grimberg
2018-10-31 14:19 ` Jens Axboe
2018-10-31 14:19 ` Jens Axboe
2018-10-30 18:32 ` [PATCH 06/16] blk-mq: add 'type' attribute to the sysfs hctx directory Jens Axboe
2018-10-30 18:32 ` Jens Axboe
2018-10-31 0:53 ` Sagi Grimberg
2018-10-31 0:53 ` Sagi Grimberg
2018-10-31 14:21 ` Jens Axboe
2018-10-31 14:21 ` Jens Axboe
2018-11-01 21:59 ` Omar Sandoval
2018-11-01 21:59 ` Omar Sandoval
2018-11-01 22:50 ` Jens Axboe
2018-11-01 22:50 ` Jens Axboe
2018-10-30 18:32 ` [PATCH 07/16] blk-mq: support multiple hctx maps Jens Axboe
2018-10-30 18:32 ` Jens Axboe
2018-10-31 0:59 ` Sagi Grimberg
2018-10-31 0:59 ` Sagi Grimberg
2018-10-31 14:23 ` Jens Axboe
2018-10-31 14:23 ` Jens Axboe
2018-10-30 18:32 ` [PATCH 08/16] blk-mq: separate number of hardware queues from nr_cpu_ids Jens Axboe
2018-10-30 18:32 ` Jens Axboe
2018-10-31 1:00 ` Sagi Grimberg
2018-10-31 1:00 ` Sagi Grimberg
2018-10-30 18:32 ` [PATCH 09/16] blk-mq: cache request hardware queue mapping Jens Axboe
2018-10-30 18:32 ` Jens Axboe
2018-10-31 1:01 ` Sagi Grimberg
2018-10-31 1:01 ` Sagi Grimberg
2018-11-01 9:27 ` Hannes Reinecke
2018-11-01 9:27 ` Hannes Reinecke
2018-11-01 12:22 ` Jens Axboe
2018-11-01 12:22 ` Jens Axboe
2018-10-30 18:32 ` [PATCH 10/16] blk-mq: cleanup and improve list insertion Jens Axboe
2018-10-30 18:32 ` Jens Axboe
2018-10-31 1:03 ` Sagi Grimberg
2018-10-31 1:03 ` Sagi Grimberg
2018-11-01 9:28 ` Hannes Reinecke
2018-11-01 9:28 ` Hannes Reinecke
2018-10-30 18:32 ` [PATCH 11/16] blk-mq: improve plug list sorting Jens Axboe
2018-10-30 18:32 ` Jens Axboe
2018-10-31 1:04 ` Sagi Grimberg
2018-10-31 1:04 ` Sagi Grimberg
2018-11-01 9:30 ` Hannes Reinecke
2018-11-01 9:30 ` Hannes Reinecke
2018-10-30 18:32 ` [PATCH 12/16] blk-mq: initial support for multiple queue maps Jens Axboe
2018-10-30 18:32 ` Jens Axboe
2018-10-31 1:14 ` Sagi Grimberg
2018-10-31 1:14 ` Sagi Grimberg
2018-10-30 18:32 ` [PATCH 13/16] irq: add support for allocating (and affinitizing) sets of IRQs Jens Axboe
2018-10-30 18:32 ` Jens Axboe
2018-10-31 1:17 ` Sagi Grimberg
2018-10-31 1:17 ` Sagi Grimberg
2018-11-02 14:37 ` Ming Lei
2018-11-02 14:37 ` Ming Lei
2018-11-02 15:09 ` Keith Busch
2018-11-02 15:09 ` Keith Busch
2018-11-03 2:22 ` Ming Lei
2018-11-03 2:22 ` Ming Lei
2018-10-30 18:32 ` [PATCH 14/16] nvme: utilize two queue maps, one for reads and one for writes Jens Axboe
2018-10-30 18:32 ` Jens Axboe
2018-10-31 1:57 ` Sagi Grimberg
2018-10-31 1:57 ` Sagi Grimberg
2018-10-31 14:32 ` Jens Axboe
2018-10-31 14:32 ` Jens Axboe
2018-10-30 18:32 ` [PATCH 15/16] block: add REQ_HIPRI and inherit it from IOCB_HIPRI Jens Axboe
2018-10-30 18:32 ` Jens Axboe
2018-10-31 1:58 ` Sagi Grimberg
2018-10-31 1:58 ` Sagi Grimberg
2018-10-30 18:32 ` [PATCH 16/16] nvme: add separate poll queue map Jens Axboe
2018-10-30 18:32 ` Jens Axboe
2018-10-30 18:35 ` [PATCHSET v3 0/16] blk-mq: Add support for multiple queue maps Keith Busch
2018-10-30 18:35 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c688cb45-eb14-c857-e90a-da6fd93f81b7@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.