[regression] drm/i915: Simplify most HAS_BSD() checks

[regression] drm/i915: Simplify most HAS_BSD() checks

[Alexey Fisher]

this time double checked ;)

Netbook freeze on suspend. After "echo mem > /sys/power/state" suspend
will be initiated bat freeze with blackscreen and cursor on top left
corner. I can't access it per ssh.

My HW: Eeepc 1005HA, 945GME
intel_stepping
Vendor: 0x8086, Device: 0x27ae, Revision: 0x03 (??)

apt-cache policy xserver-xorg-video-intel
xserver-xorg-video-intel:
  Installiert: 2:2.12.0-1ubuntu5
  Kandidat:    2:2.12.0-1ubuntu5
  Versionstabelle:
 *** 2:2.12.0-1ubuntu5 0
        500 http://de.archive.ubuntu.com/ubuntu/ maverick/main i386
Packages
        100 /var/lib/dpkg/status


Commit with regression:
commit 87acb0a550694ff1a7725ea3a73b80d8ccf56180
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Tue Oct 19 10:13:00 2010 +0100

    drm/i915: Simplify most HAS_BSD() checks
    
    ... by always initialising the empty ringbuffer it is always then
safe
    to check whether it is active.
    
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Re: [regression] drm/i915: Simplify most HAS_BSD() checks

[Chris Wilson]

On Sun, 24 Oct 2010 13:55:24 +0200, Alexey Fisher <bug-track@fisher-privat.net> wrote:
> this time double checked ;)
> 
> Netbook freeze on suspend. After "echo mem > /sys/power/state" suspend
> will be initiated bat freeze with blackscreen and cursor on top left
> corner. I can't access it per ssh.

I think I'd just spotted this one, try the tip of drm-intel-staging:

commit d566f4b5b8f0ffe6e92a8cb2b75e6c0934bb7450
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Sun Oct 24 12:38:05 2010 +0100

    drm/i915: Move gpu_write_list to per-ring
    
    ... to prevent flush processing of an idle (or even absent) ring.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

Re: [regression] drm/i915: Simplify most HAS_BSD() checks

[Alexey Fisher]

Am Sonntag, den 24.10.2010, 13:27 +0100 schrieb Chris Wilson:
> On Sun, 24 Oct 2010 13:55:24 +0200, Alexey Fisher <bug-track@fisher-privat.net> wrote:
> > this time double checked ;)
> > 
> > Netbook freeze on suspend. After "echo mem > /sys/power/state" suspend
> > will be initiated bat freeze with blackscreen and cursor on top left
> > corner. I can't access it per ssh.
> 
> I think I'd just spotted this one, try the tip of drm-intel-staging:
> 
> commit d566f4b5b8f0ffe6e92a8cb2b75e6c0934bb7450
> Author: Chris Wilson <chris@chris-wilson.co.uk>
> Date:   Sun Oct 24 12:38:05 2010 +0100
> 
>     drm/i915: Move gpu_write_list to per-ring
>     
>     ... to prevent flush processing of an idle (or even absent) ring.

Hmm.. there is no commit d566f4b5b.. on staging, nor on -next. Top of
staging is older than top of next.

Re: [regression] drm/i915: Simplify most HAS_BSD() checks

[Chris Wilson]

On Sun, 24 Oct 2010 14:49:57 +0200, Alexey Fisher <bug-track@fisher-privat.net> wrote:
> Hmm.. there is no commit d566f4b5b.. on staging, nor on -next. Top of
> staging is older than top of next.

I only just pushed as I wrote the email, it usually takes a few minutes
for kernel.org to sync.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

Re: [regression] drm/i915: Simplify most HAS_BSD() checks

[Alexey Fisher]

Am Sonntag, den 24.10.2010, 14:06 +0100 schrieb Chris Wilson:
> On Sun, 24 Oct 2010 14:49:57 +0200, Alexey Fisher <bug-track@fisher-privat.net> wrote:
> > Hmm.. there is no commit d566f4b5b.. on staging, nor on -next. Top of
> > staging is older than top of next.
> 
> I only just pushed as I wrote the email, it usually takes a few minutes
> for kernel.org to sync.

It working now,

Thank you.