All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Jeff Chua <jeff.chua.linux@gmail.com>,
	Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Randy Dunlap <randy.dunlap@oracle.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	dri-devel@lists.freedesktop.org, Alex Riesen <raa.lkml@gmail.com>
Subject: Re: Linux 2.6.37-rc8 (no fb)
Date: Thu, 30 Dec 2010 23:31:27 +0000	[thread overview]
Message-ID: <c6d829$q0mkri@fmsmga001.fm.intel.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1012301045170.5207@boston.corp.fedex.com>

On Thu, 30 Dec 2010 10:49:33 +0800 (SGT), Jeff Chua <jeff.chua.linux@gmail.com> wrote:
> 
> On Thu, Dec 30, 2010 at 4:16 AM, Jesse Barnes <jbarnes@virtuousgeek.org> 
> wrote:
> 
> > Randy, Jeff and Alex, does the below help at all?  If so, it may be the
> > minimal fix we want for 2.6.37.
> 
> Jesse,
> 
> Yes, that worked for me. I improved on the patch a bit below.
> 
> Thanks,
> Jeff
> 
> 
> --- a/drivers/gpu/drm/i915/intel_bios.c	2010-12-29 13:35:57.000000000 +0800
> +++ a/drivers/gpu/drm/i915/intel_bios.c	2010-12-30 10:18:39.000000000 +0800
> @@ -262,7 +262,10 @@
>   	if (general) {
>   		dev_priv->int_tv_support = general->int_tv_support;
>   		dev_priv->int_crt_support = general->int_crt_support;
> -		dev_priv->lvds_use_ssc = general->enable_ssc;
> +
> +		/* force disable until we can parse this correctly */
> +		dev_priv->lvds_use_ssc = (IS_GEN5(dev) || IS_GEN6(dev)) ?
> +			0 : general->enable_ssc;

This reveals another bug whereby we don't clear conflicting bits in
PCH_DREF_CONTROL set by the BIOS...
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

  parent reply	other threads:[~2010-12-30 23:31 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-30  2:49 Linux 2.6.37-rc8 (no fb) Jeff Chua
2010-12-30 18:16 ` Jesse Barnes
2010-12-30 18:16   ` Jesse Barnes
2010-12-30 23:31 ` Chris Wilson [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-12-29  1:18 Linux 2.6.37-rc8 Linus Torvalds
2010-12-29 18:21 ` Linux 2.6.37-rc8 (no fb) Randy Dunlap
2010-12-29 19:40   ` Linus Torvalds
2010-12-29 20:16     ` Jesse Barnes
2010-12-29 20:51       ` François Valenduc
2010-12-29 21:11       ` Alex Riesen
2010-12-29 21:18         ` Jesse Barnes
2010-12-29 21:53           ` Jesse Barnes
2010-12-29 21:53             ` Jesse Barnes
2010-12-29 23:09             ` Alex Riesen
2010-12-29 23:13               ` Jesse Barnes
2010-12-29 23:20                 ` Alex Riesen
2010-12-29 23:35                   ` Alex Riesen
2010-12-30  0:02                     ` Jesse Barnes
2010-12-30  0:10                       ` Alex Riesen
2010-12-29 22:02           ` Alex Riesen
2010-12-29 22:12       ` Randy Dunlap
2010-12-29 22:46         ` Jesse Barnes
2010-12-29 23:40           ` Randy Dunlap
2010-12-30 18:36     ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='c6d829$q0mkri@fmsmga001.fm.intel.com' \
    --to=chris@chris-wilson.co.uk \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jbarnes@virtuousgeek.org \
    --cc=jeff.chua.linux@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=raa.lkml@gmail.com \
    --cc=randy.dunlap@oracle.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.