All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Randy Dunlap <randy.dunlap@oracle.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	dri-devel@lists.freedesktop.org,
	Jeff Chua <jeff.chua.linux@gmail.com>
Subject: Re: Linux 2.6.37-rc8 (no fb)
Date: Wed, 29 Dec 2010 13:53:15 -0800	[thread overview]
Message-ID: <20101229135315.5fe5c4e5@jbarnes-desktop> (raw)
In-Reply-To: <20101229131852.0792aac0@jbarnes-desktop>

> > Doesn't change anything here. Display stays blank.
> 
> Sounds like your problem is separate from SSC then, more likely related
> to panel power or backlight control.  Have you tried bisecting for the
> problem between 2.6.35 and 2.6.36?

Nevermind, I just checked out the bug, looks like it is panel power
related.  Can you try this patch?

If it doesn't work, can you send me the output of intel_reg_dumper from
before you turn off the display and after you try to turn it back on?

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center

diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c
index aa23070..830e3b0 100644
--- a/drivers/gpu/drm/i915/intel_lvds.c
+++ b/drivers/gpu/drm/i915/intel_lvds.c
@@ -82,8 +82,6 @@ static void intel_lvds_enable(struct intel_lvds *intel_lvds)
 		lvds_reg = LVDS;
 	}
 
-	I915_WRITE(lvds_reg, I915_READ(lvds_reg) | LVDS_PORT_EN);
-
 	if (intel_lvds->pfit_dirty) {
 		/*
 		 * Enable automatic panel scaling so that non-native modes
@@ -104,7 +102,7 @@ static void intel_lvds_enable(struct intel_lvds *intel_lvds)
 	}
 
 	I915_WRITE(ctl_reg, I915_READ(ctl_reg) | POWER_TARGET_ON);
-	POSTING_READ(lvds_reg);
+	POSTING_READ(ctl_reg);
 
 	intel_panel_set_backlight(dev, dev_priv->backlight_level);
 }
@@ -136,8 +134,7 @@ static void intel_lvds_disable(struct intel_lvds *intel_lvds)
 		intel_lvds->pfit_dirty = true;
 	}
 
-	I915_WRITE(lvds_reg, I915_READ(lvds_reg) & ~LVDS_PORT_EN);
-	POSTING_READ(lvds_reg);
+	POSTING_READ(ctl_reg);
 }
 
 static void intel_lvds_dpms(struct drm_encoder *encoder, int mode)

WARNING: multiple messages have this Message-ID (diff)
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
	Jeff Chua <jeff.chua.linux@gmail.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	dri-devel@lists.freedesktop.org
Subject: Re: Linux 2.6.37-rc8 (no fb)
Date: Wed, 29 Dec 2010 13:53:15 -0800	[thread overview]
Message-ID: <20101229135315.5fe5c4e5@jbarnes-desktop> (raw)
In-Reply-To: <20101229131852.0792aac0@jbarnes-desktop>

> > Doesn't change anything here. Display stays blank.
> 
> Sounds like your problem is separate from SSC then, more likely related
> to panel power or backlight control.  Have you tried bisecting for the
> problem between 2.6.35 and 2.6.36?

Nevermind, I just checked out the bug, looks like it is panel power
related.  Can you try this patch?

If it doesn't work, can you send me the output of intel_reg_dumper from
before you turn off the display and after you try to turn it back on?

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center

diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c
index aa23070..830e3b0 100644
--- a/drivers/gpu/drm/i915/intel_lvds.c
+++ b/drivers/gpu/drm/i915/intel_lvds.c
@@ -82,8 +82,6 @@ static void intel_lvds_enable(struct intel_lvds *intel_lvds)
 		lvds_reg = LVDS;
 	}
 
-	I915_WRITE(lvds_reg, I915_READ(lvds_reg) | LVDS_PORT_EN);
-
 	if (intel_lvds->pfit_dirty) {
 		/*
 		 * Enable automatic panel scaling so that non-native modes
@@ -104,7 +102,7 @@ static void intel_lvds_enable(struct intel_lvds *intel_lvds)
 	}
 
 	I915_WRITE(ctl_reg, I915_READ(ctl_reg) | POWER_TARGET_ON);
-	POSTING_READ(lvds_reg);
+	POSTING_READ(ctl_reg);
 
 	intel_panel_set_backlight(dev, dev_priv->backlight_level);
 }
@@ -136,8 +134,7 @@ static void intel_lvds_disable(struct intel_lvds *intel_lvds)
 		intel_lvds->pfit_dirty = true;
 	}
 
-	I915_WRITE(lvds_reg, I915_READ(lvds_reg) & ~LVDS_PORT_EN);
-	POSTING_READ(lvds_reg);
+	POSTING_READ(ctl_reg);
 }
 
 static void intel_lvds_dpms(struct drm_encoder *encoder, int mode)

  reply	other threads:[~2010-12-29 21:59 UTC|newest]

Thread overview: 108+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-29  1:18 Linux 2.6.37-rc8 Linus Torvalds
2010-12-29 11:18 ` Borislav Petkov
2010-12-29 12:08   ` Rafael J. Wysocki
2010-12-30  1:17     ` Zhang Rui
2010-12-29 18:21 ` Linux 2.6.37-rc8 (no fb) Randy Dunlap
2010-12-29 19:40   ` Linus Torvalds
2010-12-29 20:16     ` Jesse Barnes
2010-12-29 20:51       ` François Valenduc
2010-12-29 21:11       ` Alex Riesen
2010-12-29 21:18         ` Jesse Barnes
2010-12-29 21:53           ` Jesse Barnes [this message]
2010-12-29 21:53             ` Jesse Barnes
2010-12-29 23:09             ` Alex Riesen
2010-12-29 23:13               ` Jesse Barnes
2010-12-29 23:20                 ` Alex Riesen
2010-12-29 23:35                   ` Alex Riesen
2010-12-30  0:02                     ` Jesse Barnes
2010-12-30  0:10                       ` Alex Riesen
2010-12-29 22:02           ` Alex Riesen
2010-12-29 22:12       ` Randy Dunlap
2010-12-29 22:46         ` Jesse Barnes
2010-12-29 23:40           ` Randy Dunlap
2010-12-30 18:36     ` Chris Wilson
2010-12-30 17:14 ` still nfs problems [Was: Linux 2.6.37-rc8] Uwe Kleine-König
2010-12-30 17:14   ` Uwe Kleine-König
2010-12-30 17:57   ` Linus Torvalds
2010-12-30 17:57     ` Linus Torvalds
2010-12-30 18:24     ` Trond Myklebust
2010-12-30 18:24       ` Trond Myklebust
2010-12-30 18:50       ` Linus Torvalds
2010-12-30 18:50         ` Linus Torvalds
2010-12-30 19:25         ` Trond Myklebust
2010-12-30 19:25           ` Trond Myklebust
2010-12-30 20:02           ` Linus Torvalds
2010-12-30 20:02             ` Linus Torvalds
2010-12-30 17:59   ` Trond Myklebust
2010-12-30 17:59     ` Trond Myklebust
2010-12-30 19:18     ` Uwe Kleine-König
2010-12-30 19:18       ` Uwe Kleine-König
2011-01-03 21:38       ` Uwe Kleine-König
2011-01-03 21:38         ` Uwe Kleine-König
2011-01-04  0:22         ` Trond Myklebust
2011-01-04  0:22           ` Trond Myklebust
2011-01-05  8:40           ` Uwe Kleine-König
2011-01-05  8:40             ` Uwe Kleine-König
2011-01-05 11:05             ` Uwe Kleine-König
2011-01-05 11:05               ` Uwe Kleine-König
2011-01-05 11:27               ` Russell King - ARM Linux
2011-01-05 11:27                 ` Russell King - ARM Linux
2011-01-05 12:14                 ` Marc Kleine-Budde
2011-01-05 12:14                   ` Marc Kleine-Budde
2011-01-05 13:02                   ` Nori, Sekhar
2011-01-05 13:02                     ` Nori, Sekhar
2011-01-05 15:34                     ` Russell King - ARM Linux
2011-01-05 15:34                       ` Russell King - ARM Linux
2011-01-05 13:40                 ` Uwe Kleine-König
2011-01-05 13:40                   ` Uwe Kleine-König
2011-01-05 14:29                   ` Jim Rees
2011-01-05 14:29                     ` Jim Rees
2011-01-05 14:42                     ` Marc Kleine-Budde
2011-01-05 14:42                       ` Marc Kleine-Budde
2011-01-05 15:38                       ` Jim Rees
2011-01-05 15:38                         ` Jim Rees
2011-01-05 14:53                   ` Trond Myklebust
2011-01-05 14:53                     ` Trond Myklebust
2011-01-05 15:01                     ` Marc Kleine-Budde
2011-01-05 15:01                       ` Marc Kleine-Budde
2011-01-05 15:14                       ` Trond Myklebust
2011-01-05 15:14                         ` Trond Myklebust
2011-01-05 15:29                         ` Trond Myklebust
2011-01-05 15:29                           ` Trond Myklebust
2011-01-05 15:39                           ` Marc Kleine-Budde
2011-01-05 15:39                             ` Marc Kleine-Budde
2011-01-05 15:52                         ` Russell King - ARM Linux
2011-01-05 15:52                           ` Russell King - ARM Linux
2011-01-05 17:17                           ` Trond Myklebust
2011-01-05 17:17                             ` Trond Myklebust
2011-01-05 17:26                             ` Russell King - ARM Linux
2011-01-05 17:26                               ` Russell King - ARM Linux
2011-01-05 18:12                               ` Trond Myklebust
2011-01-05 18:12                                 ` Trond Myklebust
2011-01-05 18:27                                 ` Russell King - ARM Linux
2011-01-05 18:27                                   ` Russell King - ARM Linux
2011-01-05 18:55                                   ` Trond Myklebust
2011-01-05 18:55                                     ` Trond Myklebust
2011-01-05 19:07                                     ` Russell King - ARM Linux
2011-01-05 19:07                                       ` Russell King - ARM Linux
2011-01-14  2:25                     ` Andy Isaacson
2011-01-14  2:25                       ` Andy Isaacson
2011-01-14  2:40                       ` Trond Myklebust
2011-01-14  2:40                         ` Trond Myklebust
2011-01-14  4:22                         ` Andy Isaacson
2011-01-14  4:22                           ` Andy Isaacson
2011-01-03  8:48 ` Linux 2.6.37-rc8 Domenico Andreoli
2011-01-04 14:26 ` Pavel Machek
2011-01-04 14:35   ` Chris Wilson
2011-01-04 21:04     ` Pavel Machek
2011-01-04 21:15       ` Dave Airlie
2011-01-05  7:21         ` Pavel Machek
2011-01-05 22:05         ` Pavel Machek
2011-01-05 22:49           ` Dave Airlie
2011-01-06 20:27             ` Pavel Machek
2000-01-01  0:13               ` Pavel Machek
2011-01-08 12:46                 ` Chris Wilson
  -- strict thread matches above, loose matches on Subject: below --
2010-12-30  2:49 Linux 2.6.37-rc8 (no fb) Jeff Chua
2010-12-30 18:16 ` Jesse Barnes
2010-12-30 18:16   ` Jesse Barnes
2010-12-30 23:31 ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101229135315.5fe5c4e5@jbarnes-desktop \
    --to=jbarnes@virtuousgeek.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jeff.chua.linux@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=raa.lkml@gmail.com \
    --cc=randy.dunlap@oracle.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.