From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-i2c@vger.kernel.org, Wolfram Sang <wsa@kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Jan Dabros <jsd@semihalf.com>, Michael Wu <michael.wu@vatics.com>,
Tian Ye <tianye@sugon.com>,
Luis Oliveira <luis.oliveira@synopsys.com>
Subject: Re: [PATCH 11/11] i2c: designware: Align defines in i2c-designware-core.h
Date: Wed, 2 Nov 2022 15:14:50 +0200 [thread overview]
Message-ID: <c6f9fa95-90ae-67b3-3a40-c8baf06c4cff@linux.intel.com> (raw)
In-Reply-To: <Y1k4SoqEopMaf5q1@smile.fi.intel.com>
Hi
On 10/26/22 16:38, Andy Shevchenko wrote:
> On Wed, Oct 26, 2022 at 03:39:12PM +0300, Jarkko Nikula wrote:
>> Align all defines to the same column.
>
> ...
>
>> +#define DW_IC_SDA_HOLD_MIN_VERS 0x3131312A
>
>> +#define DW_IC_COMP_TYPE_VALUE 0x44570140
>
> While at it, I would add comments that show ASCII values of these definitions.
>
Yes good idea and I did it in a new followup patch to this.
>> +#define DW_IC_INTR_DEFAULT_MASK (DW_IC_INTR_RX_FULL | \
>> + DW_IC_INTR_TX_ABRT | \
>> + DW_IC_INTR_STOP_DET)
>> +#define DW_IC_INTR_MASTER_MASK (DW_IC_INTR_DEFAULT_MASK | \
>> + DW_IC_INTR_TX_EMPTY)
>> +#define DW_IC_INTR_SLAVE_MASK (DW_IC_INTR_DEFAULT_MASK | \
>> + DW_IC_INTR_RX_UNDER | \
>> + DW_IC_INTR_RD_REQ)
>
> While at it, I would reformat these (and similar below) as
>
> #define DW_IC_INTR_DEFAULT_MASK \
> (DW_IC_INTR_RX_FULL | DW_IC_INTR_TX_ABRT | DW_IC_INTR_STOP_DET)
>
I tried this and to me it didn't look as clear than existing so I kept
it as before.
>> - struct i2c_bus_recovery_info rinfo;
>> + struct i2c_bus_recovery_info rinfo;
>
> ...and now this are consistent, but these all are inconsistent with, e.g.
>
Yeah, this somehow slipped in. Removed this change from v2.
Jarkko
next prev parent reply other threads:[~2022-11-02 13:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 12:39 [PATCH 00/11] i2c: designware: Slave fixes and generic cleanups Jarkko Nikula
2022-10-26 12:39 ` [PATCH 01/11] i2c: designware: Fix slave state machine for sequential reads Jarkko Nikula
2022-10-26 12:39 ` [PATCH 02/11] i2c: designware: Empty receive FIFO in slave interrupt handler Jarkko Nikula
2022-10-26 12:39 ` [PATCH 03/11] i2c: designware: Define software status flags with BIT() Jarkko Nikula
2022-10-26 12:39 ` [PATCH 04/11] i2c: designware: Remove needless initializations from i2c_dw_reg_slave() Jarkko Nikula
2022-10-26 12:39 ` [PATCH 05/11] i2c: designware: Remove unused completion code from i2c-designware-slave Jarkko Nikula
2022-10-26 12:39 ` [PATCH 06/11] i2c: designware: Simplify slave interrupt handler nesting Jarkko Nikula
2022-10-26 12:39 ` [PATCH 07/11] i2c: designware: Do not process interrupt when device is suspended Jarkko Nikula
2022-10-26 13:28 ` Andy Shevchenko
2022-10-26 13:29 ` Andy Shevchenko
2022-10-26 12:39 ` [PATCH 08/11] i2c: designware: Move debug print in i2c_dw_isr() Jarkko Nikula
2022-10-26 12:39 ` [PATCH 09/11] i2c: designware: Simplify master interrupt handler nesting Jarkko Nikula
2022-10-26 12:39 ` [PATCH 10/11] i2c: designware: Remove common i2c_dw_disable_int() Jarkko Nikula
2022-10-26 13:34 ` Andy Shevchenko
2022-10-26 14:00 ` Jarkko Nikula
2022-10-26 12:39 ` [PATCH 11/11] i2c: designware: Align defines in i2c-designware-core.h Jarkko Nikula
2022-10-26 13:38 ` Andy Shevchenko
2022-11-02 13:14 ` Jarkko Nikula [this message]
2022-10-26 12:56 ` [PATCH 00/11] i2c: designware: Slave fixes and generic cleanups Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6f9fa95-90ae-67b3-3a40-c8baf06c4cff@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=luis.oliveira@synopsys.com \
--cc=michael.wu@vatics.com \
--cc=mika.westerberg@linux.intel.com \
--cc=tianye@sugon.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.