From: Julian Braha <julianbraha@gmail.com>
To: Jorijn van der Graaf <jorijnvdgraaf@catcrafts.net>,
Mark Brown <broonie@kernel.org>
Cc: Srinivas Kandagatla <srini@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Luca Weiss <luca.weiss@fairphone.com>,
Conor Dooley <conor+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] ASoC: codecs: wcd9378: add TX/capture codec driver
Date: Fri, 10 Jul 2026 13:20:36 +0100 [thread overview]
Message-ID: <c74c20f7-b819-414b-b936-c85c165bb537@gmail.com> (raw)
In-Reply-To: <20260706192229.144137-4-jorijnvdgraaf@catcrafts.net>
Hi Jorijn,
On 7/6/26 20:22, Jorijn van der Graaf wrote:
> +config SND_SOC_WCD9378
> + depends on SND_SOC_WCD9378_SDW
> + tristate
> + depends on SOUNDWIRE || !SOUNDWIRE
> + select SND_SOC_WCD_COMMON
The preferred style for this is 'depends on SOUNDWIRE if SOUNDWIRE'
since 'depends on X if Y' was added recently. Also see the kconfig docs
on "Optional dependencies".
> +config SND_SOC_WCD9378_SDW
> + tristate "WCD9378 Codec - SDW"
> + select SND_SOC_WCD9378
> + depends on SOUNDWIRE
> + select REGMAP_SOUNDWIRE
Another kconfig style nitpick: could you organize the attributes?
E.g. keep the selects together, and keep the dependencies together?
- Julian Braha
prev parent reply other threads:[~2026-07-10 12:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 19:22 [PATCH 0/3] ASoC: codecs: add the Qualcomm WCD9378 audio codec Jorijn van der Graaf
2026-07-06 19:22 ` [PATCH 1/3] ASoC: dt-bindings: qcom,wcd93xx-common: don't require micbias4 Jorijn van der Graaf
2026-07-08 10:43 ` Krzysztof Kozlowski
2026-07-06 19:22 ` [PATCH 2/3] ASoC: dt-bindings: add the Qualcomm WCD9378 audio codec Jorijn van der Graaf
2026-07-06 21:17 ` Srinivas Kandagatla
2026-07-06 22:22 ` Jorijn van der Graaf
2026-07-06 19:22 ` [PATCH 3/3] ASoC: codecs: wcd9378: add TX/capture codec driver Jorijn van der Graaf
2026-07-06 19:38 ` sashiko-bot
2026-07-06 20:35 ` Jorijn van der Graaf
2026-07-06 21:41 ` Srinivas Kandagatla
2026-07-06 22:22 ` Jorijn van der Graaf
2026-07-07 11:42 ` Pierre-Louis Bossart
2026-07-07 15:13 ` Jorijn van der Graaf
2026-07-08 9:11 ` Pierre-Louis Bossart
2026-07-10 12:20 ` Julian Braha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c74c20f7-b819-414b-b936-c85c165bb537@gmail.com \
--to=julianbraha@gmail.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jorijnvdgraaf@catcrafts.net \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=mohammad.rafi.shaik@oss.qualcomm.com \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=srini@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.