RE: [PATCH] dt-bindings: arm/bcm: Fix and validate brcm,bcm63138 bindings with no errors

[William Zhang <william.zhang@broadcom.com>]

[-- Attachment #1: Type: text/plain, Size: 3941 bytes --]

Hi Shankari and Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: Sunday, May 25, 2025 9:02 PM
> To: Shankari Anand <shankari.ak0208@gmail.com>; devicetree@vger.kernel.org
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley
> <conor+dt@kernel.org>; William Zhang <william.zhang@broadcom.com>;
> Anand Gore <anand.gore@broadcom.com>; Kursad Oney
> <kursad.oney@broadcom.com>; Florian Fainelli
> <florian.fainelli@broadcom.com>; Rafał Miłecki <rafal@milecki.pl>;
> Broadcom
> internal kernel review list <bcm-kernel-feedback-list@broadcom.com>; Rob
> Herring <robh@kernel.org>; skhan@linuxfoundation.org
> Subject: Re: [PATCH] dt-bindings: arm/bcm: Fix and validate brcm,bcm63138
> bindings with no errors
>
> On 25/05/2025 21:43, Shankari Anand wrote:
> > Fix and validate brcm,bcm63138 device tree bindings by correcting schema
> > and
> example files.
>
> Nothing like that is done here.
>
> > This resolves previous schema validation errors and ensures compliance
> > with
> devicetree core schema requirements.
>
> Which errors?
>
> > The patch passes dtbs check successfully, confirming the YAML bindings,
> example DTS, and generated DTB are error-free.
>
> Drop, redundant.
>
> Please wrap commit message according to Linux coding style / submission
> process (neither too early nor over the limit):
> https://elixir.bootlin.com/linux/v6.4-
> rc1/source/Documentation/process/submitting-patches.rst#L597
>
> >
> > Signed-off-by: Shankari Anand <shankari.ak0208@gmail.com>
> > ---
> >  .../bindings/arm/bcm/brcm,bcm63138.yaml       | 43 +++++++++++++++++++
>
> >  1 file changed, 43 insertions(+)
> >  create mode 100644
> Documentation/devicetree/bindings/arm/bcm/brcm,bcm63138.yaml
> >
> > diff --git
> a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm63138.yaml
> b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm63138.yaml
> > new file mode 100644
> > index 000000000000..5848f96128e1
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm63138.yaml
> > @@ -0,0 +1,43 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/arm/bcm/brcm,bcm63138.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Broadcom BCM63138 DSL SoC
> > +
> > +maintainers:
> > +  - Shankari Anand <shankari.ak0208@gmail.com>
> > +
> > +description: |
> > +  The Broadcom BCM63138 DSL System-on-a-Chip is designed for DSL
> platforms.
> > +  It supports multi-core ARM Cortex-A9 CPUs, a boot lookup table
> > (BootLUT),
> > +  and software-controlled resets using a system timer.
> > +
> > +select:
> > +  properties:
> > +    compatible:
> > +      contains:
> > +        const: brcm,bcm63138
> > +  required:
> > +    - compatible
> > +
> > +properties:
> > +  compatible:
> > +    const: brcm,bcm63138
>
> You are duplicating existing bindings - both TXT and schema. Maybe you
> wanted to do the conversion, but that's still duplication.
>
> > +
> > +patternProperties:
> > +  "^bootlut(@[0-9a-f]+)?$":
> > +    type: object
> > +    properties:
> > +      compatible:
> > +        const: brcm,bcm63138-bootlut
> > +
> > +      reg:
> > +        maxItems: 1
> > +
> > +    required:
> > +      - compatible
> > +      - reg
> > +
> > +additionalProperties: true
>
> No, this cannot be true. Look at other bindings... or is it soc/platform
> file? I really do not understand what you want to achieve here.
>
I guess we need to find a proper home for brcm,bcm63138-bootlut since it is
used in the kernel source.
brcm,bcmbca.yaml covers all the soc already including bcm63138.  Would it be
the right direction to add a new
yaml file for brcm,bcm63138-bootlut block itself and drop the
brcm,bcm63138.txt completely?

>
> Best regards,
> Krzysztof

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4199 bytes --]