* [PATCH] dt-bindings: arm/bcm: Fix and validate brcm,bcm63138 bindings with no errors
@ 2025-05-25 19:43 Shankari Anand
2025-05-26 4:01 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Shankari Anand @ 2025-05-25 19:43 UTC (permalink / raw)
To: devicetree
Cc: Krzysztof Kozlowski, Conor Dooley, William Zhang, Anand Gore,
Kursad Oney, Florian Fainelli, Rafał Miłecki,
Broadcom internal kernel review list, Rob Herring, skhan,
Shankari Anand
Fix and validate brcm,bcm63138 device tree bindings by correcting schema and example files.
This resolves previous schema validation errors and ensures compliance with devicetree core schema requirements.
The patch passes dtbs check successfully, confirming the YAML bindings, example DTS, and generated DTB are error-free.
Signed-off-by: Shankari Anand <shankari.ak0208@gmail.com>
---
.../bindings/arm/bcm/brcm,bcm63138.yaml | 43 +++++++++++++++++++
1 file changed, 43 insertions(+)
create mode 100644 Documentation/devicetree/bindings/arm/bcm/brcm,bcm63138.yaml
diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm63138.yaml b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm63138.yaml
new file mode 100644
index 000000000000..5848f96128e1
--- /dev/null
+++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm63138.yaml
@@ -0,0 +1,43 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/arm/bcm/brcm,bcm63138.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Broadcom BCM63138 DSL SoC
+
+maintainers:
+ - Shankari Anand <shankari.ak0208@gmail.com>
+
+description: |
+ The Broadcom BCM63138 DSL System-on-a-Chip is designed for DSL platforms.
+ It supports multi-core ARM Cortex-A9 CPUs, a boot lookup table (BootLUT),
+ and software-controlled resets using a system timer.
+
+select:
+ properties:
+ compatible:
+ contains:
+ const: brcm,bcm63138
+ required:
+ - compatible
+
+properties:
+ compatible:
+ const: brcm,bcm63138
+
+patternProperties:
+ "^bootlut(@[0-9a-f]+)?$":
+ type: object
+ properties:
+ compatible:
+ const: brcm,bcm63138-bootlut
+
+ reg:
+ maxItems: 1
+
+ required:
+ - compatible
+ - reg
+
+additionalProperties: true
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: arm/bcm: Fix and validate brcm,bcm63138 bindings with no errors
2025-05-25 19:43 [PATCH] dt-bindings: arm/bcm: Fix and validate brcm,bcm63138 bindings with no errors Shankari Anand
@ 2025-05-26 4:01 ` Krzysztof Kozlowski
2025-05-27 21:43 ` William Zhang
0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2025-05-26 4:01 UTC (permalink / raw)
To: Shankari Anand, devicetree
Cc: Krzysztof Kozlowski, Conor Dooley, William Zhang, Anand Gore,
Kursad Oney, Florian Fainelli, Rafał Miłecki,
Broadcom internal kernel review list, Rob Herring, skhan
On 25/05/2025 21:43, Shankari Anand wrote:
> Fix and validate brcm,bcm63138 device tree bindings by correcting schema and example files.
Nothing like that is done here.
> This resolves previous schema validation errors and ensures compliance with devicetree core schema requirements.
Which errors?
> The patch passes dtbs check successfully, confirming the YAML bindings, example DTS, and generated DTB are error-free.
Drop, redundant.
Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
>
> Signed-off-by: Shankari Anand <shankari.ak0208@gmail.com>
> ---
> .../bindings/arm/bcm/brcm,bcm63138.yaml | 43 +++++++++++++++++++
> 1 file changed, 43 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/arm/bcm/brcm,bcm63138.yaml
>
> diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm63138.yaml b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm63138.yaml
> new file mode 100644
> index 000000000000..5848f96128e1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm63138.yaml
> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/bcm/brcm,bcm63138.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom BCM63138 DSL SoC
> +
> +maintainers:
> + - Shankari Anand <shankari.ak0208@gmail.com>
> +
> +description: |
> + The Broadcom BCM63138 DSL System-on-a-Chip is designed for DSL platforms.
> + It supports multi-core ARM Cortex-A9 CPUs, a boot lookup table (BootLUT),
> + and software-controlled resets using a system timer.
> +
> +select:
> + properties:
> + compatible:
> + contains:
> + const: brcm,bcm63138
> + required:
> + - compatible
> +
> +properties:
> + compatible:
> + const: brcm,bcm63138
You are duplicating existing bindings - both TXT and schema. Maybe you
wanted to do the conversion, but that's still duplication.
> +
> +patternProperties:
> + "^bootlut(@[0-9a-f]+)?$":
> + type: object
> + properties:
> + compatible:
> + const: brcm,bcm63138-bootlut
> +
> + reg:
> + maxItems: 1
> +
> + required:
> + - compatible
> + - reg
> +
> +additionalProperties: true
No, this cannot be true. Look at other bindings... or is it soc/platform
file? I really do not understand what you want to achieve here.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] dt-bindings: arm/bcm: Fix and validate brcm,bcm63138 bindings with no errors
2025-05-26 4:01 ` Krzysztof Kozlowski
@ 2025-05-27 21:43 ` William Zhang
[not found] ` <CAPRMd3nyaV5fWYP_iY7XxgfzCDLUTpqHR0ebb0dSQ68tmEM62w@mail.gmail.com>
0 siblings, 1 reply; 6+ messages in thread
From: William Zhang @ 2025-05-27 21:43 UTC (permalink / raw)
To: Krzysztof Kozlowski, Shankari Anand, devicetree
Cc: Krzysztof Kozlowski, Conor Dooley, Anand Gore, Kursad Oney,
Florian Fainelli, Rafał Miłecki,
Broadcom internal kernel review list, Rob Herring, skhan
[-- Attachment #1: Type: text/plain, Size: 3941 bytes --]
Hi Shankari and Krzysztof,
> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: Sunday, May 25, 2025 9:02 PM
> To: Shankari Anand <shankari.ak0208@gmail.com>; devicetree@vger.kernel.org
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley
> <conor+dt@kernel.org>; William Zhang <william.zhang@broadcom.com>;
> Anand Gore <anand.gore@broadcom.com>; Kursad Oney
> <kursad.oney@broadcom.com>; Florian Fainelli
> <florian.fainelli@broadcom.com>; Rafał Miłecki <rafal@milecki.pl>;
> Broadcom
> internal kernel review list <bcm-kernel-feedback-list@broadcom.com>; Rob
> Herring <robh@kernel.org>; skhan@linuxfoundation.org
> Subject: Re: [PATCH] dt-bindings: arm/bcm: Fix and validate brcm,bcm63138
> bindings with no errors
>
> On 25/05/2025 21:43, Shankari Anand wrote:
> > Fix and validate brcm,bcm63138 device tree bindings by correcting schema
> > and
> example files.
>
> Nothing like that is done here.
>
> > This resolves previous schema validation errors and ensures compliance
> > with
> devicetree core schema requirements.
>
> Which errors?
>
> > The patch passes dtbs check successfully, confirming the YAML bindings,
> example DTS, and generated DTB are error-free.
>
> Drop, redundant.
>
> Please wrap commit message according to Linux coding style / submission
> process (neither too early nor over the limit):
> https://elixir.bootlin.com/linux/v6.4-
> rc1/source/Documentation/process/submitting-patches.rst#L597
>
> >
> > Signed-off-by: Shankari Anand <shankari.ak0208@gmail.com>
> > ---
> > .../bindings/arm/bcm/brcm,bcm63138.yaml | 43 +++++++++++++++++++
>
> > 1 file changed, 43 insertions(+)
> > create mode 100644
> Documentation/devicetree/bindings/arm/bcm/brcm,bcm63138.yaml
> >
> > diff --git
> a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm63138.yaml
> b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm63138.yaml
> > new file mode 100644
> > index 000000000000..5848f96128e1
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm63138.yaml
> > @@ -0,0 +1,43 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/arm/bcm/brcm,bcm63138.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Broadcom BCM63138 DSL SoC
> > +
> > +maintainers:
> > + - Shankari Anand <shankari.ak0208@gmail.com>
> > +
> > +description: |
> > + The Broadcom BCM63138 DSL System-on-a-Chip is designed for DSL
> platforms.
> > + It supports multi-core ARM Cortex-A9 CPUs, a boot lookup table
> > (BootLUT),
> > + and software-controlled resets using a system timer.
> > +
> > +select:
> > + properties:
> > + compatible:
> > + contains:
> > + const: brcm,bcm63138
> > + required:
> > + - compatible
> > +
> > +properties:
> > + compatible:
> > + const: brcm,bcm63138
>
> You are duplicating existing bindings - both TXT and schema. Maybe you
> wanted to do the conversion, but that's still duplication.
>
> > +
> > +patternProperties:
> > + "^bootlut(@[0-9a-f]+)?$":
> > + type: object
> > + properties:
> > + compatible:
> > + const: brcm,bcm63138-bootlut
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + required:
> > + - compatible
> > + - reg
> > +
> > +additionalProperties: true
>
> No, this cannot be true. Look at other bindings... or is it soc/platform
> file? I really do not understand what you want to achieve here.
>
I guess we need to find a proper home for brcm,bcm63138-bootlut since it is
used in the kernel source.
brcm,bcmbca.yaml covers all the soc already including bcm63138. Would it be
the right direction to add a new
yaml file for brcm,bcm63138-bootlut block itself and drop the
brcm,bcm63138.txt completely?
>
> Best regards,
> Krzysztof
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4199 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: arm/bcm: Fix and validate brcm,bcm63138 bindings with no errors
@ 2025-05-31 21:38 kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2025-05-31 21:38 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp
::::::
:::::: Manual check reason: "dtcheck: binding changes may go via different trees"
::::::
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20250525194333.1729443-1-shankari.ak0208@gmail.com>
References: <20250525194333.1729443-1-shankari.ak0208@gmail.com>
TO: Shankari Anand <shankari.ak0208@gmail.com>
TO: devicetree@vger.kernel.org
CC: Krzysztof Kozlowski <krzk@kernel.org>
CC: Conor Dooley <conor+dt@kernel.org>
CC: William Zhang <william.zhang@broadcom.com>
CC: Anand Gore <anand.gore@broadcom.com>
CC: Kursad Oney <kursad.oney@broadcom.com>
CC: Florian Fainelli <florian.fainelli@broadcom.com>
CC: "Rafał Miłecki" <rafal@milecki.pl>
CC: Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>
CC: Rob Herring <robh@kernel.org>
CC: skhan@linuxfoundation.org
CC: Shankari Anand <shankari.ak0208@gmail.com>
Hi Shankari,
kernel test robot noticed the following build warnings:
[auto build test WARNING on robh/for-next]
[also build test WARNING on krzk/for-next krzk-dt/for-next krzk-mem-ctrl/for-next linus/master v6.15 next-20250530]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Shankari-Anand/dt-bindings-arm-bcm-Fix-and-validate-brcm-bcm63138-bindings-with-no-errors/20250526-034456
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link: https://lore.kernel.org/r/20250525194333.1729443-1-shankari.ak0208%40gmail.com
patch subject: [PATCH] dt-bindings: arm/bcm: Fix and validate brcm,bcm63138 bindings with no errors
:::::: branch date: 6 days ago
:::::: commit date: 6 days ago
config: arm-randconfig-052-20250531 (https://download.01.org/0day-ci/archive/20250601/202506010545.q3yWkRzc-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 7.5.0
dtschema version: 2025.3.dev27+g32749b3
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250601/202506010545.q3yWkRzc-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202506010545.q3yWkRzc-lkp@intel.com/
dtcheck warnings: (new ones prefixed by >>)
arch/arm/boot/dts/broadcom/bcm63138.dtsi:251.10-256.5: Warning (simple_bus_reg): /ubus@fffe8000/reboot: missing or empty reg/ranges property
>> arch/arm/boot/dts/broadcom/bcm963138.dtb: / (brcm,bcm963138): compatible:0: 'brcm,bcm63138' was expected
from schema $id: http://devicetree.org/schemas/arm/bcm/brcm,bcm63138.yaml#
>> arch/arm/boot/dts/broadcom/bcm963138.dtb: / (brcm,bcm963138): compatible: ['brcm,bcm963138', 'brcm,bcm63138', 'brcm,bcmbca'] is too long
from schema $id: http://devicetree.org/schemas/arm/bcm/brcm,bcm63138.yaml#
arch/arm/boot/dts/broadcom/bcm963138.dtb: armpll@20000 (brcm,bcm63138-armpll): #clock-cells: 1 was expected
from schema $id: http://devicetree.org/schemas/clock/brcm,iproc-clocks.yaml#
arch/arm/boot/dts/broadcom/bcm963138.dtb: armpll@20000 (brcm,bcm63138-armpll): 'clock-output-names' is a required property
from schema $id: http://devicetree.org/schemas/clock/brcm,iproc-clocks.yaml#
arch/arm/boot/dts/broadcom/bcm963138.dtb: reset-controller@4800c0 (brcm,bcm63138-pmb): '#reset-cells' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/power/brcm,bcm-pmb.yaml#
arch/arm/boot/dts/broadcom/bcm963138.dtb: reset-controller@4800c0 (brcm,bcm63138-pmb): '#power-domain-cells' is a required property
from schema $id: http://devicetree.org/schemas/power/brcm,bcm-pmb.yaml#
arch/arm/boot/dts/broadcom/bcm963138.dtb: reset-controller@4800e0 (brcm,bcm63138-pmb): '#reset-cells' does not match any of the regexes: '^pinctrl-[0-9]+$'
--
arch/arm/boot/dts/broadcom/bcm63138.dtsi:251.10-256.5: Warning (simple_bus_reg): /ubus@fffe8000/reboot: missing or empty reg/ranges property
>> arch/arm/boot/dts/broadcom/bcm963138dvt.dtb: / (brcm,BCM963138DVT): compatible:0: 'brcm,bcm63138' was expected
from schema $id: http://devicetree.org/schemas/arm/bcm/brcm,bcm63138.yaml#
>> arch/arm/boot/dts/broadcom/bcm963138dvt.dtb: / (brcm,BCM963138DVT): compatible: ['brcm,BCM963138DVT', 'brcm,bcm63138', 'brcm,bcmbca'] is too long
from schema $id: http://devicetree.org/schemas/arm/bcm/brcm,bcm63138.yaml#
arch/arm/boot/dts/broadcom/bcm963138dvt.dtb: armpll@20000 (brcm,bcm63138-armpll): #clock-cells: 1 was expected
from schema $id: http://devicetree.org/schemas/clock/brcm,iproc-clocks.yaml#
arch/arm/boot/dts/broadcom/bcm963138dvt.dtb: armpll@20000 (brcm,bcm63138-armpll): 'clock-output-names' is a required property
from schema $id: http://devicetree.org/schemas/clock/brcm,iproc-clocks.yaml#
arch/arm/boot/dts/broadcom/bcm963138dvt.dtb: reset-controller@4800c0 (brcm,bcm63138-pmb): '#reset-cells' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/power/brcm,bcm-pmb.yaml#
arch/arm/boot/dts/broadcom/bcm963138dvt.dtb: reset-controller@4800c0 (brcm,bcm63138-pmb): '#power-domain-cells' is a required property
from schema $id: http://devicetree.org/schemas/power/brcm,bcm-pmb.yaml#
arch/arm/boot/dts/broadcom/bcm963138dvt.dtb: reset-controller@4800e0 (brcm,bcm63138-pmb): '#reset-cells' does not match any of the regexes: '^pinctrl-[0-9]+$'
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: arm/bcm: Fix and validate brcm,bcm63138 bindings with no errors
[not found] ` <CAPRMd3nyaV5fWYP_iY7XxgfzCDLUTpqHR0ebb0dSQ68tmEM62w@mail.gmail.com>
@ 2025-06-08 18:40 ` Shankari Anand
[not found] ` <CAPRMd3n733TzxJMo1JooHBavSnjN=AWT_hKV38LOeZBpPHrnrw@mail.gmail.com>
0 siblings, 1 reply; 6+ messages in thread
From: Shankari Anand @ 2025-06-08 18:40 UTC (permalink / raw)
To: William Zhang
Cc: Krzysztof Kozlowski, devicetree, Krzysztof Kozlowski,
Conor Dooley, Anand Gore, Kursad Oney, Florian Fainelli,
Rafał Miłecki, Broadcom internal kernel review list,
Rob Herring, skhan
> I guess we need to find a proper home for brcm,bcm63138-bootlut since it is
> used in the kernel source.
> brcm,bcmbca.yaml covers all the soc already including bcm63138.
Yeah, I realised bcm63138 is included in the compatible devices under
brcm,bca but the boot-lut doesn't seem to be satisfied because of
which the .txt isn't satisfied. I have shared a v2 patch which solves
this possibly. Here's the link - Patch
Regards,
Shankari
On Mon, Jun 9, 2025 at 12:09 AM Shankari Anand
<shankari.ak0208@gmail.com> wrote:
>>
>> I guess we need to find a proper home for brcm,bcm63138-bootlut since it is
>> used in the kernel source.
>> brcm,bcmbca.yaml covers all the soc already including bcm63138.
>
>
> Yeah, I realised bcm63138 is included in the compatible devices under brcm,bca but the boot-lut doesn't seem to be satisfied because of which the .txt isn't satisfied. I have shared a v2 patch which solves this possibly. Here's the link - Patch
>
>
> On Wed, May 28, 2025 at 3:13 AM William Zhang <william.zhang@broadcom.com> wrote:
>>
>> Hi Shankari and Krzysztof,
>>
>> > -----Original Message-----
>> > From: Krzysztof Kozlowski <krzk@kernel.org>
>> > Sent: Sunday, May 25, 2025 9:02 PM
>> > To: Shankari Anand <shankari.ak0208@gmail.com>; devicetree@vger.kernel.org
>> > Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley
>> > <conor+dt@kernel.org>; William Zhang <william.zhang@broadcom.com>;
>> > Anand Gore <anand.gore@broadcom.com>; Kursad Oney
>> > <kursad.oney@broadcom.com>; Florian Fainelli
>> > <florian.fainelli@broadcom.com>; Rafał Miłecki <rafal@milecki.pl>;
>> > Broadcom
>> > internal kernel review list <bcm-kernel-feedback-list@broadcom.com>; Rob
>> > Herring <robh@kernel.org>; skhan@linuxfoundation.org
>> > Subject: Re: [PATCH] dt-bindings: arm/bcm: Fix and validate brcm,bcm63138
>> > bindings with no errors
>> >
>> > On 25/05/2025 21:43, Shankari Anand wrote:
>> > > Fix and validate brcm,bcm63138 device tree bindings by correcting schema
>> > > and
>> > example files.
>> >
>> > Nothing like that is done here.
>> >
>> > > This resolves previous schema validation errors and ensures compliance
>> > > with
>> > devicetree core schema requirements.
>> >
>> > Which errors?
>> >
>> > > The patch passes dtbs check successfully, confirming the YAML bindings,
>> > example DTS, and generated DTB are error-free.
>> >
>> > Drop, redundant.
>> >
>> > Please wrap commit message according to Linux coding style / submission
>> > process (neither too early nor over the limit):
>> > https://elixir.bootlin.com/linux/v6.4-
>> > rc1/source/Documentation/process/submitting-patches.rst#L597
>> >
>> > >
>> > > Signed-off-by: Shankari Anand <shankari.ak0208@gmail.com>
>> > > ---
>> > > .../bindings/arm/bcm/brcm,bcm63138.yaml | 43 +++++++++++++++++++
>> >
>> > > 1 file changed, 43 insertions(+)
>> > > create mode 100644
>> > Documentation/devicetree/bindings/arm/bcm/brcm,bcm63138.yaml
>> > >
>> > > diff --git
>> > a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm63138.yaml
>> > b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm63138.yaml
>> > > new file mode 100644
>> > > index 000000000000..5848f96128e1
>> > > --- /dev/null
>> > > +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm63138.yaml
>> > > @@ -0,0 +1,43 @@
>> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> > > +%YAML 1.2
>> > > +---
>> > > +$id: http://devicetree.org/schemas/arm/bcm/brcm,bcm63138.yaml#
>> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> > > +
>> > > +title: Broadcom BCM63138 DSL SoC
>> > > +
>> > > +maintainers:
>> > > + - Shankari Anand <shankari.ak0208@gmail.com>
>> > > +
>> > > +description: |
>> > > + The Broadcom BCM63138 DSL System-on-a-Chip is designed for DSL
>> > platforms.
>> > > + It supports multi-core ARM Cortex-A9 CPUs, a boot lookup table
>> > > (BootLUT),
>> > > + and software-controlled resets using a system timer.
>> > > +
>> > > +select:
>> > > + properties:
>> > > + compatible:
>> > > + contains:
>> > > + const: brcm,bcm63138
>> > > + required:
>> > > + - compatible
>> > > +
>> > > +properties:
>> > > + compatible:
>> > > + const: brcm,bcm63138
>> >
>> > You are duplicating existing bindings - both TXT and schema. Maybe you
>> > wanted to do the conversion, but that's still duplication.
>> >
>> > > +
>> > > +patternProperties:
>> > > + "^bootlut(@[0-9a-f]+)?$":
>> > > + type: object
>> > > + properties:
>> > > + compatible:
>> > > + const: brcm,bcm63138-bootlut
>> > > +
>> > > + reg:
>> > > + maxItems: 1
>> > > +
>> > > + required:
>> > > + - compatible
>> > > + - reg
>> > > +
>> > > +additionalProperties: true
>> >
>> > No, this cannot be true. Look at other bindings... or is it soc/platform
>> > file? I really do not understand what you want to achieve here.
>> >
>> I guess we need to find a proper home for brcm,bcm63138-bootlut since it is
>> used in the kernel source.
>> brcm,bcmbca.yaml covers all the soc already including bcm63138. Would it be
>> the right direction to add a new
>> yaml file for brcm,bcm63138-bootlut block itself and drop the
>> brcm,bcm63138.txt completely?
>>
>> >
>> > Best regards,
>> > Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: arm/bcm: Fix and validate brcm,bcm63138 bindings with no errors
[not found] ` <CAPRMd3n733TzxJMo1JooHBavSnjN=AWT_hKV38LOeZBpPHrnrw@mail.gmail.com>
@ 2025-06-08 18:42 ` Shankari Anand
0 siblings, 0 replies; 6+ messages in thread
From: Shankari Anand @ 2025-06-08 18:42 UTC (permalink / raw)
To: William Zhang
Cc: Krzysztof Kozlowski, devicetree, Krzysztof Kozlowski,
Conor Dooley, Anand Gore, Kursad Oney, Florian Fainelli,
Rafał Miłecki, Broadcom internal kernel review list,
Rob Herring, skhan
Patch link - https://lore.kernel.org/linux-devicetree/20250608183745.126190-1-shankari.ak0208@gmail.com/T/#u
On Mon, Jun 9, 2025 at 12:11 AM Shankari Anand
<shankari.ak0208@gmail.com> wrote:
>
> Patch link - https://lore.kernel.org/linux-devicetree/20250608183745.126190-1-shankari.ak0208@gmail.com/T/#u
>
>
> On Mon, Jun 9, 2025 at 12:10 AM Shankari Anand <shankari.ak0208@gmail.com> wrote:
>>
>> > I guess we need to find a proper home for brcm,bcm63138-bootlut since it is
>> > used in the kernel source.
>> > brcm,bcmbca.yaml covers all the soc already including bcm63138.
>>
>> Yeah, I realised bcm63138 is included in the compatible devices under
>> brcm,bca but the boot-lut doesn't seem to be satisfied because of
>> which the .txt isn't satisfied. I have shared a v2 patch which solves
>> this possibly. Here's the link - Patch
>>
>> Regards,
>> Shankari
>>
>>
>> On Mon, Jun 9, 2025 at 12:09 AM Shankari Anand
>> <shankari.ak0208@gmail.com> wrote:
>> >>
>> >> I guess we need to find a proper home for brcm,bcm63138-bootlut since it is
>> >> used in the kernel source.
>> >> brcm,bcmbca.yaml covers all the soc already including bcm63138.
>> >
>> >
>> > Yeah, I realised bcm63138 is included in the compatible devices under brcm,bca but the boot-lut doesn't seem to be satisfied because of which the .txt isn't satisfied. I have shared a v2 patch which solves this possibly. Here's the link - Patch
>> >
>> >
>> > On Wed, May 28, 2025 at 3:13 AM William Zhang <william.zhang@broadcom.com> wrote:
>> >>
>> >> Hi Shankari and Krzysztof,
>> >>
>> >> > -----Original Message-----
>> >> > From: Krzysztof Kozlowski <krzk@kernel.org>
>> >> > Sent: Sunday, May 25, 2025 9:02 PM
>> >> > To: Shankari Anand <shankari.ak0208@gmail.com>; devicetree@vger.kernel.org
>> >> > Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley
>> >> > <conor+dt@kernel.org>; William Zhang <william.zhang@broadcom.com>;
>> >> > Anand Gore <anand.gore@broadcom.com>; Kursad Oney
>> >> > <kursad.oney@broadcom.com>; Florian Fainelli
>> >> > <florian.fainelli@broadcom.com>; Rafał Miłecki <rafal@milecki.pl>;
>> >> > Broadcom
>> >> > internal kernel review list <bcm-kernel-feedback-list@broadcom.com>; Rob
>> >> > Herring <robh@kernel.org>; skhan@linuxfoundation.org
>> >> > Subject: Re: [PATCH] dt-bindings: arm/bcm: Fix and validate brcm,bcm63138
>> >> > bindings with no errors
>> >> >
>> >> > On 25/05/2025 21:43, Shankari Anand wrote:
>> >> > > Fix and validate brcm,bcm63138 device tree bindings by correcting schema
>> >> > > and
>> >> > example files.
>> >> >
>> >> > Nothing like that is done here.
>> >> >
>> >> > > This resolves previous schema validation errors and ensures compliance
>> >> > > with
>> >> > devicetree core schema requirements.
>> >> >
>> >> > Which errors?
>> >> >
>> >> > > The patch passes dtbs check successfully, confirming the YAML bindings,
>> >> > example DTS, and generated DTB are error-free.
>> >> >
>> >> > Drop, redundant.
>> >> >
>> >> > Please wrap commit message according to Linux coding style / submission
>> >> > process (neither too early nor over the limit):
>> >> > https://elixir.bootlin.com/linux/v6.4-
>> >> > rc1/source/Documentation/process/submitting-patches.rst#L597
>> >> >
>> >> > >
>> >> > > Signed-off-by: Shankari Anand <shankari.ak0208@gmail.com>
>> >> > > ---
>> >> > > .../bindings/arm/bcm/brcm,bcm63138.yaml | 43 +++++++++++++++++++
>> >> >
>> >> > > 1 file changed, 43 insertions(+)
>> >> > > create mode 100644
>> >> > Documentation/devicetree/bindings/arm/bcm/brcm,bcm63138.yaml
>> >> > >
>> >> > > diff --git
>> >> > a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm63138.yaml
>> >> > b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm63138.yaml
>> >> > > new file mode 100644
>> >> > > index 000000000000..5848f96128e1
>> >> > > --- /dev/null
>> >> > > +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm63138.yaml
>> >> > > @@ -0,0 +1,43 @@
>> >> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> >> > > +%YAML 1.2
>> >> > > +---
>> >> > > +$id: http://devicetree.org/schemas/arm/bcm/brcm,bcm63138.yaml#
>> >> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> >> > > +
>> >> > > +title: Broadcom BCM63138 DSL SoC
>> >> > > +
>> >> > > +maintainers:
>> >> > > + - Shankari Anand <shankari.ak0208@gmail.com>
>> >> > > +
>> >> > > +description: |
>> >> > > + The Broadcom BCM63138 DSL System-on-a-Chip is designed for DSL
>> >> > platforms.
>> >> > > + It supports multi-core ARM Cortex-A9 CPUs, a boot lookup table
>> >> > > (BootLUT),
>> >> > > + and software-controlled resets using a system timer.
>> >> > > +
>> >> > > +select:
>> >> > > + properties:
>> >> > > + compatible:
>> >> > > + contains:
>> >> > > + const: brcm,bcm63138
>> >> > > + required:
>> >> > > + - compatible
>> >> > > +
>> >> > > +properties:
>> >> > > + compatible:
>> >> > > + const: brcm,bcm63138
>> >> >
>> >> > You are duplicating existing bindings - both TXT and schema. Maybe you
>> >> > wanted to do the conversion, but that's still duplication.
>> >> >
>> >> > > +
>> >> > > +patternProperties:
>> >> > > + "^bootlut(@[0-9a-f]+)?$":
>> >> > > + type: object
>> >> > > + properties:
>> >> > > + compatible:
>> >> > > + const: brcm,bcm63138-bootlut
>> >> > > +
>> >> > > + reg:
>> >> > > + maxItems: 1
>> >> > > +
>> >> > > + required:
>> >> > > + - compatible
>> >> > > + - reg
>> >> > > +
>> >> > > +additionalProperties: true
>> >> >
>> >> > No, this cannot be true. Look at other bindings... or is it soc/platform
>> >> > file? I really do not understand what you want to achieve here.
>> >> >
>> >> I guess we need to find a proper home for brcm,bcm63138-bootlut since it is
>> >> used in the kernel source.
>> >> brcm,bcmbca.yaml covers all the soc already including bcm63138. Would it be
>> >> the right direction to add a new
>> >> yaml file for brcm,bcm63138-bootlut block itself and drop the
>> >> brcm,bcm63138.txt completely?
>> >>
>> >> >
>> >> > Best regards,
>> >> > Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-06-08 18:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-25 19:43 [PATCH] dt-bindings: arm/bcm: Fix and validate brcm,bcm63138 bindings with no errors Shankari Anand
2025-05-26 4:01 ` Krzysztof Kozlowski
2025-05-27 21:43 ` William Zhang
[not found] ` <CAPRMd3nyaV5fWYP_iY7XxgfzCDLUTpqHR0ebb0dSQ68tmEM62w@mail.gmail.com>
2025-06-08 18:40 ` Shankari Anand
[not found] ` <CAPRMd3n733TzxJMo1JooHBavSnjN=AWT_hKV38LOeZBpPHrnrw@mail.gmail.com>
2025-06-08 18:42 ` Shankari Anand
-- strict thread matches above, loose matches on Subject: below --
2025-05-31 21:38 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.