From: Mario Limonciello <superm1@kernel.org>
To: "Gerd Hoffmann" <kraxel@redhat.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: "Christian König" <christian.koenig@amd.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Zack Rusin" <zack.rusin@broadcom.com>,
dri-devel@lists.freedesktop.org,
"Alex Deucher" <alexander.deucher@amd.com>,
amd-gfx@lists.freedesktop.org, "Ard Biesheuvel" <ardb@kernel.org>,
"Ce Sun" <cesun102@amd.com>, "Chia-I Wu" <olvaffe@gmail.com>,
"Danilo Krummrich" <dakr@kernel.org>,
"Dave Airlie" <airlied@redhat.com>,
"Deepak Rawat" <drawat.floss@gmail.com>,
"Dmitry Osipenko" <dmitry.osipenko@collabora.com>,
"Gurchetan Singh" <gurchetansingh@chromium.org>,
"Hans de Goede" <hansg@kernel.org>,
"Hawking Zhang" <Hawking.Zhang@amd.com>,
"Helge Deller" <deller@gmx.de>,
intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Javier Martinez Canillas" <javierm@redhat.com>,
"Jocelyn Falempe" <jfalempe@redhat.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Lijo Lazar" <lijo.lazar@amd.com>,
linux-efi@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
"Lucas De Marchi" <lucas.demarchi@intel.com>,
"Lyude Paul" <lyude@redhat.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Mario Limonciello" <mario.limonciello@amd.com>,
"Maxime Ripard" <mripard@kernel.org>,
nouveau@lists.freedesktop.org,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Simona Vetter" <simona@ffwll.ch>,
spice-devel@lists.freedesktop.org,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Timur Kristóf" <timur.kristof@gmail.com>,
"Tvrtko Ursulin" <tursulin@ursulin.net>,
virtualization@lists.linux.dev,
"Vitaly Prosyak" <vitaly.prosyak@amd.com>
Subject: Re: [PATCH 00/12] Recover sysfb after DRM probe failure
Date: Thu, 15 Jan 2026 10:39:56 -0600 [thread overview]
Message-ID: <c78e9794-e63f-47f9-a4cb-e3b5625ab828@kernel.org> (raw)
In-Reply-To: <aWkWSnJ7Xn6ukW-b@sirius.home.kraxel.org>
On 1/15/26 10:36 AM, Gerd Hoffmann wrote:
> Hi,
>
>>> At least for AMD GPUs remove_conflicting_devices() really early is
>>> necessary because otherwise some operations just result in a
>>> spontaneous system reboot.
>
>> It's similar for Intel. For us VGA emulation won't be used for EFI
>> boot, but we still can't have the previous driver poking around in
>> memory while the real driver is initializing. The entire memory layout
>> may get completely shuffled so there's no telling where such memory
>> accesses would land.
>
> Can you do stuff like checking which firmware is needed and whenever
> that can be loaded from the filesystem before calling
> remove_conflicting_devices() ?
>
That's something that I did in amdgpu a few years back.
I pushed the identification and ability to load firmware into early init
stages. It means that if you have a brand new GPU and run a modern
kernel with an older linux-firmware snapshot amdgpu will fail probe and
your framebuffer from EFI keeps working.
WARNING: multiple messages have this Message-ID (diff)
From: Mario Limonciello <superm1@kernel.org>
To: "Gerd Hoffmann" <kraxel@redhat.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: "Christian König" <christian.koenig@amd.com>,
"Zack Rusin" <zack.rusin@broadcom.com>,
dri-devel@lists.freedesktop.org,
"Alex Deucher" <alexander.deucher@amd.com>,
amd-gfx@lists.freedesktop.org, "Ard Biesheuvel" <ardb@kernel.org>,
"Ce Sun" <cesun102@amd.com>, "Chia-I Wu" <olvaffe@gmail.com>,
"Danilo Krummrich" <dakr@kernel.org>,
"Dave Airlie" <airlied@redhat.com>,
"Deepak Rawat" <drawat.floss@gmail.com>,
"Dmitry Osipenko" <dmitry.osipenko@collabora.com>,
"Gurchetan Singh" <gurchetansingh@chromium.org>,
"Hans de Goede" <hansg@kernel.org>,
"Hawking Zhang" <Hawking.Zhang@amd.com>,
"Helge Deller" <deller@gmx.de>,
intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Javier Martinez Canillas" <javierm@redhat.com>,
"Jocelyn Falempe" <jfalempe@redhat.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Lijo Lazar" <lijo.lazar@amd.com>,
linux-efi@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
"Lucas De Marchi" <lucas.demarchi@intel.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Mario Limonciello" <mario.limonciello@amd.com>,
"Maxime Ripard" <mripard@kernel.org>,
nouveau@lists.freedesktop.org,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Simona Vetter" <simona@ffwll.ch>,
spice-devel@lists.freedesktop.org,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Timur Kristóf" <timur.kristof@gmail.com>,
"Tvrtko Ursulin" <tursulin@ursulin.net>,
virtualization@lists.linux.dev,
"Vitaly Prosyak" <vitaly.prosyak@amd.com>
Subject: Re: [PATCH 00/12] Recover sysfb after DRM probe failure
Date: Thu, 15 Jan 2026 10:39:56 -0600 [thread overview]
Message-ID: <c78e9794-e63f-47f9-a4cb-e3b5625ab828@kernel.org> (raw)
In-Reply-To: <aWkWSnJ7Xn6ukW-b@sirius.home.kraxel.org>
On 1/15/26 10:36 AM, Gerd Hoffmann wrote:
> Hi,
>
>>> At least for AMD GPUs remove_conflicting_devices() really early is
>>> necessary because otherwise some operations just result in a
>>> spontaneous system reboot.
>
>> It's similar for Intel. For us VGA emulation won't be used for EFI
>> boot, but we still can't have the previous driver poking around in
>> memory while the real driver is initializing. The entire memory layout
>> may get completely shuffled so there's no telling where such memory
>> accesses would land.
>
> Can you do stuff like checking which firmware is needed and whenever
> that can be loaded from the filesystem before calling
> remove_conflicting_devices() ?
>
That's something that I did in amdgpu a few years back.
I pushed the identification and ability to load firmware into early init
stages. It means that if you have a brand new GPU and run a modern
kernel with an older linux-firmware snapshot amdgpu will fail probe and
your framebuffer from EFI keeps working.
next prev parent reply other threads:[~2026-01-15 16:40 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-29 21:58 [PATCH 00/12] Recover sysfb after DRM probe failure Zack Rusin
2025-12-29 21:58 ` Zack Rusin
2025-12-29 21:58 ` [PATCH 01/12] video/aperture: Add sysfb restore on " Zack Rusin
2025-12-29 21:58 ` [PATCH 02/12] drm/vmwgfx: Use devm aperture helpers for sysfb restore on " Zack Rusin
2025-12-29 21:58 ` [PATCH 03/12] drm/xe: " Zack Rusin
2025-12-29 21:58 ` [PATCH 04/12] drm/amdgpu: " Zack Rusin
2025-12-29 21:58 ` [PATCH 05/12] drm/virtio: Add " Zack Rusin
2026-01-15 10:12 ` Dmitry Osipenko
2025-12-29 21:58 ` [PATCH 06/12] drm/nouveau: Use devm aperture helpers for " Zack Rusin
2025-12-29 21:58 ` Zack Rusin
2025-12-29 21:58 ` [PATCH 07/12] drm/qxl: " Zack Rusin
2025-12-29 21:58 ` [PATCH 08/12] drm/vboxvideo: " Zack Rusin
2025-12-29 21:58 ` [PATCH 09/12] drm/hyperv: Add " Zack Rusin
2025-12-29 21:58 ` [PATCH 10/12] drm/ast: Use devm aperture helpers for " Zack Rusin
2025-12-29 21:58 ` [PATCH 11/12] drm/radeon: " Zack Rusin
2025-12-29 21:58 ` [PATCH 12/12] drm/i915: " Zack Rusin
2026-01-09 10:34 ` [PATCH 00/12] Recover sysfb after DRM " Thomas Zimmermann
2026-01-09 10:34 ` Thomas Zimmermann
2026-01-10 4:52 ` Zack Rusin
2026-01-10 4:52 ` Zack Rusin
2026-01-10 4:52 ` Zack Rusin
2026-01-15 11:02 ` Thomas Zimmermann
2026-01-15 11:02 ` Thomas Zimmermann
2026-01-15 14:39 ` Christian König
2026-01-15 14:39 ` Christian König
2026-01-15 14:54 ` Thomas Zimmermann
2026-01-15 14:54 ` Thomas Zimmermann
2026-01-15 15:58 ` Christian König
2026-01-15 15:58 ` Christian König
2026-01-15 15:10 ` Ville Syrjälä
2026-01-15 15:10 ` Ville Syrjälä
2026-01-15 16:36 ` Gerd Hoffmann
2026-01-15 16:36 ` Gerd Hoffmann
2026-01-15 16:39 ` Mario Limonciello [this message]
2026-01-15 16:39 ` Mario Limonciello
2026-01-16 7:39 ` Thomas Zimmermann
2026-01-16 7:39 ` Thomas Zimmermann
2026-01-16 3:59 ` Zack Rusin
2026-01-16 3:59 ` Zack Rusin
2026-01-16 7:58 ` Thomas Zimmermann
2026-01-16 7:58 ` Thomas Zimmermann
2026-01-17 6:02 ` Zack Rusin
2026-01-17 6:02 ` Zack Rusin
2026-01-17 6:02 ` Zack Rusin
2026-01-19 10:03 ` Christian König
2026-01-19 10:03 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c78e9794-e63f-47f9-a4cb-e3b5625ab828@kernel.org \
--to=superm1@kernel.org \
--cc=Hawking.Zhang@amd.com \
--cc=airlied@redhat.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=ardb@kernel.org \
--cc=cesun102@amd.com \
--cc=christian.koenig@amd.com \
--cc=dakr@kernel.org \
--cc=deller@gmx.de \
--cc=dmitry.osipenko@collabora.com \
--cc=drawat.floss@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gurchetansingh@chromium.org \
--cc=hansg@kernel.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=javierm@redhat.com \
--cc=jfalempe@redhat.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kraxel@redhat.com \
--cc=lijo.lazar@amd.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=lyude@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mario.limonciello@amd.com \
--cc=mripard@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=olvaffe@gmail.com \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=spice-devel@lists.freedesktop.org \
--cc=thomas.hellstrom@linux.intel.com \
--cc=timur.kristof@gmail.com \
--cc=tursulin@ursulin.net \
--cc=tzimmermann@suse.de \
--cc=ville.syrjala@linux.intel.com \
--cc=virtualization@lists.linux.dev \
--cc=vitaly.prosyak@amd.com \
--cc=zack.rusin@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.