From: Paolo Bonzini <pbonzini@redhat.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>,
Sean Christopherson <sean.j.christopherson@intel.com>
Cc: Paul Mackerras <paulus@ozlabs.org>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
David Hildenbrand <david@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
Marc Zyngier <maz@kernel.org>, James Morse <james.morse@arm.com>,
Julien Thierry <julien.thierry.kdev@gmail.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
linux-mips@vger.kernel.org, kvm@vger.kernel.org,
kvm-ppc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/9] KVM: VMX: Configure runtime hooks using vmx_x86_ops
Date: Mon, 23 Mar 2020 20:00:50 +0000 [thread overview]
Message-ID: <c7915319-8795-e466-e2df-478b1bf9734c@redhat.com> (raw)
In-Reply-To: <87ftdz9ryn.fsf@vitty.brq.redhat.com>
On 23/03/20 13:27, Vitaly Kuznetsov wrote:
>> - kvm_x86_ops->check_nested_events = vmx_check_nested_events;
>> - kvm_x86_ops->get_nested_state = vmx_get_nested_state;
>> - kvm_x86_ops->set_nested_state = vmx_set_nested_state;
>> - kvm_x86_ops->get_vmcs12_pages = nested_get_vmcs12_pages;
>> - kvm_x86_ops->nested_enable_evmcs = nested_enable_evmcs;
>> - kvm_x86_ops->nested_get_evmcs_version = nested_get_evmcs_version;
>> + ops->check_nested_events = vmx_check_nested_events;
>> + ops->get_nested_state = vmx_get_nested_state;
>> + ops->set_nested_state = vmx_set_nested_state;
>> + ops->get_vmcs12_pages = nested_get_vmcs12_pages;
>> + ops->nested_enable_evmcs = nested_enable_evmcs;
>> + ops->nested_get_evmcs_version = nested_get_evmcs_version;
>
> A lazy guy like me would appreciate 'ops' -> 'vmx_x86_ops' rename as it
> would make 'git grep vmx_x86_ops' output more complete.
>
I would prefer even more a kvm_x86_ops.nested struct but I would be okay
with a separate patch.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>,
Sean Christopherson <sean.j.christopherson@intel.com>
Cc: Wanpeng Li <wanpengli@tencent.com>,
Janosch Frank <frankja@linux.ibm.com>,
kvm@vger.kernel.org, David Hildenbrand <david@redhat.com>,
Marc Zyngier <maz@kernel.org>, Joerg Roedel <joro@8bytes.org>,
Cornelia Huck <cohuck@redhat.com>,
linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org,
linux-kernel@vger.kernel.org, Paul Mackerras <paulus@ozlabs.org>,
Christian Borntraeger <borntraeger@de.ibm.com>,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, Jim Mattson <jmattson@google.com>
Subject: Re: [PATCH v3 4/9] KVM: VMX: Configure runtime hooks using vmx_x86_ops
Date: Mon, 23 Mar 2020 21:00:50 +0100 [thread overview]
Message-ID: <c7915319-8795-e466-e2df-478b1bf9734c@redhat.com> (raw)
In-Reply-To: <87ftdz9ryn.fsf@vitty.brq.redhat.com>
On 23/03/20 13:27, Vitaly Kuznetsov wrote:
>> - kvm_x86_ops->check_nested_events = vmx_check_nested_events;
>> - kvm_x86_ops->get_nested_state = vmx_get_nested_state;
>> - kvm_x86_ops->set_nested_state = vmx_set_nested_state;
>> - kvm_x86_ops->get_vmcs12_pages = nested_get_vmcs12_pages;
>> - kvm_x86_ops->nested_enable_evmcs = nested_enable_evmcs;
>> - kvm_x86_ops->nested_get_evmcs_version = nested_get_evmcs_version;
>> + ops->check_nested_events = vmx_check_nested_events;
>> + ops->get_nested_state = vmx_get_nested_state;
>> + ops->set_nested_state = vmx_set_nested_state;
>> + ops->get_vmcs12_pages = nested_get_vmcs12_pages;
>> + ops->nested_enable_evmcs = nested_enable_evmcs;
>> + ops->nested_get_evmcs_version = nested_get_evmcs_version;
>
> A lazy guy like me would appreciate 'ops' -> 'vmx_x86_ops' rename as it
> would make 'git grep vmx_x86_ops' output more complete.
>
I would prefer even more a kvm_x86_ops.nested struct but I would be okay
with a separate patch.
Paolo
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>,
Sean Christopherson <sean.j.christopherson@intel.com>
Cc: Paul Mackerras <paulus@ozlabs.org>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
David Hildenbrand <david@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
Marc Zyngier <maz@kernel.org>, James Morse <james.morse@arm.com>,
Julien Thierry <julien.thierry.kdev@gmail.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
linux-mips@vger.kernel.org, kvm@vger.kernel.org,
kvm-ppc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/9] KVM: VMX: Configure runtime hooks using vmx_x86_ops
Date: Mon, 23 Mar 2020 21:00:50 +0100 [thread overview]
Message-ID: <c7915319-8795-e466-e2df-478b1bf9734c@redhat.com> (raw)
In-Reply-To: <87ftdz9ryn.fsf@vitty.brq.redhat.com>
On 23/03/20 13:27, Vitaly Kuznetsov wrote:
>> - kvm_x86_ops->check_nested_events = vmx_check_nested_events;
>> - kvm_x86_ops->get_nested_state = vmx_get_nested_state;
>> - kvm_x86_ops->set_nested_state = vmx_set_nested_state;
>> - kvm_x86_ops->get_vmcs12_pages = nested_get_vmcs12_pages;
>> - kvm_x86_ops->nested_enable_evmcs = nested_enable_evmcs;
>> - kvm_x86_ops->nested_get_evmcs_version = nested_get_evmcs_version;
>> + ops->check_nested_events = vmx_check_nested_events;
>> + ops->get_nested_state = vmx_get_nested_state;
>> + ops->set_nested_state = vmx_set_nested_state;
>> + ops->get_vmcs12_pages = nested_get_vmcs12_pages;
>> + ops->nested_enable_evmcs = nested_enable_evmcs;
>> + ops->nested_get_evmcs_version = nested_get_evmcs_version;
>
> A lazy guy like me would appreciate 'ops' -> 'vmx_x86_ops' rename as it
> would make 'git grep vmx_x86_ops' output more complete.
>
I would prefer even more a kvm_x86_ops.nested struct but I would be okay
with a separate patch.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>,
Sean Christopherson <sean.j.christopherson@intel.com>
Cc: Wanpeng Li <wanpengli@tencent.com>,
Janosch Frank <frankja@linux.ibm.com>,
kvm@vger.kernel.org, David Hildenbrand <david@redhat.com>,
Marc Zyngier <maz@kernel.org>, Joerg Roedel <joro@8bytes.org>,
Cornelia Huck <cohuck@redhat.com>,
linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org,
linux-kernel@vger.kernel.org, Paul Mackerras <paulus@ozlabs.org>,
Christian Borntraeger <borntraeger@de.ibm.com>,
James Morse <james.morse@arm.com>,
linux-arm-kernel@lists.infradead.org,
Suzuki K Poulose <suzuki.poulose@arm.com>,
kvmarm@lists.cs.columbia.edu,
Julien Thierry <julien.thierry.kdev@gmail.com>,
Jim Mattson <jmattson@google.com>
Subject: Re: [PATCH v3 4/9] KVM: VMX: Configure runtime hooks using vmx_x86_ops
Date: Mon, 23 Mar 2020 21:00:50 +0100 [thread overview]
Message-ID: <c7915319-8795-e466-e2df-478b1bf9734c@redhat.com> (raw)
In-Reply-To: <87ftdz9ryn.fsf@vitty.brq.redhat.com>
On 23/03/20 13:27, Vitaly Kuznetsov wrote:
>> - kvm_x86_ops->check_nested_events = vmx_check_nested_events;
>> - kvm_x86_ops->get_nested_state = vmx_get_nested_state;
>> - kvm_x86_ops->set_nested_state = vmx_set_nested_state;
>> - kvm_x86_ops->get_vmcs12_pages = nested_get_vmcs12_pages;
>> - kvm_x86_ops->nested_enable_evmcs = nested_enable_evmcs;
>> - kvm_x86_ops->nested_get_evmcs_version = nested_get_evmcs_version;
>> + ops->check_nested_events = vmx_check_nested_events;
>> + ops->get_nested_state = vmx_get_nested_state;
>> + ops->set_nested_state = vmx_set_nested_state;
>> + ops->get_vmcs12_pages = nested_get_vmcs12_pages;
>> + ops->nested_enable_evmcs = nested_enable_evmcs;
>> + ops->nested_get_evmcs_version = nested_get_evmcs_version;
>
> A lazy guy like me would appreciate 'ops' -> 'vmx_x86_ops' rename as it
> would make 'git grep vmx_x86_ops' output more complete.
>
I would prefer even more a kvm_x86_ops.nested struct but I would be okay
with a separate patch.
Paolo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-23 20:00 UTC|newest]
Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-21 20:25 [PATCH v3 0/9] KVM: Move x86 init ops to separate struct Sean Christopherson
2020-03-21 20:25 ` Sean Christopherson
2020-03-21 20:25 ` Sean Christopherson
2020-03-21 20:25 ` Sean Christopherson
2020-03-21 20:25 ` [PATCH v3 1/9] KVM: Pass kvm_init()'s opaque param to additional arch funcs Sean Christopherson
2020-03-21 20:25 ` Sean Christopherson
2020-03-21 20:25 ` Sean Christopherson
2020-03-21 20:25 ` Sean Christopherson
2020-03-24 1:18 ` Paul Mackerras
2020-03-24 1:18 ` Paul Mackerras
2020-03-24 1:18 ` Paul Mackerras
2020-03-24 1:18 ` Paul Mackerras
2020-03-21 20:25 ` [PATCH v3 2/9] KVM: x86: Move init-only kvm_x86_ops to separate struct Sean Christopherson
2020-03-21 20:25 ` Sean Christopherson
2020-03-21 20:25 ` Sean Christopherson
2020-03-21 20:25 ` Sean Christopherson
2020-03-23 12:10 ` Vitaly Kuznetsov
2020-03-23 12:10 ` Vitaly Kuznetsov
2020-03-23 12:10 ` Vitaly Kuznetsov
2020-03-23 12:10 ` Vitaly Kuznetsov
2020-03-23 15:29 ` Sean Christopherson
2020-03-23 15:29 ` Sean Christopherson
2020-03-23 15:29 ` Sean Christopherson
2020-03-23 15:29 ` Sean Christopherson
2020-03-23 16:24 ` Vitaly Kuznetsov
2020-03-23 16:24 ` Vitaly Kuznetsov
2020-03-23 16:24 ` Vitaly Kuznetsov
2020-03-23 16:24 ` Vitaly Kuznetsov
2020-03-23 16:31 ` Sean Christopherson
2020-03-23 16:31 ` Sean Christopherson
2020-03-23 16:31 ` Sean Christopherson
2020-03-23 16:31 ` Sean Christopherson
2020-03-23 19:47 ` Paolo Bonzini
2020-03-23 19:47 ` Paolo Bonzini
2020-03-23 19:47 ` Paolo Bonzini
2020-03-23 19:47 ` Paolo Bonzini
2020-03-21 20:25 ` [PATCH v3 3/9] KVM: VMX: Move hardware_setup() definition below vmx_x86_ops Sean Christopherson
2020-03-21 20:25 ` Sean Christopherson
2020-03-21 20:25 ` Sean Christopherson
2020-03-21 20:25 ` Sean Christopherson
2020-03-23 12:12 ` Vitaly Kuznetsov
2020-03-23 12:12 ` Vitaly Kuznetsov
2020-03-23 12:12 ` Vitaly Kuznetsov
2020-03-23 12:12 ` Vitaly Kuznetsov
2020-03-21 20:25 ` [PATCH v3 4/9] KVM: VMX: Configure runtime hooks using vmx_x86_ops Sean Christopherson
2020-03-21 20:25 ` Sean Christopherson
2020-03-21 20:25 ` Sean Christopherson
2020-03-21 20:25 ` Sean Christopherson
2020-03-23 12:27 ` Vitaly Kuznetsov
2020-03-23 12:27 ` Vitaly Kuznetsov
2020-03-23 12:27 ` Vitaly Kuznetsov
2020-03-23 12:27 ` Vitaly Kuznetsov
2020-03-23 16:23 ` Sean Christopherson
2020-03-23 16:23 ` Sean Christopherson
2020-03-23 16:23 ` Sean Christopherson
2020-03-23 16:23 ` Sean Christopherson
2020-03-23 20:00 ` Paolo Bonzini [this message]
2020-03-23 20:00 ` Paolo Bonzini
2020-03-23 20:00 ` Paolo Bonzini
2020-03-23 20:00 ` Paolo Bonzini
2020-03-21 20:25 ` [PATCH v3 5/9] KVM: x86: Set kvm_x86_ops only after ->hardware_setup() completes Sean Christopherson
2020-03-21 20:25 ` Sean Christopherson
2020-03-21 20:25 ` Sean Christopherson
2020-03-21 20:25 ` Sean Christopherson
2020-03-21 20:26 ` [PATCH v3 6/9] KVM: x86: Copy kvm_x86_ops by value to eliminate layer of indirection Sean Christopherson
2020-03-21 20:26 ` Sean Christopherson
2020-03-21 20:26 ` Sean Christopherson
2020-03-21 20:26 ` Sean Christopherson
2020-03-23 12:44 ` Vitaly Kuznetsov
2020-03-23 12:44 ` Vitaly Kuznetsov
2020-03-23 12:44 ` Vitaly Kuznetsov
2020-03-23 12:44 ` Vitaly Kuznetsov
2020-03-23 15:38 ` Sean Christopherson
2020-03-23 15:38 ` Sean Christopherson
2020-03-23 15:38 ` Sean Christopherson
2020-03-23 15:38 ` Sean Christopherson
2020-03-21 20:26 ` [PATCH v3 7/9] KVM: x86: Drop __exit from kvm_x86_ops' hardware_unsetup() Sean Christopherson
2020-03-21 20:26 ` Sean Christopherson
2020-03-21 20:26 ` Sean Christopherson
2020-03-21 20:26 ` Sean Christopherson
2020-03-23 12:46 ` Vitaly Kuznetsov
2020-03-23 12:46 ` Vitaly Kuznetsov
2020-03-23 12:46 ` Vitaly Kuznetsov
2020-03-23 12:46 ` Vitaly Kuznetsov
2020-03-21 20:26 ` [PATCH v3 8/9] KVM: VMX: Annotate vmx_x86_ops as __initdata Sean Christopherson
2020-03-21 20:26 ` Sean Christopherson
2020-03-21 20:26 ` Sean Christopherson
2020-03-21 20:26 ` Sean Christopherson
2020-03-23 12:48 ` Vitaly Kuznetsov
2020-03-23 12:48 ` Vitaly Kuznetsov
2020-03-23 12:48 ` Vitaly Kuznetsov
2020-03-23 12:48 ` Vitaly Kuznetsov
2020-03-21 20:26 ` [PATCH v3 9/9] KVM: SVM: Annotate svm_x86_ops " Sean Christopherson
2020-03-21 20:26 ` Sean Christopherson
2020-03-21 20:26 ` Sean Christopherson
2020-03-21 20:26 ` Sean Christopherson
2020-03-23 12:48 ` Vitaly Kuznetsov
2020-03-23 12:48 ` Vitaly Kuznetsov
2020-03-23 12:48 ` Vitaly Kuznetsov
2020-03-23 12:48 ` Vitaly Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7915319-8795-e466-e2df-478b1bf9734c@redhat.com \
--to=pbonzini@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=james.morse@arm.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=julien.thierry.kdev@gmail.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=maz@kernel.org \
--cc=paulus@ozlabs.org \
--cc=sean.j.christopherson@intel.com \
--cc=suzuki.poulose@arm.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.