All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>,
	qemu-devel@nongnu.org
Cc: "Daniel Henrique Barboza" <daniel.barboza@oss.qualcomm.com>,
	"Pierrick Bouvier" <pierrick.bouvier@oss.qualcomm.com>,
	"Mohamed Mediouni" <mohamed@unpredictable.fr>,
	"Alexander Graf" <agraf@csgraf.de>,
	qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, kvm@vger.kernel.org,
	"Richard Henderson" <richard.henderson@linaro.org>,
	qemu-arm@nongnu.org,
	"Magnus Kulke" <magnuskulke@linux.microsoft.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@mailo.com>,
	"Zhao Liu" <zhao1.liu@intel.com>
Subject: Re: [PATCH 06/16] cpus: Improve cpu_exit() docstring
Date: Mon, 17 Aug 2026 17:46:44 +0200	[thread overview]
Message-ID: <c7e16aa0-aebe-405a-8686-da002f054db8@redhat.com> (raw)
In-Reply-To: <20260813181640.6537-7-philmd@oss.qualcomm.com>

On 8/13/26 20:16, Philippe Mathieu-Daudé wrote:
> Mention that what the vCPU exits is the execution loop :)
> Mention some of the reasons for calling cpu_exit().
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>
> ---
>   include/hw/core/cpu.h | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h
> index f1ac492714e..7da81f3ee85 100644
> --- a/include/hw/core/cpu.h
> +++ b/include/hw/core/cpu.h
> @@ -1037,10 +1037,11 @@ static inline void cpu_set_pc(CPUState *cpu, vaddr addr)
>   void cpu_reset_interrupt(CPUState *cpu, int mask);
>   
>   /**
> - * cpu_exit:
> - * @cpu: The CPU to exit.
> + * cpu_exit - Request the CPU to exit its execution loop
> + * @cpu: The CPU to interrupt.
>    *
> - * Requests the CPU @cpu to exit execution.
> + * Request an immediate exit from the CPU execution loop to process
> + * pending work such as interrupts, timers, or other async requests.

More precise: to sleep or process asynchronous work items (see the 
run_on_cpu() family of functions).

Paolo



  reply	other threads:[~2026-08-17 15:47 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-13 18:16 [PATCH 00/16] cpus: Improvements around BQL locking, improving docstring Philippe Mathieu-Daudé
2026-08-13 18:16 ` [PATCH 01/16] accel: Label outer / inner vCPU execution loops Philippe Mathieu-Daudé
2026-08-13 18:16 ` [PATCH 02/16] cpus: Improve qemu_cpu_kick_self() docstring Philippe Mathieu-Daudé
2026-08-17 15:28   ` Paolo Bonzini
2026-08-17 15:45     ` Philippe Mathieu-Daudé
2026-08-18 10:27       ` Paolo Bonzini
2026-08-13 18:16 ` [PATCH 03/16] cpus: Rename cpu_stop_current() -> qemu_cpu_stop_self() Philippe Mathieu-Daudé
2026-08-13 18:16 ` [PATCH 04/16] cpus: Rename qemu_cpu_stop() to qemu_cpu_ack_stop_request() Philippe Mathieu-Daudé
2026-08-13 18:16 ` [PATCH 05/16] cpus: Improve cpu_pause() docstring Philippe Mathieu-Daudé
2026-08-13 18:16 ` [PATCH 06/16] cpus: Improve cpu_exit() docstring Philippe Mathieu-Daudé
2026-08-17 15:46   ` Paolo Bonzini [this message]
2026-08-13 18:16 ` [PATCH 07/16] cpus: Document process_queued_cpu_work*() runs on current vCPU Philippe Mathieu-Daudé
2026-08-13 18:16 ` [PATCH 08/16] cpus: Slightly improve *run_on_cpu() docstrings Philippe Mathieu-Daudé
2026-08-17 15:50   ` Paolo Bonzini
2026-08-17 16:00     ` Peter Maydell
2026-08-13 18:16 ` [PATCH 09/16] accel/tcg: Use RUN_ON_CPU_NULL for tcg_commit() callbacks Philippe Mathieu-Daudé
2026-08-13 18:16 ` [PATCH 10/16] accel/kvm: Clarify use of @r variable in vcpu thread loop Philippe Mathieu-Daudé
2026-08-13 18:16 ` [PATCH 11/16] accel/kvm: Consistently return CPU halt state from process_async_events Philippe Mathieu-Daudé
2026-08-17 15:59   ` Paolo Bonzini
2026-08-18  9:24     ` Philippe Mathieu-Daudé
2026-08-18 10:30       ` Paolo Bonzini
2026-08-18 13:07         ` Philippe Mathieu-Daudé
2026-08-13 18:16 ` [PATCH 12/16] target/arm/hvf: Move flush_cpu_state() into the inner vCPU loop Philippe Mathieu-Daudé
2026-08-13 18:16 ` [PATCH 13/16] target/arm/hvf: Lock BQL outside of the vCPU inner execution loop Philippe Mathieu-Daudé
2026-08-17 16:11   ` Paolo Bonzini
2026-08-18  8:48     ` Philippe Mathieu-Daudé
2026-08-13 18:16 ` [PATCH 14/16] target/i386/hvf: " Philippe Mathieu-Daudé
2026-08-17 16:15   ` Paolo Bonzini
2026-08-13 18:16 ` [PATCH 15/16] target/arm/powerctl: Move BQL assertions to async work context Philippe Mathieu-Daudé
2026-08-13 18:16 ` [PATCH 16/16] target/arm/whpx: Fix argument order typo in memory access error message Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c7e16aa0-aebe-405a-8686-da002f054db8@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=agraf@csgraf.de \
    --cc=daniel.barboza@oss.qualcomm.com \
    --cc=kvm@vger.kernel.org \
    --cc=magnuskulke@linux.microsoft.com \
    --cc=mohamed@unpredictable.fr \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@mailo.com \
    --cc=philmd@oss.qualcomm.com \
    --cc=pierrick.bouvier@oss.qualcomm.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=zhao1.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.