From: "Cédric Le Goater" <clg@kaod.org>
To: "Cédric Le Goater" <clg@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
Jamin Lin <jamin_lin@aspeedtech.com>
Subject: Re: [PATCH] aspeed/smc: Reintroduce "dram-base" property for AST2700
Date: Mon, 10 Jun 2024 11:23:59 +0200 [thread overview]
Message-ID: <c8490af5-466d-44fd-ace5-2b32f653e4b6@kaod.org> (raw)
In-Reply-To: <20240527124315.35356-1-clg@redhat.com>
On 5/27/24 2:43 PM, Cédric Le Goater wrote:
> The Aspeed SMC device model use to have a 'sdram_base' property. It
> was removed by commit d177892d4a48 ("aspeed/smc: Remove unused
> "sdram-base" property") because previous changes simplified the DMA
> transaction model to use an offset in RAM and not the physical
> address.
>
> The AST2700 SoC has larger address space (64-bit) and a new register
> DMA DRAM Side Address High Part (0x7C) is introduced to deal with the
> high bits of the DMA address. To be able to compute the offset of the
> DMA transaction, as done on the other SoCs, we will need to know where
> the DRAM is mapped in the address space. Re-introduce a "dram-base"
> property to hold this value.
>
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
> include/hw/ssi/aspeed_smc.h | 1 +
> hw/ssi/aspeed_smc.c | 1 +
> 2 files changed, 2 insertions(+)
Applied to aspeed-next.
Thanks,
C.
prev parent reply other threads:[~2024-06-10 9:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-27 12:43 [PATCH] aspeed/smc: Reintroduce "dram-base" property for AST2700 Cédric Le Goater
2024-05-27 16:10 ` Philippe Mathieu-Daudé
2024-05-28 1:31 ` Jamin Lin
2024-06-10 9:23 ` Cédric Le Goater [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8490af5-466d-44fd-ace5-2b32f653e4b6@kaod.org \
--to=clg@kaod.org \
--cc=clg@redhat.com \
--cc=jamin_lin@aspeedtech.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.