Re: [PATCH 2/3] dt-bindings: i3c: Add Amlogic A9 I3C controller

From: Krzysztof Kozlowski <krzk@kernel.org>
To: junyi.zhao@amlogic.com,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Frank Li <Frank.Li@nxp.com>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Kees Cook <kees@kernel.org>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: linux-i3c@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, imx@lists.linux.dev,
	linux-hardening@vger.kernel.org, xianwei.zhao@amlogic.com,
	Kelvin.Zhang@amlogic.com
Subject: Re: [PATCH 2/3] dt-bindings: i3c: Add Amlogic A9 I3C controller
Date: Mon, 19 Oct 2026 08:00:42 +0200	[thread overview]
Message-ID: <c84d861a-2e28-45b0-80c8-e533864d5e6c@kernel.org> (raw)
In-Reply-To: <20261019-a9_i3c-v1-2-329d819d621f@amlogic.com>

On 19/10/2026 07:34, Junyi Zhao via B4 Relay wrote:
> +properties:
> +  compatible:
> +    enum:
> +      - amlogic,i3c-a9
> +      - amlogic,i3c-ao-a9

What is ao?

> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  clocks:
> +    minItems: 1
> +    maxItems: 2
> +
> +  clock-names:
> +    minItems: 1
> +    maxItems: 2

Names go here

> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks
> +  - clock-names
> +
> +unevaluatedProperties: false

This goes before example

> +
> +if:

And this in allOf, see example schema or other bindings.

> +  properties:
> +    compatible:
> +      const: amlogic,i3c-a9
> +then:
> +  properties:
> +    clocks:
> +      items:
> +        - description: APB peripheral clock
> +        - description: I3C fast clock
> +    clock-names:
> +      items:
> +        - const: pclk
> +        - const: fast_clk

That's just fast

minItems: 1

> +else:
> +  properties:
> +    clocks:
> +      maxItems: 1
> +    clock-names:
> +      items:
> +        - const: fast_clk

maxItems: 1

> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +    i3c@3a7000 {
> +        compatible = "amlogic,i3c-a9";
> +        reg = <0x3a7000 0x10000>;
> +        interrupts = <GIC_SPI 153 IRQ_TYPE_LEVEL_HIGH>;
> +        #address-cells = <3>;
> +        #size-cells = <0>;
> +        clocks = <&clkc 15>,
> +                 <&clkc 16>;
> +        clock-names = "pclk", "fast_clk";
> +        status = "disabled";
> +    };
> +
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +    i3c@22000 {

Drop, one example is enough.

> +        compatible = "amlogic,i3c-ao-a9";
> +        reg = <0x22000 0x10000>;
> +        interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>;
> +        #address-cells = <3>;
> +        #size-cells = <0>;
> +        clocks = <&clkc 17>;
> +        clock-names = "fast_clk";
> +        status = "disabled";
> +    };
> +...
> 

Best regards,
Krzysztof